Instrument Tibco BusinessWorks 5 and 6 #7155

amarziali · 2024-06-11T07:50:24Z

What Does This Do

Provides instrumentation for TIBCO Businessworks 5.14+ and 6+. The instrumentation is currently in beta. An effort has been done to uniform the way processes and activities are traced in order to have the same in 5 and 6 (to minimize the migration burden for the customers)

It creates two different type of spans:

tibco.process: tracing processes
tibco.activity: tracing single activies or groups inside a process

The instrumentation is still in beta. In order to activate it, please activate it by:

System properties -Ddd.integration.tibco.enabled=true
Env variable: DD_INTEGRATION_TIBCO_ENABLED=true

Motivation

Additional Notes

Some notes for the reader:

Some classes are only stubbed in order to provide linkage for the instrumentations. They are not included in the agent jar and the real ones will be used at runtime.
Some classes are package private hence accessed with mate classes
tests are provided with separate project (tibco is not an opensource project)

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-06-11T08:38:19Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/tibco
git_commit_date	1719927125	1719930940
git_commit_sha	`2c9c668`	`92b2ee8`
release_version	1.37.0-SNAPSHOT~2c9c668c74	1.37.0-SNAPSHOT~92b2ee80e5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719934743	1719934743
ci_job_id	559813770	559813770
ci_pipeline_id	38140931	38140931
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066585
Total [baseline] (8.545 s) : 0, 8544655
Agent [candidate] (1.07 s) : 0, 1070035
Total [candidate] (8.551 s) : 0, 8550954
section iast
Agent [baseline] (1.171 s) : 0, 1171058
Total [baseline] (9.006 s) : 0, 9005996
Agent [candidate] (1.175 s) : 0, 1174955
Total [candidate] (9.004 s) : 0, 9003797
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175920
Total [baseline] (8.98 s) : 0, 8979662
Agent [candidate] (1.173 s) : 0, 1173379
Total [candidate] (8.981 s) : 0, 8980931
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1171746
Total [baseline] (8.999 s) : 0, 8998549
Agent [candidate] (1.178 s) : 0, 1177907
Total [candidate] (9.03 s) : 0, 9030081

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	iast	1.171 s	104.473 ms (9.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	109.335 ms (10.3%)
Agent	iast_TELEMETRY_OFF	1.172 s	105.161 ms (9.9%)
Total	tracing	8.545 s	-
Total	iast	9.006 s	461.342 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	8.98 s	435.007 ms (5.1%)
Total	iast_TELEMETRY_OFF	8.999 s	453.894 ms (5.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	iast	1.175 s	104.921 ms (9.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	103.344 ms (9.7%)
Agent	iast_TELEMETRY_OFF	1.178 s	107.873 ms (10.1%)
Total	tracing	8.551 s	-
Total	iast	9.004 s	452.844 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.981 s	429.977 ms (5.0%)
Total	iast_TELEMETRY_OFF	9.03 s	479.127 ms (5.6%)

gantt
    title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.748 ms) : 0, 667748
BytebuddyAgent [candidate] (669.698 ms) : 0, 669698
GlobalTracer [baseline] (305.717 ms) : 0, 305717
GlobalTracer [candidate] (306.346 ms) : 0, 306346
AppSec [baseline] (50.228 ms) : 0, 50228
AppSec [candidate] (50.9 ms) : 0, 50900
Remote Config [baseline] (727.706 µs) : 0, 728
Remote Config [candidate] (741.062 µs) : 0, 741
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.725 ms) : 0, 7725
section iast
BytebuddyAgent [baseline] (780.622 ms) : 0, 780622
BytebuddyAgent [candidate] (783.282 ms) : 0, 783282
GlobalTracer [baseline] (294.574 ms) : 0, 294574
GlobalTracer [candidate] (295.374 ms) : 0, 295374
AppSec [baseline] (47.353 ms) : 0, 47353
AppSec [candidate] (47.292 ms) : 0, 47292
Remote Config [baseline] (599.531 µs) : 0, 600
Remote Config [candidate] (570.686 µs) : 0, 571
Telemetry [baseline] (7.048 ms) : 0, 7048
Telemetry [candidate] (6.977 ms) : 0, 6977
IAST [baseline] (27.358 ms) : 0, 27358
IAST [candidate] (28.01 ms) : 0, 28010
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.032 ms) : 0, 782032
BytebuddyAgent [candidate] (781.584 ms) : 0, 781584
GlobalTracer [baseline] (295.527 ms) : 0, 295527
GlobalTracer [candidate] (295.645 ms) : 0, 295645
AppSec [baseline] (47.58 ms) : 0, 47580
AppSec [candidate] (47.389 ms) : 0, 47389
Remote Config [baseline] (595.163 µs) : 0, 595
Remote Config [candidate] (600.088 µs) : 0, 600
Telemetry [baseline] (7.02 ms) : 0, 7020
Telemetry [candidate] (7.046 ms) : 0, 7046
IAST [baseline] (29.604 ms) : 0, 29604
IAST [candidate] (27.61 ms) : 0, 27610
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.596 ms) : 0, 779596
BytebuddyAgent [candidate] (785.125 ms) : 0, 785125
GlobalTracer [baseline] (295.113 ms) : 0, 295113
GlobalTracer [candidate] (296.639 ms) : 0, 296639
AppSec [baseline] (47.136 ms) : 0, 47136
AppSec [candidate] (47.422 ms) : 0, 47422
Remote Config [baseline] (736.334 µs) : 0, 736
Remote Config [candidate] (588.201 µs) : 0, 588
Telemetry [baseline] (6.815 ms) : 0, 6815
Telemetry [candidate] (6.926 ms) : 0, 6926
IAST [baseline] (28.817 ms) : 0, 28817
IAST [candidate] (27.647 ms) : 0, 27647

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072559
Total [baseline] (10.365 s) : 0, 10364726
Agent [candidate] (1.068 s) : 0, 1068461
Total [candidate] (10.413 s) : 0, 10413460
section appsec
Agent [baseline] (1.184 s) : 0, 1184421
Total [baseline] (10.458 s) : 0, 10457861
Agent [candidate] (1.187 s) : 0, 1187345
Total [candidate] (10.491 s) : 0, 10491203
section iast
Agent [baseline] (1.174 s) : 0, 1173578
Total [baseline] (10.734 s) : 0, 10733906
Agent [candidate] (1.174 s) : 0, 1174489
Total [candidate] (10.745 s) : 0, 10745359
section profiling
Agent [baseline] (1.273 s) : 0, 1272831
Total [baseline] (10.693 s) : 0, 10692641
Agent [candidate] (1.267 s) : 0, 1266613
Total [candidate] (10.68 s) : 0, 10679771

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.073 s	-
Agent	appsec	1.184 s	111.862 ms (10.4%)
Agent	iast	1.174 s	101.019 ms (9.4%)
Agent	profiling	1.273 s	200.272 ms (18.7%)
Total	tracing	10.365 s	-
Total	appsec	10.458 s	93.134 ms (0.9%)
Total	iast	10.734 s	369.179 ms (3.6%)
Total	profiling	10.693 s	327.915 ms (3.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	appsec	1.187 s	118.884 ms (11.1%)
Agent	iast	1.174 s	106.028 ms (9.9%)
Agent	profiling	1.267 s	198.152 ms (18.5%)
Total	tracing	10.413 s	-
Total	appsec	10.491 s	77.742 ms (0.7%)
Total	iast	10.745 s	331.899 ms (3.2%)
Total	profiling	10.68 s	266.311 ms (2.6%)

gantt
    title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.88 ms) : 0, 671880
BytebuddyAgent [candidate] (669.246 ms) : 0, 669246
GlobalTracer [baseline] (306.784 ms) : 0, 306784
GlobalTracer [candidate] (305.665 ms) : 0, 305665
AppSec [baseline] (50.578 ms) : 0, 50578
AppSec [candidate] (50.42 ms) : 0, 50420
Remote Config [baseline] (742.226 µs) : 0, 742
Remote Config [candidate] (717.52 µs) : 0, 718
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (7.614 ms) : 0, 7614
section appsec
BytebuddyAgent [baseline] (676.921 ms) : 0, 676921
BytebuddyAgent [candidate] (680.282 ms) : 0, 680282
GlobalTracer [baseline] (298.46 ms) : 0, 298460
GlobalTracer [candidate] (299.609 ms) : 0, 299609
AppSec [baseline] (154.04 ms) : 0, 154040
AppSec [candidate] (154.398 ms) : 0, 154398
Remote Config [baseline] (634.369 µs) : 0, 634
Remote Config [candidate] (635.23 µs) : 0, 635
Telemetry [baseline] (8.3 ms) : 0, 8300
Telemetry [candidate] (7.141 ms) : 0, 7141
IAST [baseline] (22.789 ms) : 0, 22789
IAST [candidate] (20.869 ms) : 0, 20869
section iast
BytebuddyAgent [baseline] (781.037 ms) : 0, 781037
BytebuddyAgent [candidate] (783.331 ms) : 0, 783331
GlobalTracer [baseline] (295.302 ms) : 0, 295302
GlobalTracer [candidate] (295.919 ms) : 0, 295919
AppSec [baseline] (47.354 ms) : 0, 47354
AppSec [candidate] (47.487 ms) : 0, 47487
Remote Config [baseline] (599.958 µs) : 0, 600
Remote Config [candidate] (579.589 µs) : 0, 580
Telemetry [baseline] (6.943 ms) : 0, 6943
Telemetry [candidate] (7.057 ms) : 0, 7057
IAST [baseline] (28.765 ms) : 0, 28765
IAST [candidate] (26.644 ms) : 0, 26644
section profiling
ProfilingAgent [baseline] (96.896 ms) : 0, 96896
ProfilingAgent [candidate] (95.42 ms) : 0, 95420
BytebuddyAgent [baseline] (667.714 ms) : 0, 667714
BytebuddyAgent [candidate] (665.386 ms) : 0, 665386
GlobalTracer [baseline] (390.371 ms) : 0, 390371
GlobalTracer [candidate] (389.067 ms) : 0, 389067
AppSec [baseline] (52.127 ms) : 0, 52127
AppSec [candidate] (51.467 ms) : 0, 51467
Remote Config [baseline] (663.667 µs) : 0, 664
Remote Config [candidate] (668.098 µs) : 0, 668
Telemetry [baseline] (7.432 ms) : 0, 7432
Telemetry [candidate] (7.333 ms) : 0, 7333
Profiling [baseline] (96.922 ms) : 0, 96922
Profiling [candidate] (95.445 ms) : 0, 95445

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-07-02T15:09:50	2024-07-02T15:16:38
git_branch	master	andrea.marziali/tibco
git_commit_date	1719927125	1719930940
git_commit_sha	`2c9c668`	`92b2ee8`
release_version	1.37.0-SNAPSHOT~2c9c668c74	1.37.0-SNAPSHOT~92b2ee80e5
start_time	2024-07-02T15:09:37	2024-07-02T15:16:25

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719933743	1719933743
ci_job_id	559813773	559813773
ci_pipeline_id	38140931	38140931
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.963 µs) : 349, 387
.   : milestone, 368,
iast (482.975 µs) : 462, 504
.   : milestone, 483,
iast_FULL (550.212 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (500.725 µs) : 480, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (478.796 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (451.162 µs) : 430, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (465.807 µs) : 445, 487
.   : milestone, 466,
tracing (443.203 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (367.17 µs) : 348, 387
.   : milestone, 367,
iast (482.594 µs) : 461, 504
.   : milestone, 483,
iast_FULL (547.921 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (507.058 µs) : 485, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (481.431 µs) : 460, 503
.   : milestone, 481,
iast_INACTIVE (455.929 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (463.144 µs) : 442, 484
.   : milestone, 463,
tracing (448.138 µs) : 428, 468
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.963 µs [348.556 µs, 387.369 µs]	-
iast	482.975 µs [461.646 µs, 504.304 µs]	115.012 µs (31.3%)
iast_FULL	550.212 µs [529.07 µs, 571.354 µs]	182.249 µs (49.5%)
iast_GLOBAL	500.725 µs [479.695 µs, 521.755 µs]	132.763 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED	478.796 µs [457.91 µs, 499.681 µs]	110.833 µs (30.1%)
iast_INACTIVE	451.162 µs [429.806 µs, 472.518 µs]	83.199 µs (22.6%)
iast_TELEMETRY_OFF	465.807 µs [444.668 µs, 486.946 µs]	97.845 µs (26.6%)
tracing	443.203 µs [422.335 µs, 464.072 µs]	75.241 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.17 µs [347.744 µs, 386.595 µs]	-
iast	482.594 µs [460.742 µs, 504.446 µs]	115.424 µs (31.4%)
iast_FULL	547.921 µs [526.75 µs, 569.092 µs]	180.751 µs (49.2%)
iast_GLOBAL	507.058 µs [485.431 µs, 528.685 µs]	139.888 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED	481.431 µs [459.971 µs, 502.89 µs]	114.261 µs (31.1%)
iast_INACTIVE	455.929 µs [434.727 µs, 477.131 µs]	88.759 µs (24.2%)
iast_TELEMETRY_OFF	463.144 µs [442.298 µs, 483.991 µs]	95.975 µs (26.1%)
tracing	448.138 µs [427.923 µs, 468.353 µs]	80.968 µs (22.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.703 ms) : 1679, 1728
.   : milestone, 1703,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.471 ms) : 1448, 1494
.   : milestone, 1471,
profiling (1.458 ms) : 1434, 1483
.   : milestone, 1458,
tracing (1.476 ms) : 1452, 1499
.   : milestone, 1476,
section candidate
no_agent (1.334 ms) : 1315, 1354
.   : milestone, 1334,
appsec (1.717 ms) : 1693, 1741
.   : milestone, 1717,
appsec_no_iast (1.722 ms) : 1697, 1746
.   : milestone, 1722,
iast (1.487 ms) : 1463, 1511
.   : milestone, 1487,
profiling (1.484 ms) : 1459, 1509
.   : milestone, 1484,
tracing (1.472 ms) : 1448, 1496
.   : milestone, 1472,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.374 ms]	-
appsec	1.703 ms [1.679 ms, 1.728 ms]	348.663 µs (25.7%)
appsec_no_iast	1.716 ms [1.692 ms, 1.74 ms]	361.804 µs (26.7%)
iast	1.471 ms [1.448 ms, 1.494 ms]	116.497 µs (8.6%)
profiling	1.458 ms [1.434 ms, 1.483 ms]	103.911 µs (7.7%)
tracing	1.476 ms [1.452 ms, 1.499 ms]	121.07 µs (8.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.334 ms [1.315 ms, 1.354 ms]	-
appsec	1.717 ms [1.693 ms, 1.741 ms]	382.641 µs (28.7%)
appsec_no_iast	1.722 ms [1.697 ms, 1.746 ms]	387.204 µs (29.0%)
iast	1.487 ms [1.463 ms, 1.511 ms]	152.873 µs (11.5%)
profiling	1.484 ms [1.459 ms, 1.509 ms]	150.081 µs (11.2%)
tracing	1.472 ms [1.448 ms, 1.496 ms]	137.576 µs (10.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/tibco
git_commit_date	1719927125	1719930940
git_commit_sha	`2c9c668`	`92b2ee8`
release_version	1.37.0-SNAPSHOT~2c9c668c74	1.37.0-SNAPSHOT~92b2ee80e5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1719934238	1719934238
ci_job_id	559813774	559813774
ci_pipeline_id	38140931	38140931
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
appsec (15.278 s) : 15278000, 15278000
.   : milestone, 15278000,
iast (18.724 s) : 18724000, 18724000
.   : milestone, 18724000,
iast_GLOBAL (17.764 s) : 17764000, 17764000
.   : milestone, 17764000,
profiling (15.81 s) : 15810000, 15810000
.   : milestone, 15810000,
tracing (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
section candidate
no_agent (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
appsec (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
iast (18.497 s) : 18497000, 18497000
.   : milestone, 18497000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
.   : milestone, 17820000,
profiling (15.24 s) : 15240000, 15240000
.   : milestone, 15240000,
tracing (14.858 s) : 14858000, 14858000
.   : milestone, 14858000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.919 s [14.919 s, 14.919 s]	-
appsec	15.278 s [15.278 s, 15.278 s]	359.0 ms (2.4%)
iast	18.724 s [18.724 s, 18.724 s]	3.805 s (25.5%)
iast_GLOBAL	17.764 s [17.764 s, 17.764 s]	2.845 s (19.1%)
profiling	15.81 s [15.81 s, 15.81 s]	891.0 ms (6.0%)
tracing	15.137 s [15.137 s, 15.137 s]	218.0 ms (1.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.416 s [15.416 s, 15.416 s]	-
appsec	15.176 s [15.176 s, 15.176 s]	-240.0 ms (-1.6%)
iast	18.497 s [18.497 s, 18.497 s]	3.081 s (20.0%)
iast_GLOBAL	17.82 s [17.82 s, 17.82 s]	2.404 s (15.6%)
profiling	15.24 s [15.24 s, 15.24 s]	-176.0 ms (-1.1%)
tracing	14.858 s [14.858 s, 14.858 s]	-558.0 ms (-3.6%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~92b2ee80e5, baseline=1.37.0-SNAPSHOT~2c9c668c74
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.223 ms) : 2187, 2259
.   : milestone, 2223,
iast (1.977 ms) : 1934, 2019
.   : milestone, 1977,
iast_GLOBAL (2.025 ms) : 1982, 2069
.   : milestone, 2025,
profiling (1.857 ms) : 1823, 1892
.   : milestone, 1857,
tracing (1.843 ms) : 1809, 1877
.   : milestone, 1843,
section candidate
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.224 ms) : 2188, 2260
.   : milestone, 2224,
iast (1.98 ms) : 1937, 2023
.   : milestone, 1980,
iast_GLOBAL (2.029 ms) : 1984, 2074
.   : milestone, 2029,
profiling (1.866 ms) : 1831, 1901
.   : milestone, 1866,
tracing (1.843 ms) : 1809, 1877
.   : milestone, 1843,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.458 ms [1.447 ms, 1.47 ms]	-
appsec	2.223 ms [2.187 ms, 2.259 ms]	764.705 µs (52.4%)
iast	1.977 ms [1.934 ms, 2.019 ms]	518.425 µs (35.6%)
iast_GLOBAL	2.025 ms [1.982 ms, 2.069 ms]	567.078 µs (38.9%)
profiling	1.857 ms [1.823 ms, 1.892 ms]	399.049 µs (27.4%)
tracing	1.843 ms [1.809 ms, 1.877 ms]	384.751 µs (26.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.459 ms [1.448 ms, 1.47 ms]	-
appsec	2.224 ms [2.188 ms, 2.26 ms]	764.809 µs (52.4%)
iast	1.98 ms [1.937 ms, 2.023 ms]	521.045 µs (35.7%)
iast_GLOBAL	2.029 ms [1.984 ms, 2.074 ms]	569.934 µs (39.1%)
profiling	1.866 ms [1.831 ms, 1.901 ms]	406.905 µs (27.9%)
tracing	1.843 ms [1.809 ms, 1.877 ms]	383.996 µs (26.3%)

PerfectSlayer

Few comments. I mostly wonder if we can avoid gradle graph task manipulation and use dedicated modules instead for stubs.

I review from IDM team is welcome too 🤝

.gitlab-ci.yml

dd-java-agent/instrumentation/tibcobw_5/build.gradle

PerfectSlayer · 2024-07-01T09:05:54Z

...mentation/tibcobw_5/src/main/java/datadog/trace/instrumentation/tibcobw5/TibcoDecorator.java

+      return null;
+    }
+    // it's something like version 15.0, build xx, some date
+    Pattern pattern = Pattern.compile("\\D*(\\d[^,]*).*");


Is the leading .* useful?

If I remove it the matcher won't match.

...mentation/tibcobw_5/src/main/java/datadog/trace/instrumentation/tibcobw5/TibcoDecorator.java

dd-java-agent/instrumentation/tibcobw_6/build.gradle

ygree

Looks good to me

nayeem-kamal

LGTM

amarziali added tag: do not merge Do not merge changes inst: others All other instrumentations labels Jun 11, 2024

amarziali force-pushed the andrea.marziali/tibco branch from 1077df4 to 3493667 Compare June 11, 2024 07:56

amarziali force-pushed the andrea.marziali/tibco branch 3 times, most recently from ac75a2b to f3e50b9 Compare June 14, 2024 14:22

amarziali force-pushed the andrea.marziali/tibco branch 3 times, most recently from f953027 to cbf9529 Compare June 25, 2024 12:36

amarziali marked this pull request as ready for review June 28, 2024 09:13

amarziali requested review from a team as code owners June 28, 2024 09:13

amarziali requested review from PerfectSlayer and nayeem-kamal June 28, 2024 09:13

amarziali removed the tag: do not merge Do not merge changes label Jun 28, 2024

PerfectSlayer reviewed Jul 1, 2024

View reviewed changes

amarziali force-pushed the andrea.marziali/tibco branch from 526fc4c to 1736487 Compare July 1, 2024 14:44

amarziali requested a review from PerfectSlayer July 1, 2024 14:46

ygree approved these changes Jul 1, 2024

View reviewed changes

nayeem-kamal approved these changes Jul 1, 2024

View reviewed changes

amarziali force-pushed the andrea.marziali/tibco branch from 98e0bb2 to 92b2ee8 Compare July 2, 2024 14:35

amarziali added the tag: experimental Experimental changes label Jul 2, 2024

amarziali added 7 commits July 2, 2024 17:15

Instrument Tibco BusinessWorks 5 and 6

c13358a

turn off spotbugs of a method

71fb942

add tibco tests to gitlab-ci

9387a19

Review - move stubs to a separate module

4b4fdfb

relax logging

15e1c2c

fix contextstore access

d70f30a

stick to project naming compliance

8913168

amarziali force-pushed the andrea.marziali/tibco branch from 92b2ee8 to 8913168 Compare July 2, 2024 15:16

amarziali enabled auto-merge (squash) July 2, 2024 15:52

amarziali merged commit 2dae4b0 into master Jul 2, 2024
78 of 81 checks passed

amarziali deleted the andrea.marziali/tibco branch July 2, 2024 15:57

github-actions bot added this to the 1.37.0 milestone Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instrument Tibco BusinessWorks 5 and 6 #7155

Instrument Tibco BusinessWorks 5 and 6 #7155

amarziali commented Jun 11, 2024 •

edited

Loading

pr-commenter bot commented Jun 11, 2024 •

edited

Loading

PerfectSlayer left a comment

PerfectSlayer Jul 1, 2024

amarziali Jul 1, 2024

ygree left a comment

nayeem-kamal left a comment

Instrument Tibco BusinessWorks 5 and 6 #7155

Instrument Tibco BusinessWorks 5 and 6 #7155

Conversation

amarziali commented Jun 11, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Jun 11, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

PerfectSlayer left a comment

Choose a reason for hiding this comment

PerfectSlayer Jul 1, 2024

Choose a reason for hiding this comment

amarziali Jul 1, 2024

Choose a reason for hiding this comment

ygree left a comment

Choose a reason for hiding this comment

nayeem-kamal left a comment

Choose a reason for hiding this comment

amarziali commented Jun 11, 2024 •

edited

Loading

pr-commenter bot commented Jun 11, 2024 •

edited

Loading