Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Datadog appender when doing agentless log submission for Log4j2 #7160

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Start Datadog appender when doing agentless log submission for Log4j2 #7160

merged 1 commit into from
Jun 11, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 11, 2024 •
edited by jira bot
Loading

What Does This Do

Fixes agentless log submission for Log4j2: some Log4j versions require appenders to be started explicitly before they can be used. Otherwise log messages forwarded to an appender that is not started are ignored.

Also adds a check that prevents multiple Datadog appenders from being added to the same logging config.

Jira ticket: CIVIS-10104

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/agentless-log-submission-fix
git_commit_date 1718106998 1718107198
git_commit_sha 3648b65 b4f51c5
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~b4f51c50f2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718110396 1718110396
ci_job_id 539049377 539049377
ci_pipeline_id 36385457 36385457
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065432
Total [baseline] (8.581 s) : 0, 8580821
Agent [candidate] (1.066 s) : 0, 1065662
Total [candidate] (8.571 s) : 0, 8570520
section iast
Agent [baseline] (1.179 s) : 0, 1179373
Total [baseline] (9.063 s) : 0, 9062774
Agent [candidate] (1.177 s) : 0, 1177479
Total [candidate] (9.024 s) : 0, 9023918
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177424
Total [baseline] (9.006 s) : 0, 9006300
Agent [candidate] (1.177 s) : 0, 1176854
Total [candidate] (8.99 s) : 0, 8990241
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1163828
Total [baseline] (9.002 s) : 0, 9001853
Agent [candidate] (1.167 s) : 0, 1166576
Total [candidate] (8.988 s) : 0, 8987780
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.179 s 113.941 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 111.992 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.164 s 98.396 ms (9.2%)
Total tracing 8.581 s -
Total iast 9.063 s 481.953 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.006 s 425.479 ms (5.0%)
Total iast_TELEMETRY_OFF 9.002 s 421.032 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.177 s 111.817 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 111.191 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.167 s 100.914 ms (9.5%)
Total tracing 8.571 s -
Total iast 9.024 s 453.398 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.99 s 419.721 ms (4.9%)
Total iast_TELEMETRY_OFF 8.988 s 417.259 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.286 ms) : 0, 665286
BytebuddyAgent [candidate] (666.939 ms) : 0, 666939
GlobalTracer [baseline] (306.599 ms) : 0, 306599
GlobalTracer [candidate] (305.251 ms) : 0, 305251
AppSec [baseline] (50.45 ms) : 0, 50450
AppSec [candidate] (50.117 ms) : 0, 50117
Logs Intake [baseline] (409.119 µs) : 0, 409
Logs Intake [candidate] (424.344 µs) : 0, 424
Remote Config [baseline] (680.588 µs) : 0, 681
Remote Config [candidate] (660.803 µs) : 0, 661
Telemetry [baseline] (7.636 ms) : 0, 7636
Telemetry [candidate] (7.589 ms) : 0, 7589
section iast
BytebuddyAgent [baseline] (786.737 ms) : 0, 786737
BytebuddyAgent [candidate] (784.165 ms) : 0, 784165
GlobalTracer [baseline] (296.644 ms) : 0, 296644
GlobalTracer [candidate] (295.611 ms) : 0, 295611
AppSec [baseline] (47.246 ms) : 0, 47246
AppSec [candidate] (47.581 ms) : 0, 47581
Logs Intake [baseline] (306.623 µs) : 0, 307
Logs Intake [candidate] (304.12 µs) : 0, 304
Remote Config [baseline] (590.287 µs) : 0, 590
Remote Config [candidate] (582.826 µs) : 0, 583
Telemetry [baseline] (7.81 ms) : 0, 7810
Telemetry [candidate] (10.207 ms) : 0, 10207
IAST [baseline] (26.64 ms) : 0, 26640
IAST [candidate] (25.673 ms) : 0, 25673
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.281 ms) : 0, 785281
BytebuddyAgent [candidate] (784.454 ms) : 0, 784454
GlobalTracer [baseline] (296.501 ms) : 0, 296501
GlobalTracer [candidate] (296.028 ms) : 0, 296028
AppSec [baseline] (46.632 ms) : 0, 46632
AppSec [candidate] (47.056 ms) : 0, 47056
Logs Intake [baseline] (296.161 µs) : 0, 296
Logs Intake [candidate] (302.835 µs) : 0, 303
Remote Config [baseline] (577.979 µs) : 0, 578
Remote Config [candidate] (578.171 µs) : 0, 578
Telemetry [baseline] (8.408 ms) : 0, 8408
Telemetry [candidate] (8.501 ms) : 0, 8501
IAST [baseline] (26.282 ms) : 0, 26282
IAST [candidate] (26.507 ms) : 0, 26507
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.642 ms) : 0, 775642
BytebuddyAgent [candidate] (777.915 ms) : 0, 777915
GlobalTracer [baseline] (293.847 ms) : 0, 293847
GlobalTracer [candidate] (294.75 ms) : 0, 294750
AppSec [baseline] (48.477 ms) : 0, 48477
AppSec [candidate] (48.033 ms) : 0, 48033
Logs Intake [baseline] (294.877 µs) : 0, 295
Logs Intake [candidate] (300.235 µs) : 0, 300
Remote Config [baseline] (560.538 µs) : 0, 561
Remote Config [candidate] (565.25 µs) : 0, 565
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.553 ms) : 0, 7553
IAST [baseline] (24.156 ms) : 0, 24156
IAST [candidate] (24.08 ms) : 0, 24080
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062604
Total [baseline] (10.363 s) : 0, 10363190
Agent [candidate] (1.065 s) : 0, 1064688
Total [candidate] (10.43 s) : 0, 10430071
section appsec
Agent [baseline] (1.18 s) : 0, 1180080
Total [baseline] (10.48 s) : 0, 10480076
Agent [candidate] (1.184 s) : 0, 1184190
Total [candidate] (10.493 s) : 0, 10492957
section iast
Agent [baseline] (1.168 s) : 0, 1167555
Total [baseline] (10.731 s) : 0, 10731267
Agent [candidate] (1.17 s) : 0, 1169773
Total [candidate] (10.686 s) : 0, 10685826
section profiling
Agent [baseline] (1.262 s) : 0, 1261947
Total [baseline] (10.618 s) : 0, 10618262
Agent [candidate] (1.272 s) : 0, 1272004
Total [candidate] (10.73 s) : 0, 10729689
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.18 s 117.476 ms (11.1%)
Agent iast 1.168 s 104.951 ms (9.9%)
Agent profiling 1.262 s 199.343 ms (18.8%)
Total tracing 10.363 s -
Total appsec 10.48 s 116.886 ms (1.1%)
Total iast 10.731 s 368.077 ms (3.6%)
Total profiling 10.618 s 255.072 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.184 s 119.502 ms (11.2%)
Agent iast 1.17 s 105.085 ms (9.9%)
Agent profiling 1.272 s 207.316 ms (19.5%)
Total tracing 10.43 s -
Total appsec 10.493 s 62.886 ms (0.6%)
Total iast 10.686 s 255.755 ms (2.5%)
Total profiling 10.73 s 299.618 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.192 ms) : 0, 665192
BytebuddyAgent [candidate] (666.053 ms) : 0, 666053
GlobalTracer [baseline] (304.138 ms) : 0, 304138
GlobalTracer [candidate] (305.219 ms) : 0, 305219
AppSec [baseline] (50.211 ms) : 0, 50211
AppSec [candidate] (50.341 ms) : 0, 50341
Logs Intake [baseline] (392.754 µs) : 0, 393
Logs Intake [candidate] (419.272 µs) : 0, 419
Remote Config [baseline] (678.284 µs) : 0, 678
Remote Config [candidate] (664.653 µs) : 0, 665
Telemetry [baseline] (7.606 ms) : 0, 7606
Telemetry [candidate] (7.557 ms) : 0, 7557
section appsec
BytebuddyAgent [baseline] (675.597 ms) : 0, 675597
BytebuddyAgent [candidate] (678.141 ms) : 0, 678141
GlobalTracer [baseline] (297.304 ms) : 0, 297304
GlobalTracer [candidate] (298.357 ms) : 0, 298357
AppSec [baseline] (152.467 ms) : 0, 152467
AppSec [candidate] (153.48 ms) : 0, 153480
Logs Intake [baseline] (323.014 µs) : 0, 323
Logs Intake [candidate] (334.397 µs) : 0, 334
Remote Config [baseline] (645.837 µs) : 0, 646
Remote Config [candidate] (643.369 µs) : 0, 643
Telemetry [baseline] (8.819 ms) : 0, 8819
Telemetry [candidate] (7.848 ms) : 0, 7848
IAST [baseline] (21.081 ms) : 0, 21081
IAST [candidate] (21.766 ms) : 0, 21766
section iast
BytebuddyAgent [baseline] (778.02 ms) : 0, 778020
BytebuddyAgent [candidate] (779.663 ms) : 0, 779663
GlobalTracer [baseline] (293.49 ms) : 0, 293490
GlobalTracer [candidate] (293.862 ms) : 0, 293862
AppSec [baseline] (47.034 ms) : 0, 47034
AppSec [candidate] (47.167 ms) : 0, 47167
Logs Intake [baseline] (302.068 µs) : 0, 302
Logs Intake [candidate] (299.346 µs) : 0, 299
Remote Config [baseline] (582.664 µs) : 0, 583
Remote Config [candidate] (577.312 µs) : 0, 577
Telemetry [baseline] (9.124 ms) : 0, 9124
Telemetry [candidate] (6.896 ms) : 0, 6896
IAST [baseline] (25.697 ms) : 0, 25697
IAST [candidate] (28.004 ms) : 0, 28004
section profiling
BytebuddyAgent [baseline] (663.459 ms) : 0, 663459
BytebuddyAgent [candidate] (669.306 ms) : 0, 669306
GlobalTracer [baseline] (386.933 ms) : 0, 386933
GlobalTracer [candidate] (388.862 ms) : 0, 388862
AppSec [baseline] (50.908 ms) : 0, 50908
AppSec [candidate] (51.345 ms) : 0, 51345
Logs Intake [baseline] (333.384 µs) : 0, 333
Logs Intake [candidate] (334.226 µs) : 0, 334
Remote Config [baseline] (740.39 µs) : 0, 740
Remote Config [candidate] (750.522 µs) : 0, 751
Telemetry [baseline] (7.345 ms) : 0, 7345
Telemetry [candidate] (7.441 ms) : 0, 7441
ProfilingAgent [baseline] (95.526 ms) : 0, 95526
ProfilingAgent [candidate] (96.696 ms) : 0, 96696
Profiling [baseline] (95.55 ms) : 0, 95550
Profiling [candidate] (96.72 ms) : 0, 96720
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-11T12:24:01 2024-06-11T12:30:50
git_branch master nikita-tkachenko/agentless-log-submission-fix
git_commit_date 1718106998 1718107198
git_commit_sha 3648b65 b4f51c5
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~b4f51c50f2
start_time 2024-06-11T12:23:47 2024-06-11T12:30:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718109395 1718109395
ci_job_id 539049379 539049379
ci_pipeline_id 36385457 36385457
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.812 µs) : 352, 392
.   : milestone, 372,
iast (480.889 µs) : 459, 502
.   : milestone, 481,
iast_FULL (555.562 µs) : 534, 577
.   : milestone, 556,
iast_GLOBAL (507.108 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.438 µs) : 456, 497
.   : milestone, 476,
iast_INACTIVE (455.929 µs) : 434, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (476.338 µs) : 455, 498
.   : milestone, 476,
tracing (442.854 µs) : 423, 463
.   : milestone, 443,
section candidate
no_agent (375.125 µs) : 356, 395
.   : milestone, 375,
iast (481.87 µs) : 461, 503
.   : milestone, 482,
iast_FULL (547.358 µs) : 526, 569
.   : milestone, 547,
iast_GLOBAL (506.099 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (481.534 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (452.493 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (472.526 µs) : 451, 494
.   : milestone, 473,
tracing (448.438 µs) : 427, 470
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.812 µs [352.016 µs, 391.608 µs] -
iast 480.889 µs [459.458 µs, 502.319 µs] 109.077 µs (29.3%)
iast_FULL 555.562 µs [534.183 µs, 576.941 µs] 183.75 µs (49.4%)
iast_GLOBAL 507.108 µs [485.972 µs, 528.243 µs] 135.296 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 476.438 µs [455.71 µs, 497.165 µs] 104.626 µs (28.1%)
iast_INACTIVE 455.929 µs [434.368 µs, 477.489 µs] 84.117 µs (22.6%)
iast_TELEMETRY_OFF 476.338 µs [454.791 µs, 497.885 µs] 104.526 µs (28.1%)
tracing 442.854 µs [422.584 µs, 463.123 µs] 71.042 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.125 µs [355.605 µs, 394.645 µs] -
iast 481.87 µs [460.759 µs, 502.982 µs] 106.745 µs (28.5%)
iast_FULL 547.358 µs [526.058 µs, 568.657 µs] 172.232 µs (45.9%)
iast_GLOBAL 506.099 µs [484.759 µs, 527.44 µs] 130.974 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 481.534 µs [460.346 µs, 502.722 µs] 106.409 µs (28.4%)
iast_INACTIVE 452.493 µs [431.044 µs, 473.941 µs] 77.368 µs (20.6%)
iast_TELEMETRY_OFF 472.526 µs [451.419 µs, 493.633 µs] 97.401 µs (26.0%)
tracing 448.438 µs [426.887 µs, 469.99 µs] 73.313 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1314, 1354
.   : milestone, 1334,
appsec (1.712 ms) : 1688, 1737
.   : milestone, 1712,
appsec_no_iast (1.73 ms) : 1706, 1755
.   : milestone, 1730,
iast (1.473 ms) : 1449, 1497
.   : milestone, 1473,
profiling (1.491 ms) : 1466, 1516
.   : milestone, 1491,
tracing (1.483 ms) : 1459, 1507
.   : milestone, 1483,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.706 ms) : 1682, 1731
.   : milestone, 1706,
appsec_no_iast (1.729 ms) : 1705, 1754
.   : milestone, 1729,
iast (1.476 ms) : 1454, 1499
.   : milestone, 1476,
profiling (1.527 ms) : 1501, 1553
.   : milestone, 1527,
tracing (1.471 ms) : 1448, 1494
.   : milestone, 1471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.314 ms, 1.354 ms] -
appsec 1.712 ms [1.688 ms, 1.737 ms] 378.463 µs (28.4%)
appsec_no_iast 1.73 ms [1.706 ms, 1.755 ms] 396.618 µs (29.7%)
iast 1.473 ms [1.449 ms, 1.497 ms] 139.65 µs (10.5%)
profiling 1.491 ms [1.466 ms, 1.516 ms] 157.637 µs (11.8%)
tracing 1.483 ms [1.459 ms, 1.507 ms] 149.117 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.706 ms [1.682 ms, 1.731 ms] 362.932 µs (27.0%)
appsec_no_iast 1.729 ms [1.705 ms, 1.754 ms] 386.034 µs (28.7%)
iast 1.476 ms [1.454 ms, 1.499 ms] 132.732 µs (9.9%)
profiling 1.527 ms [1.501 ms, 1.553 ms] 183.502 µs (13.7%)
tracing 1.471 ms [1.448 ms, 1.494 ms] 127.413 µs (9.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/agentless-log-submission-fix
git_commit_date 1718106998 1718107198
git_commit_sha 3648b65 b4f51c5
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~b4f51c50f2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718109912 1718109912
ci_job_id 539049381 539049381
ci_pipeline_id 36385457 36385457
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.215 ms) : 2181, 2250
.   : milestone, 2215,
iast (1.979 ms) : 1938, 2020
.   : milestone, 1979,
iast_GLOBAL (2.015 ms) : 1973, 2057
.   : milestone, 2015,
profiling (1.858 ms) : 1824, 1892
.   : milestone, 1858,
tracing (1.835 ms) : 1803, 1868
.   : milestone, 1835,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.214 ms) : 2179, 2249
.   : milestone, 2214,
iast (1.967 ms) : 1925, 2008
.   : milestone, 1967,
iast_GLOBAL (2.011 ms) : 1970, 2052
.   : milestone, 2011,
profiling (1.855 ms) : 1822, 1888
.   : milestone, 1855,
tracing (1.836 ms) : 1804, 1868
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.215 ms [2.181 ms, 2.25 ms] 754.851 µs (51.7%)
iast 1.979 ms [1.938 ms, 2.02 ms] 518.599 µs (35.5%)
iast_GLOBAL 2.015 ms [1.973 ms, 2.057 ms] 554.119 µs (37.9%)
profiling 1.858 ms [1.824 ms, 1.892 ms] 397.833 µs (27.2%)
tracing 1.835 ms [1.803 ms, 1.868 ms] 374.765 µs (25.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.214 ms [2.179 ms, 2.249 ms] 743.164 µs (50.5%)
iast 1.967 ms [1.925 ms, 2.008 ms] 495.608 µs (33.7%)
iast_GLOBAL 2.011 ms [1.97 ms, 2.052 ms] 539.859 µs (36.7%)
profiling 1.855 ms [1.822 ms, 1.888 ms] 384.233 µs (26.1%)
tracing 1.836 ms [1.804 ms, 1.868 ms] 365.472 µs (24.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b4f51c50f2, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
appsec (14.915 s) : 14915000, 14915000
.   : milestone, 14915000,
iast (18.824 s) : 18824000, 18824000
.   : milestone, 18824000,
iast_GLOBAL (17.971 s) : 17971000, 17971000
.   : milestone, 17971000,
profiling (15.294 s) : 15294000, 15294000
.   : milestone, 15294000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
section candidate
no_agent (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
appsec (15.506 s) : 15506000, 15506000
.   : milestone, 15506000,
iast (18.657 s) : 18657000, 18657000
.   : milestone, 18657000,
iast_GLOBAL (17.713 s) : 17713000, 17713000
.   : milestone, 17713000,
profiling (15.394 s) : 15394000, 15394000
.   : milestone, 15394000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.056 s [15.056 s, 15.056 s] -
appsec 14.915 s [14.915 s, 14.915 s] -141.0 ms (-0.9%)
iast 18.824 s [18.824 s, 18.824 s] 3.768 s (25.0%)
iast_GLOBAL 17.971 s [17.971 s, 17.971 s] 2.915 s (19.4%)
profiling 15.294 s [15.294 s, 15.294 s] 238.0 ms (1.6%)
tracing 15.125 s [15.125 s, 15.125 s] 69.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.001 s [15.001 s, 15.001 s] -
appsec 15.506 s [15.506 s, 15.506 s] 505.0 ms (3.4%)
iast 18.657 s [18.657 s, 18.657 s] 3.656 s (24.4%)
iast_GLOBAL 17.713 s [17.713 s, 17.713 s] 2.712 s (18.1%)
profiling 15.394 s [15.394 s, 15.394 s] 393.0 ms (2.6%)
tracing 15.037 s [15.037 s, 15.037 s] 36.0 ms (0.2%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 11, 2024 14:17
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 11, 2024 14:17
amarziali
amarziali approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@amarziali amarziali added comp: logging Tracer internal logging labels Jun 11, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 54461ee into master Jun 11, 2024
83 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/agentless-log-submission-fix branch June 11, 2024 15:09
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: logging Tracer internal logging type: bug
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikita-tkachenko-datadog @amarziali