Removed scala converter lambdas and ensure they are added as helpers #7168

manuel-alvarez-alvarez · 2024-06-12T08:45:23Z

What Does This Do

Backports fix1 and fix2 the release branch. It fixes an issue with Scala and IAST

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-06-12T09:38:01Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-fix-scala-helper-backport
git_commit_date	1718202127	1718202217
git_commit_sha	`8085070`	`59387b8`
release_version	1.36.0-SNAPSHOT~80850709c7	1.36.0-SNAPSHOT~59387b892c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718205751	1718205751
ci_job_id	540848933	540848933
ci_pipeline_id	36525743	36525743
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061782
Total [baseline] (8.546 s) : 0, 8545965
Agent [candidate] (1.067 s) : 0, 1067276
Total [candidate] (8.544 s) : 0, 8543871
section iast
Agent [baseline] (1.178 s) : 0, 1178069
Total [baseline] (9.0 s) : 0, 9000080
Agent [candidate] (1.179 s) : 0, 1178791
Total [candidate] (9.027 s) : 0, 9026566
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1168476
Total [baseline] (8.968 s) : 0, 8968110
Agent [candidate] (1.181 s) : 0, 1181027
Total [candidate] (9.027 s) : 0, 9027230
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176530
Total [baseline] (8.993 s) : 0, 8992544
Agent [candidate] (1.179 s) : 0, 1179099
Total [candidate] (9.02 s) : 0, 9020413

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.178 s	116.286 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.168 s	106.693 ms (10.0%)
Agent	iast_TELEMETRY_OFF	1.177 s	114.748 ms (10.8%)
Total	tracing	8.546 s	-
Total	iast	9.0 s	454.114 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.968 s	422.145 ms (4.9%)
Total	iast_TELEMETRY_OFF	8.993 s	446.579 ms (5.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	iast	1.179 s	111.515 ms (10.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.181 s	113.75 ms (10.7%)
Agent	iast_TELEMETRY_OFF	1.179 s	111.822 ms (10.5%)
Total	tracing	8.544 s	-
Total	iast	9.027 s	482.695 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.027 s	483.359 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.02 s	476.542 ms (5.6%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.679 ms) : 0, 664679
BytebuddyAgent [candidate] (668.456 ms) : 0, 668456
GlobalTracer [baseline] (303.857 ms) : 0, 303857
GlobalTracer [candidate] (305.183 ms) : 0, 305183
AppSec [baseline] (50.191 ms) : 0, 50191
AppSec [candidate] (50.371 ms) : 0, 50371
Logs Intake [baseline] (410.759 µs) : 0, 411
Logs Intake [candidate] (411.147 µs) : 0, 411
Remote Config [baseline] (665.327 µs) : 0, 665
Remote Config [candidate] (660.826 µs) : 0, 661
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.599 ms) : 0, 7599
section iast
BytebuddyAgent [baseline] (785.703 ms) : 0, 785703
BytebuddyAgent [candidate] (785.443 ms) : 0, 785443
GlobalTracer [baseline] (295.408 ms) : 0, 295408
GlobalTracer [candidate] (295.726 ms) : 0, 295726
AppSec [baseline] (47.046 ms) : 0, 47046
AppSec [candidate] (47.106 ms) : 0, 47106
Logs Intake [baseline] (301.529 µs) : 0, 302
Logs Intake [candidate] (303.385 µs) : 0, 303
Remote Config [baseline] (575.943 µs) : 0, 576
Remote Config [candidate] (590.786 µs) : 0, 591
Telemetry [baseline] (8.402 ms) : 0, 8402
Telemetry [candidate] (9.353 ms) : 0, 9353
IAST [baseline] (27.192 ms) : 0, 27192
IAST [candidate] (26.832 ms) : 0, 26832
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.496 ms) : 0, 779496
BytebuddyAgent [candidate] (786.899 ms) : 0, 786899
GlobalTracer [baseline] (294.284 ms) : 0, 294284
GlobalTracer [candidate] (297.723 ms) : 0, 297723
AppSec [baseline] (46.481 ms) : 0, 46481
AppSec [candidate] (47.308 ms) : 0, 47308
Logs Intake [baseline] (298.971 µs) : 0, 299
Logs Intake [candidate] (308.753 µs) : 0, 309
Remote Config [baseline] (589.678 µs) : 0, 590
Remote Config [candidate] (592.008 µs) : 0, 592
Telemetry [baseline] (10.776 ms) : 0, 10776
Telemetry [candidate] (7.827 ms) : 0, 7827
IAST [baseline] (23.156 ms) : 0, 23156
IAST [candidate] (26.892 ms) : 0, 26892
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (783.937 ms) : 0, 783937
BytebuddyAgent [candidate] (784.872 ms) : 0, 784872
GlobalTracer [baseline] (296.071 ms) : 0, 296071
GlobalTracer [candidate] (297.742 ms) : 0, 297742
AppSec [baseline] (46.894 ms) : 0, 46894
AppSec [candidate] (48.46 ms) : 0, 48460
Logs Intake [baseline] (303.893 µs) : 0, 304
Logs Intake [candidate] (307.99 µs) : 0, 308
Remote Config [baseline] (573.918 µs) : 0, 574
Remote Config [candidate] (570.985 µs) : 0, 571
Telemetry [baseline] (8.288 ms) : 0, 8288
Telemetry [candidate] (7.631 ms) : 0, 7631
IAST [baseline] (26.969 ms) : 0, 26969
IAST [candidate] (26.014 ms) : 0, 26014

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066173
Total [baseline] (10.342 s) : 0, 10341618
Agent [candidate] (1.064 s) : 0, 1064149
Total [candidate] (10.449 s) : 0, 10448683
section appsec
Agent [baseline] (1.182 s) : 0, 1181661
Total [baseline] (10.526 s) : 0, 10526141
Agent [candidate] (1.179 s) : 0, 1179342
Total [candidate] (10.477 s) : 0, 10476838
section iast
Agent [baseline] (1.178 s) : 0, 1177512
Total [baseline] (10.74 s) : 0, 10740352
Agent [candidate] (1.167 s) : 0, 1167339
Total [candidate] (10.696 s) : 0, 10695810
section profiling
Agent [baseline] (1.262 s) : 0, 1262403
Total [baseline] (10.649 s) : 0, 10648829
Agent [candidate] (1.275 s) : 0, 1274559
Total [candidate] (10.647 s) : 0, 10646846

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	appsec	1.182 s	115.488 ms (10.8%)
Agent	iast	1.178 s	111.339 ms (10.4%)
Agent	profiling	1.262 s	196.23 ms (18.4%)
Total	tracing	10.342 s	-
Total	appsec	10.526 s	184.523 ms (1.8%)
Total	iast	10.74 s	398.734 ms (3.9%)
Total	profiling	10.649 s	307.212 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.179 s	115.193 ms (10.8%)
Agent	iast	1.167 s	103.19 ms (9.7%)
Agent	profiling	1.275 s	210.41 ms (19.8%)
Total	tracing	10.449 s	-
Total	appsec	10.477 s	28.154 ms (0.3%)
Total	iast	10.696 s	247.126 ms (2.4%)
Total	profiling	10.647 s	198.162 ms (1.9%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.614 ms) : 0, 666614
BytebuddyAgent [candidate] (666.098 ms) : 0, 666098
GlobalTracer [baseline] (305.893 ms) : 0, 305893
GlobalTracer [candidate] (304.309 ms) : 0, 304309
AppSec [baseline] (50.595 ms) : 0, 50595
AppSec [candidate] (50.5 ms) : 0, 50500
Logs Intake [baseline] (416.57 µs) : 0, 417
Logs Intake [candidate] (401.07 µs) : 0, 401
Remote Config [baseline] (669.26 µs) : 0, 669
Remote Config [candidate] (693.249 µs) : 0, 693
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.563 ms) : 0, 7563
section appsec
BytebuddyAgent [baseline] (676.036 ms) : 0, 676036
BytebuddyAgent [candidate] (674.42 ms) : 0, 674420
GlobalTracer [baseline] (297.454 ms) : 0, 297454
GlobalTracer [candidate] (297.082 ms) : 0, 297082
AppSec [baseline] (152.93 ms) : 0, 152930
AppSec [candidate] (152.717 ms) : 0, 152717
Logs Intake [baseline] (322.957 µs) : 0, 323
Logs Intake [candidate] (333.303 µs) : 0, 333
Remote Config [baseline] (660.952 µs) : 0, 661
Remote Config [candidate] (643.331 µs) : 0, 643
Telemetry [baseline] (8.448 ms) : 0, 8448
Telemetry [candidate] (8.55 ms) : 0, 8550
IAST [baseline] (22.837 ms) : 0, 22837
IAST [candidate] (22.309 ms) : 0, 22309
section iast
BytebuddyAgent [baseline] (785.773 ms) : 0, 785773
BytebuddyAgent [candidate] (778.724 ms) : 0, 778724
GlobalTracer [baseline] (295.968 ms) : 0, 295968
GlobalTracer [candidate] (293.482 ms) : 0, 293482
AppSec [baseline] (47.155 ms) : 0, 47155
AppSec [candidate] (47.075 ms) : 0, 47075
Logs Intake [baseline] (309.53 µs) : 0, 310
Logs Intake [candidate] (300.906 µs) : 0, 301
Remote Config [baseline] (555.916 µs) : 0, 556
Remote Config [candidate] (577.662 µs) : 0, 578
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (6.877 ms) : 0, 6877
IAST [baseline] (26.776 ms) : 0, 26776
IAST [candidate] (27.017 ms) : 0, 27017
section profiling
ProfilingAgent [baseline] (95.974 ms) : 0, 95974
ProfilingAgent [candidate] (96.763 ms) : 0, 96763
BytebuddyAgent [baseline] (663.896 ms) : 0, 663896
BytebuddyAgent [candidate] (672.217 ms) : 0, 672217
GlobalTracer [baseline] (386.595 ms) : 0, 386595
GlobalTracer [candidate] (388.588 ms) : 0, 388588
AppSec [baseline] (50.72 ms) : 0, 50720
AppSec [candidate] (51.097 ms) : 0, 51097
Logs Intake [baseline] (334.401 µs) : 0, 334
Logs Intake [candidate] (334.606 µs) : 0, 335
Remote Config [baseline] (751.559 µs) : 0, 752
Remote Config [candidate] (766.771 µs) : 0, 767
Telemetry [baseline] (7.322 ms) : 0, 7322
Telemetry [candidate] (7.424 ms) : 0, 7424
Profiling [baseline] (96.0 ms) : 0, 96000
Profiling [candidate] (96.787 ms) : 0, 96787

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-12T14:53:20	2024-06-12T15:00:12
git_branch	master	malvarez/iast-fix-scala-helper-backport
git_commit_date	1718202127	1718202217
git_commit_sha	`8085070`	`59387b8`
release_version	1.36.0-SNAPSHOT~80850709c7	1.36.0-SNAPSHOT~59387b892c
start_time	2024-06-12T14:53:06	2024-06-12T14:59:58

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718204757	1718204757
ci_job_id	540848934	540848934
ci_pipeline_id	36525743	36525743
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1364
.   : milestone, 1344,
appsec (1.764 ms) : 1741, 1788
.   : milestone, 1764,
appsec_no_iast (1.729 ms) : 1704, 1754
.   : milestone, 1729,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.532 ms) : 1506, 1557
.   : milestone, 1532,
tracing (1.481 ms) : 1455, 1506
.   : milestone, 1481,
section candidate
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.723 ms) : 1700, 1747
.   : milestone, 1723,
appsec_no_iast (1.693 ms) : 1668, 1718
.   : milestone, 1693,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.507 ms) : 1481, 1533
.   : milestone, 1507,
tracing (1.451 ms) : 1428, 1475
.   : milestone, 1451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.344 ms [1.324 ms, 1.364 ms]	-
appsec	1.764 ms [1.741 ms, 1.788 ms]	420.445 µs (31.3%)
appsec_no_iast	1.729 ms [1.704 ms, 1.754 ms]	384.934 µs (28.6%)
iast	1.476 ms [1.453 ms, 1.499 ms]	131.89 µs (9.8%)
profiling	1.532 ms [1.506 ms, 1.557 ms]	187.536 µs (14.0%)
tracing	1.481 ms [1.455 ms, 1.506 ms]	136.56 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.375 ms]	-
appsec	1.723 ms [1.7 ms, 1.747 ms]	367.886 µs (27.1%)
appsec_no_iast	1.693 ms [1.668 ms, 1.718 ms]	337.257 µs (24.9%)
iast	1.489 ms [1.466 ms, 1.512 ms]	133.313 µs (9.8%)
profiling	1.507 ms [1.481 ms, 1.533 ms]	151.835 µs (11.2%)
tracing	1.451 ms [1.428 ms, 1.475 ms]	95.857 µs (7.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.029 µs) : 351, 393
.   : milestone, 372,
iast (485.762 µs) : 465, 507
.   : milestone, 486,
iast_FULL (556.791 µs) : 536, 578
.   : milestone, 557,
iast_GLOBAL (510.525 µs) : 489, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (482.578 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (458.136 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (475.882 µs) : 454, 497
.   : milestone, 476,
tracing (451.165 µs) : 429, 473
.   : milestone, 451,
section candidate
no_agent (371.863 µs) : 352, 392
.   : milestone, 372,
iast (489.181 µs) : 468, 511
.   : milestone, 489,
iast_FULL (554.409 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (506.177 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (490.037 µs) : 469, 511
.   : milestone, 490,
iast_INACTIVE (456.616 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (476.935 µs) : 456, 498
.   : milestone, 477,
tracing (440.535 µs) : 420, 461
.   : milestone, 441,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.029 µs [351.4 µs, 392.658 µs]	-
iast	485.762 µs [464.56 µs, 506.964 µs]	113.732 µs (30.6%)
iast_FULL	556.791 µs [535.523 µs, 578.058 µs]	184.761 µs (49.7%)
iast_GLOBAL	510.525 µs [489.004 µs, 532.045 µs]	138.495 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED	482.578 µs [461.441 µs, 503.715 µs]	110.549 µs (29.7%)
iast_INACTIVE	458.136 µs [436.62 µs, 479.652 µs]	86.107 µs (23.1%)
iast_TELEMETRY_OFF	475.882 µs [454.42 µs, 497.343 µs]	103.852 µs (27.9%)
tracing	451.165 µs [429.261 µs, 473.069 µs]	79.136 µs (21.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.863 µs [351.668 µs, 392.059 µs]	-
iast	489.181 µs [467.732 µs, 510.631 µs]	117.318 µs (31.5%)
iast_FULL	554.409 µs [533.332 µs, 575.486 µs]	182.546 µs (49.1%)
iast_GLOBAL	506.177 µs [485.212 µs, 527.141 µs]	134.313 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED	490.037 µs [468.941 µs, 511.133 µs]	118.174 µs (31.8%)
iast_INACTIVE	456.616 µs [435.265 µs, 477.967 µs]	84.753 µs (22.8%)
iast_TELEMETRY_OFF	476.935 µs [455.864 µs, 498.006 µs]	105.071 µs (28.3%)
tracing	440.535 µs [420.148 µs, 460.922 µs]	68.672 µs (18.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-fix-scala-helper-backport
git_commit_date	1718202127	1718202217
git_commit_sha	`8085070`	`59387b8`
release_version	1.36.0-SNAPSHOT~80850709c7	1.36.0-SNAPSHOT~59387b892c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1718205881	1718205881
ci_job_id	540848935	540848935
ci_pipeline_id	36525743	36525743
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.577 s) : 20577000, 20577000
.   : milestone, 20577000,
appsec (20.662 s) : 20662000, 20662000
.   : milestone, 20662000,
iast (24.262 s) : 24262000, 24262000
.   : milestone, 24262000,
iast_GLOBAL (25.368 s) : 25368000, 25368000
.   : milestone, 25368000,
profiling (21.296 s) : 21296000, 21296000
.   : milestone, 21296000,
tracing (20.548 s) : 20548000, 20548000
.   : milestone, 20548000,
section candidate
no_agent (21.332 s) : 21332000, 21332000
.   : milestone, 21332000,
appsec (21.503 s) : 21503000, 21503000
.   : milestone, 21503000,
iast (24.245 s) : 24245000, 24245000
.   : milestone, 24245000,
iast_GLOBAL (25.375 s) : 25375000, 25375000
.   : milestone, 25375000,
profiling (21.054 s) : 21054000, 21054000
.   : milestone, 21054000,
tracing (21.042 s) : 21042000, 21042000
.   : milestone, 21042000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	20.577 s [20.577 s, 20.577 s]	-
appsec	20.662 s [20.662 s, 20.662 s]	85.0 ms (0.4%)
iast	24.262 s [24.262 s, 24.262 s]	3.685 s (17.9%)
iast_GLOBAL	25.368 s [25.368 s, 25.368 s]	4.791 s (23.3%)
profiling	21.296 s [21.296 s, 21.296 s]	719.0 ms (3.5%)
tracing	20.548 s [20.548 s, 20.548 s]	-29.0 ms (-0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	21.332 s [21.332 s, 21.332 s]	-
appsec	21.503 s [21.503 s, 21.503 s]	171.0 ms (0.8%)
iast	24.245 s [24.245 s, 24.245 s]	2.913 s (13.7%)
iast_GLOBAL	25.375 s [25.375 s, 25.375 s]	4.043 s (19.0%)
profiling	21.054 s [21.054 s, 21.054 s]	-278.0 ms (-1.3%)
tracing	21.042 s [21.042 s, 21.042 s]	-290.0 ms (-1.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~59387b892c, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.547 ms) : 1534, 1560
.   : milestone, 1547,
appsec (2.683 ms) : 2623, 2743
.   : milestone, 2683,
iast (2.348 ms) : 2278, 2418
.   : milestone, 2348,
iast_GLOBAL (2.404 ms) : 2332, 2475
.   : milestone, 2404,
profiling (2.207 ms) : 2145, 2268
.   : milestone, 2207,
tracing (2.164 ms) : 2107, 2221
.   : milestone, 2164,
section candidate
no_agent (1.544 ms) : 1531, 1556
.   : milestone, 1544,
appsec (2.69 ms) : 2630, 2751
.   : milestone, 2690,
iast (2.344 ms) : 2274, 2414
.   : milestone, 2344,
iast_GLOBAL (2.404 ms) : 2334, 2473
.   : milestone, 2404,
profiling (2.216 ms) : 2155, 2278
.   : milestone, 2216,
tracing (2.156 ms) : 2099, 2213
.   : milestone, 2156,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.547 ms [1.534 ms, 1.56 ms]	-
appsec	2.683 ms [2.623 ms, 2.743 ms]	1.136 ms (73.4%)
iast	2.348 ms [2.278 ms, 2.418 ms]	800.777 µs (51.8%)
iast_GLOBAL	2.404 ms [2.332 ms, 2.475 ms]	856.426 µs (55.4%)
profiling	2.207 ms [2.145 ms, 2.268 ms]	659.588 µs (42.6%)
tracing	2.164 ms [2.107 ms, 2.221 ms]	616.699 µs (39.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.544 ms [1.531 ms, 1.556 ms]	-
appsec	2.69 ms [2.63 ms, 2.751 ms]	1.146 ms (74.3%)
iast	2.344 ms [2.274 ms, 2.414 ms]	799.88 µs (51.8%)
iast_GLOBAL	2.404 ms [2.334 ms, 2.473 ms]	859.611 µs (55.7%)
profiling	2.216 ms [2.155 ms, 2.278 ms]	672.441 µs (43.6%)
tracing	2.156 ms [2.099 ms, 2.213 ms]	612.357 µs (39.7%)

…7146) Removed scala converter lambdas and ensure they are added as helpers (cherry picked from commit 5294fac)

(cherry picked from commit 8085070)

manuel-alvarez-alvarez added type: bug comp: asm iast Application Security Management (IAST) labels Jun 12, 2024

manuel-alvarez-alvarez marked this pull request as ready for review June 12, 2024 08:45

manuel-alvarez-alvarez requested review from a team as code owners June 12, 2024 08:45

manuel-alvarez-alvarez requested review from smola, ValentinZakharov, mcculls and ygree June 12, 2024 08:45

smola changed the title ~~Removed scala converter lambdas and ensure they are added as helpers …~~ Removed scala converter lambdas and ensure they are added as helpers (1.35.x backport) Jun 12, 2024

smola approved these changes Jun 12, 2024

View reviewed changes

amarziali approved these changes Jun 12, 2024

View reviewed changes

mcculls added this to the 1.35.1 milestone Jun 12, 2024

manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper-backport branch from 45988c8 to 277606b Compare June 12, 2024 10:06

PerfectSlayer changed the title ~~Removed scala converter lambdas and ensure they are added as helpers (1.35.x backport)~~ Removed scala converter lambdas and ensure they are added as helpers Jun 12, 2024

PerfectSlayer approved these changes Jun 12, 2024

View reviewed changes

mcculls force-pushed the malvarez/iast-fix-scala-helper-backport branch from 277606b to d55387a Compare June 12, 2024 10:36

manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper-backport branch 2 times, most recently from 9f1f33f to e12639a Compare June 12, 2024 13:02

manuel-alvarez-alvarez added 2 commits June 12, 2024 16:23

Removed scala converter lambdas and ensure they are added as helpers (#…

3a15b4f

…7146) Removed scala converter lambdas and ensure they are added as helpers (cherry picked from commit 5294fac)

Use kotlin plugin 1.9.24 (#7181)

59387b8

(cherry picked from commit 8085070)

manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper-backport branch from e12639a to 59387b8 Compare June 12, 2024 14:23

manuel-alvarez-alvarez merged commit 917b7d9 into release/v1.35.x Jun 12, 2024
76 checks passed

manuel-alvarez-alvarez deleted the malvarez/iast-fix-scala-helper-backport branch June 12, 2024 16:11

mcculls modified the milestones: 1.35.1, 1.35.2 Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed scala converter lambdas and ensure they are added as helpers #7168

Removed scala converter lambdas and ensure they are added as helpers #7168

manuel-alvarez-alvarez commented Jun 12, 2024 •

edited

Loading

pr-commenter bot commented Jun 12, 2024 •

edited

Loading

Removed scala converter lambdas and ensure they are added as helpers #7168

Removed scala converter lambdas and ensure they are added as helpers #7168

Conversation

manuel-alvarez-alvarez commented Jun 12, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Jun 12, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

manuel-alvarez-alvarez commented Jun 12, 2024 •

edited

Loading

pr-commenter bot commented Jun 12, 2024 •

edited

Loading