Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNS integration: do not modify readonly message attributes map #7174

Merged
merged 1 commit into from
Jun 12, 2024
Merged

SNS integration: do not modify readonly message attributes map #7174

merged 1 commit into from
Jun 12, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 12, 2024

Backport of #7150 for v.135.1

@mcculls mcculls added type: bug inst: aws sdk AWS SDK instrumentation tag: serverless Serverless support labels Jun 12, 2024
@mcculls mcculls added this to the 1.35.1 milestone Jun 12, 2024
@mcculls mcculls requested a review from a team as a code owner June 12, 2024 09:15
@pr-commenter
Copy link

pr-commenter bot commented Jun 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/sns-attributes-fix-v1.35.1
git_commit_date 1718180187 1718188541
git_commit_sha 222ce2c 869afab
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~869afabf84
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718191530 1718191530
ci_job_id 540467792 540467792
ci_pipeline_id 36496145 36496145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065183
Total [baseline] (10.399 s) : 0, 10398776
Agent [candidate] (1.063 s) : 0, 1062859
Total [candidate] (10.415 s) : 0, 10415041
section appsec
Agent [baseline] (1.179 s) : 0, 1179183
Total [baseline] (10.483 s) : 0, 10483026
Agent [candidate] (1.178 s) : 0, 1178349
Total [candidate] (10.491 s) : 0, 10490917
section iast
Agent [baseline] (1.174 s) : 0, 1173665
Total [baseline] (10.709 s) : 0, 10708922
Agent [candidate] (1.173 s) : 0, 1173495
Total [candidate] (10.787 s) : 0, 10786546
section profiling
Agent [baseline] (1.26 s) : 0, 1259620
Total [baseline] (10.641 s) : 0, 10640970
Agent [candidate] (1.266 s) : 0, 1266056
Total [candidate] (10.707 s) : 0, 10706964
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.179 s 114.0 ms (10.7%)
Agent iast 1.174 s 108.483 ms (10.2%)
Agent profiling 1.26 s 194.437 ms (18.3%)
Total tracing 10.399 s -
Total appsec 10.483 s 84.25 ms (0.8%)
Total iast 10.709 s 310.147 ms (3.0%)
Total profiling 10.641 s 242.194 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.178 s 115.491 ms (10.9%)
Agent iast 1.173 s 110.637 ms (10.4%)
Agent profiling 1.266 s 203.198 ms (19.1%)
Total tracing 10.415 s -
Total appsec 10.491 s 75.875 ms (0.7%)
Total iast 10.787 s 371.505 ms (3.6%)
Total profiling 10.707 s 291.923 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.079 ms) : 0, 666079
BytebuddyAgent [candidate] (665.665 ms) : 0, 665665
GlobalTracer [baseline] (305.614 ms) : 0, 305614
GlobalTracer [candidate] (303.972 ms) : 0, 303972
AppSec [baseline] (50.471 ms) : 0, 50471
AppSec [candidate] (50.185 ms) : 0, 50185
Logs Intake [baseline] (415.182 µs) : 0, 415
Logs Intake [candidate] (404.295 µs) : 0, 404
Remote Config [baseline] (676.611 µs) : 0, 677
Remote Config [candidate] (662.078 µs) : 0, 662
Telemetry [baseline] (7.647 ms) : 0, 7647
Telemetry [candidate] (7.57 ms) : 0, 7570
section appsec
BytebuddyAgent [baseline] (674.868 ms) : 0, 674868
BytebuddyAgent [candidate] (673.773 ms) : 0, 673773
GlobalTracer [baseline] (297.171 ms) : 0, 297171
GlobalTracer [candidate] (296.976 ms) : 0, 296976
AppSec [baseline] (152.946 ms) : 0, 152946
AppSec [candidate] (152.752 ms) : 0, 152752
Logs Intake [baseline] (318.716 µs) : 0, 319
Logs Intake [candidate] (331.549 µs) : 0, 332
Remote Config [baseline] (643.829 µs) : 0, 644
Remote Config [candidate] (636.497 µs) : 0, 636
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (8.709 ms) : 0, 8709
IAST [baseline] (21.02 ms) : 0, 21020
IAST [candidate] (21.73 ms) : 0, 21730
section iast
BytebuddyAgent [baseline] (783.968 ms) : 0, 783968
BytebuddyAgent [candidate] (782.993 ms) : 0, 782993
GlobalTracer [baseline] (293.881 ms) : 0, 293881
GlobalTracer [candidate] (293.577 ms) : 0, 293577
AppSec [baseline] (46.686 ms) : 0, 46686
AppSec [candidate] (46.995 ms) : 0, 46995
Logs Intake [baseline] (302.646 µs) : 0, 303
Logs Intake [candidate] (300.612 µs) : 0, 301
Remote Config [baseline] (576.838 µs) : 0, 577
Remote Config [candidate] (576.944 µs) : 0, 577
Telemetry [baseline] (7.674 ms) : 0, 7674
Telemetry [candidate] (6.854 ms) : 0, 6854
IAST [baseline] (27.258 ms) : 0, 27258
IAST [candidate] (28.865 ms) : 0, 28865
section profiling
ProfilingAgent [baseline] (96.54 ms) : 0, 96540
ProfilingAgent [candidate] (95.671 ms) : 0, 95671
BytebuddyAgent [baseline] (661.717 ms) : 0, 661717
BytebuddyAgent [candidate] (665.997 ms) : 0, 665997
GlobalTracer [baseline] (385.476 ms) : 0, 385476
GlobalTracer [candidate] (387.936 ms) : 0, 387936
AppSec [baseline] (50.87 ms) : 0, 50870
AppSec [candidate] (51.12 ms) : 0, 51120
Logs Intake [baseline] (334.914 µs) : 0, 335
Logs Intake [candidate] (327.741 µs) : 0, 328
Remote Config [baseline] (732.055 µs) : 0, 732
Remote Config [candidate] (745.27 µs) : 0, 745
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.355 ms) : 0, 7355
Profiling [baseline] (96.565 ms) : 0, 96565
Profiling [candidate] (95.696 ms) : 0, 95696
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062925
Total [baseline] (8.582 s) : 0, 8581576
Agent [candidate] (1.059 s) : 0, 1059353
Total [candidate] (8.554 s) : 0, 8554443
section iast
Agent [baseline] (1.176 s) : 0, 1175762
Total [baseline] (9.058 s) : 0, 9057913
Agent [candidate] (1.169 s) : 0, 1168600
Total [candidate] (9.025 s) : 0, 9025243
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1175433
Total [baseline] (8.972 s) : 0, 8971571
Agent [candidate] (1.168 s) : 0, 1167771
Total [candidate] (8.978 s) : 0, 8977769
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1161707
Total [baseline] (8.976 s) : 0, 8976295
Agent [candidate] (1.173 s) : 0, 1172859
Total [candidate] (9.006 s) : 0, 9006084
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.176 s 112.837 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 112.508 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.162 s 98.781 ms (9.3%)
Total tracing 8.582 s -
Total iast 9.058 s 476.337 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.972 s 389.995 ms (4.5%)
Total iast_TELEMETRY_OFF 8.976 s 394.719 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.169 s 109.247 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 108.419 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.173 s 113.506 ms (10.7%)
Total tracing 8.554 s -
Total iast 9.025 s 470.8 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.978 s 423.326 ms (4.9%)
Total iast_TELEMETRY_OFF 9.006 s 451.641 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.683 ms) : 0, 665683
BytebuddyAgent [candidate] (662.853 ms) : 0, 662853
GlobalTracer [baseline] (304.122 ms) : 0, 304122
GlobalTracer [candidate] (303.359 ms) : 0, 303359
AppSec [baseline] (50.229 ms) : 0, 50229
AppSec [candidate] (50.184 ms) : 0, 50184
Logs Intake [baseline] (403.614 µs) : 0, 404
Logs Intake [candidate] (412.331 µs) : 0, 412
Remote Config [baseline] (651.233 µs) : 0, 651
Remote Config [candidate] (668.957 µs) : 0, 669
Telemetry [baseline] (7.508 ms) : 0, 7508
Telemetry [candidate] (7.561 ms) : 0, 7561
section iast
BytebuddyAgent [baseline] (784.009 ms) : 0, 784009
BytebuddyAgent [candidate] (778.13 ms) : 0, 778130
GlobalTracer [baseline] (294.962 ms) : 0, 294962
GlobalTracer [candidate] (293.916 ms) : 0, 293916
AppSec [baseline] (47.093 ms) : 0, 47093
AppSec [candidate] (47.01 ms) : 0, 47010
IAST [baseline] (25.458 ms) : 0, 25458
IAST [candidate] (28.517 ms) : 0, 28517
Logs Intake [baseline] (300.996 µs) : 0, 301
Logs Intake [candidate] (298.609 µs) : 0, 299
Remote Config [baseline] (577.014 µs) : 0, 577
Remote Config [candidate] (581.884 µs) : 0, 582
Telemetry [baseline] (9.971 ms) : 0, 9971
Telemetry [candidate] (6.873 ms) : 0, 6873
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.621 ms) : 0, 783621
BytebuddyAgent [candidate] (779.056 ms) : 0, 779056
GlobalTracer [baseline] (295.359 ms) : 0, 295359
GlobalTracer [candidate] (293.679 ms) : 0, 293679
AppSec [baseline] (46.715 ms) : 0, 46715
AppSec [candidate] (46.669 ms) : 0, 46669
IAST [baseline] (25.471 ms) : 0, 25471
IAST [candidate] (24.803 ms) : 0, 24803
Logs Intake [baseline] (302.624 µs) : 0, 303
Logs Intake [candidate] (313.95 µs) : 0, 314
Remote Config [baseline] (584.427 µs) : 0, 584
Remote Config [candidate] (599.604 µs) : 0, 600
Telemetry [baseline] (9.98 ms) : 0, 9980
Telemetry [candidate] (9.285 ms) : 0, 9285
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.649 ms) : 0, 775649
BytebuddyAgent [candidate] (781.528 ms) : 0, 781528
GlobalTracer [baseline] (293.126 ms) : 0, 293126
GlobalTracer [candidate] (294.911 ms) : 0, 294911
AppSec [baseline] (46.176 ms) : 0, 46176
AppSec [candidate] (46.814 ms) : 0, 46814
IAST [baseline] (25.8 ms) : 0, 25800
IAST [candidate] (26.194 ms) : 0, 26194
Logs Intake [baseline] (298.518 µs) : 0, 299
Logs Intake [candidate] (309.629 µs) : 0, 310
Remote Config [baseline] (565.856 µs) : 0, 566
Remote Config [candidate] (582.936 µs) : 0, 583
Telemetry [baseline] (6.802 ms) : 0, 6802
Telemetry [candidate] (9.12 ms) : 0, 9120
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-12T10:56:15 2024-06-12T11:03:03
git_branch master vandonr/sns-attributes-fix-v1.35.1
git_commit_date 1718180187 1718188541
git_commit_sha 222ce2c 869afab
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~869afabf84
start_time 2024-06-12T10:56:02 2024-06-12T11:02:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718190528 1718190528
ci_job_id 540467794 540467794
ci_pipeline_id 36496145 36496145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1356
.   : milestone, 1337,
appsec (1.717 ms) : 1692, 1742
.   : milestone, 1717,
appsec_no_iast (1.701 ms) : 1675, 1726
.   : milestone, 1701,
iast (1.486 ms) : 1462, 1509
.   : milestone, 1486,
profiling (1.476 ms) : 1451, 1501
.   : milestone, 1476,
tracing (1.452 ms) : 1428, 1477
.   : milestone, 1452,
section candidate
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.735 ms) : 1711, 1758
.   : milestone, 1735,
appsec_no_iast (1.716 ms) : 1691, 1741
.   : milestone, 1716,
iast (1.458 ms) : 1436, 1481
.   : milestone, 1458,
profiling (1.521 ms) : 1496, 1547
.   : milestone, 1521,
tracing (1.48 ms) : 1455, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.356 ms] -
appsec 1.717 ms [1.692 ms, 1.742 ms] 380.034 µs (28.4%)
appsec_no_iast 1.701 ms [1.675 ms, 1.726 ms] 363.768 µs (27.2%)
iast 1.486 ms [1.462 ms, 1.509 ms] 148.714 µs (11.1%)
profiling 1.476 ms [1.451 ms, 1.501 ms] 139.052 µs (10.4%)
tracing 1.452 ms [1.428 ms, 1.477 ms] 115.69 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.735 ms [1.711 ms, 1.758 ms] 392.397 µs (29.2%)
appsec_no_iast 1.716 ms [1.691 ms, 1.741 ms] 373.672 µs (27.8%)
iast 1.458 ms [1.436 ms, 1.481 ms] 116.191 µs (8.7%)
profiling 1.521 ms [1.496 ms, 1.547 ms] 178.948 µs (13.3%)
tracing 1.48 ms [1.455 ms, 1.504 ms] 137.496 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.915 µs) : 346, 386
.   : milestone, 366,
iast (477.68 µs) : 457, 499
.   : milestone, 478,
iast_FULL (551.397 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (501.43 µs) : 481, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (476.496 µs) : 455, 498
.   : milestone, 476,
iast_INACTIVE (451.116 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (466.821 µs) : 446, 488
.   : milestone, 467,
tracing (441.378 µs) : 421, 462
.   : milestone, 441,
section candidate
no_agent (367.546 µs) : 348, 387
.   : milestone, 368,
iast (479.591 µs) : 458, 501
.   : milestone, 480,
iast_FULL (546.271 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (504.216 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (480.365 µs) : 459, 502
.   : milestone, 480,
iast_INACTIVE (447.276 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (468.848 µs) : 447, 491
.   : milestone, 469,
tracing (436.507 µs) : 416, 457
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.915 µs [346.221 µs, 385.608 µs] -
iast 477.68 µs [456.726 µs, 498.635 µs] 111.766 µs (30.5%)
iast_FULL 551.397 µs [530.191 µs, 572.602 µs] 185.482 µs (50.7%)
iast_GLOBAL 501.43 µs [480.63 µs, 522.23 µs] 135.515 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 476.496 µs [455.004 µs, 497.989 µs] 110.582 µs (30.2%)
iast_INACTIVE 451.116 µs [430.211 µs, 472.02 µs] 85.201 µs (23.3%)
iast_TELEMETRY_OFF 466.821 µs [445.839 µs, 487.803 µs] 100.907 µs (27.6%)
tracing 441.378 µs [420.66 µs, 462.096 µs] 75.464 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.546 µs [348.31 µs, 386.782 µs] -
iast 479.591 µs [458.026 µs, 501.156 µs] 112.045 µs (30.5%)
iast_FULL 546.271 µs [525.054 µs, 567.488 µs] 178.725 µs (48.6%)
iast_GLOBAL 504.216 µs [482.656 µs, 525.777 µs] 136.67 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 480.365 µs [458.951 µs, 501.779 µs] 112.819 µs (30.7%)
iast_INACTIVE 447.276 µs [426.645 µs, 467.907 µs] 79.73 µs (21.7%)
iast_TELEMETRY_OFF 468.848 µs [447.144 µs, 490.551 µs] 101.302 µs (27.6%)
tracing 436.507 µs [416.159 µs, 456.855 µs] 68.961 µs (18.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/sns-attributes-fix-v1.35.1
git_commit_date 1718180187 1718188541
git_commit_sha 222ce2c 869afab
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~869afabf84
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718191059 1718191059
ci_job_id 540467796 540467796
ci_pipeline_id 36496145 36496145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.215 ms) : 2181, 2249
.   : milestone, 2215,
iast (1.965 ms) : 1925, 2006
.   : milestone, 1965,
iast_GLOBAL (2.02 ms) : 1978, 2062
.   : milestone, 2020,
profiling (1.854 ms) : 1819, 1889
.   : milestone, 1854,
tracing (1.834 ms) : 1802, 1866
.   : milestone, 1834,
section candidate
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.23 ms) : 2196, 2264
.   : milestone, 2230,
iast (1.97 ms) : 1929, 2011
.   : milestone, 1970,
iast_GLOBAL (1.998 ms) : 1957, 2038
.   : milestone, 1998,
profiling (1.864 ms) : 1829, 1899
.   : milestone, 1864,
tracing (1.84 ms) : 1808, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.215 ms [2.181 ms, 2.249 ms] 748.167 µs (51.0%)
iast 1.965 ms [1.925 ms, 2.006 ms] 498.628 µs (34.0%)
iast_GLOBAL 2.02 ms [1.978 ms, 2.062 ms] 553.127 µs (37.7%)
profiling 1.854 ms [1.819 ms, 1.889 ms] 387.043 µs (26.4%)
tracing 1.834 ms [1.802 ms, 1.866 ms] 367.406 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.23 ms [2.196 ms, 2.264 ms] 765.04 µs (52.2%)
iast 1.97 ms [1.929 ms, 2.011 ms] 504.68 µs (34.5%)
iast_GLOBAL 1.998 ms [1.957 ms, 2.038 ms] 532.757 µs (36.4%)
profiling 1.864 ms [1.829 ms, 1.899 ms] 399.24 µs (27.3%)
tracing 1.84 ms [1.808 ms, 1.872 ms] 375.029 µs (25.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~869afabf84, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.827 s) : 14827000, 14827000
.   : milestone, 14827000,
appsec (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
iast (18.704 s) : 18704000, 18704000
.   : milestone, 18704000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
.   : milestone, 17964000,
profiling (15.594 s) : 15594000, 15594000
.   : milestone, 15594000,
tracing (15.14 s) : 15140000, 15140000
.   : milestone, 15140000,
section candidate
no_agent (15.05 s) : 15050000, 15050000
.   : milestone, 15050000,
appsec (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
iast (18.938 s) : 18938000, 18938000
.   : milestone, 18938000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
.   : milestone, 18032000,
profiling (15.756 s) : 15756000, 15756000
.   : milestone, 15756000,
tracing (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.827 s [14.827 s, 14.827 s] -
appsec 15.076 s [15.076 s, 15.076 s] 249.0 ms (1.7%)
iast 18.704 s [18.704 s, 18.704 s] 3.877 s (26.1%)
iast_GLOBAL 17.964 s [17.964 s, 17.964 s] 3.137 s (21.2%)
profiling 15.594 s [15.594 s, 15.594 s] 767.0 ms (5.2%)
tracing 15.14 s [15.14 s, 15.14 s] 313.0 ms (2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.05 s [15.05 s, 15.05 s] -
appsec 15.125 s [15.125 s, 15.125 s] 75.0 ms (0.5%)
iast 18.938 s [18.938 s, 18.938 s] 3.888 s (25.8%)
iast_GLOBAL 18.032 s [18.032 s, 18.032 s] 2.982 s (19.8%)
profiling 15.756 s [15.756 s, 15.756 s] 706.0 ms (4.7%)
tracing 15.028 s [15.028 s, 15.028 s] -22.0 ms (-0.1%)

@vandonr @mcculls
SNS integration: do not modify readonly message attributes map (#7150)
869afab 
* fix bug when SNS message attr are readonly + test

* fix extra bug in v2 on message attr size
@mcculls mcculls force-pushed the vandonr/sns-attributes-fix-v1.35.1 branch from 9756f28 to 869afab Compare June 12, 2024 10:35
@mcculls mcculls merged commit cb23e07 into release/v1.35.x Jun 12, 2024
76 checks passed
@mcculls mcculls deleted the vandonr/sns-attributes-fix-v1.35.1 branch June 12, 2024 11:36
@mcculls mcculls modified the milestones: 1.35.1, 1.35.2 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
inst: aws sdk AWS SDK instrumentation tag: serverless Serverless support type: bug
Projects
None yet
Milestone
1.35.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcculls @amarziali @vandonr