Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support graphql 22 #7176

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Support graphql 22 #7176

merged 1 commit into from
Jun 14, 2024

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Jun 12, 2024 •
edited by am312
Loading

What Does This Do

Support Graphql 22 and do some refactoring to use more performant instrumentation available starting from 20.

Motivation

Additional Notes

solves #7153

@amarziali amarziali added the inst: others All other instrumentations label Jun 12, 2024
@amarziali amarziali requested review from a team as code owners June 12, 2024 09:50
@amarziali amarziali requested review from mcculls and ygree June 12, 2024 09:50
@amarziali amarziali force-pushed the andrea.marziali/graphql-22 branch 2 times, most recently from 7463d60 to 10adc2d Compare June 12, 2024 10:34
@pr-commenter
Copy link

pr-commenter bot commented Jun 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/graphql-22
git_commit_date 1718180187 1718188464
git_commit_sha 222ce2c 10adc2d
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~10adc2d1b2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718191329 1718191329
ci_job_id 540467388 540467388
ci_pipeline_id 36496109 36496109
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076487
Total [baseline] (8.6 s) : 0, 8599765
Agent [candidate] (1.067 s) : 0, 1066657
Total [candidate] (8.552 s) : 0, 8551730
section iast
Agent [baseline] (1.168 s) : 0, 1168180
Total [baseline] (8.995 s) : 0, 8994957
Agent [candidate] (1.167 s) : 0, 1167179
Total [candidate] (8.995 s) : 0, 8995302
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174960
Total [baseline] (8.99 s) : 0, 8990319
Agent [candidate] (1.17 s) : 0, 1169778
Total [candidate] (8.983 s) : 0, 8982524
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1184722
Total [baseline] (9.033 s) : 0, 9032506
Agent [candidate] (1.171 s) : 0, 1171302
Total [candidate] (9.022 s) : 0, 9022296
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.168 s 91.693 ms (8.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 98.474 ms (9.1%)
Agent iast_TELEMETRY_OFF 1.185 s 108.235 ms (10.1%)
Total tracing 8.6 s -
Total iast 8.995 s 395.192 ms (4.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.99 s 390.554 ms (4.5%)
Total iast_TELEMETRY_OFF 9.033 s 432.742 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.167 s 100.522 ms (9.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 103.121 ms (9.7%)
Agent iast_TELEMETRY_OFF 1.171 s 104.645 ms (9.8%)
Total tracing 8.552 s -
Total iast 8.995 s 443.572 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.983 s 430.794 ms (5.0%)
Total iast_TELEMETRY_OFF 9.022 s 470.566 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.061 ms) : 0, 674061
BytebuddyAgent [candidate] (668.977 ms) : 0, 668977
GlobalTracer [baseline] (308.008 ms) : 0, 308008
GlobalTracer [candidate] (304.587 ms) : 0, 304587
AppSec [baseline] (50.857 ms) : 0, 50857
AppSec [candidate] (50.096 ms) : 0, 50096
Logs Intake [baseline] (381.049 µs) : 0, 381
Logs Intake [candidate] (410.45 µs) : 0, 410
Remote Config [baseline] (674.479 µs) : 0, 674
Remote Config [candidate] (659.427 µs) : 0, 659
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.433 ms) : 0, 7433
section iast
BytebuddyAgent [baseline] (780.167 ms) : 0, 780167
BytebuddyAgent [candidate] (778.389 ms) : 0, 778389
GlobalTracer [baseline] (293.819 ms) : 0, 293819
GlobalTracer [candidate] (292.624 ms) : 0, 292624
AppSec [baseline] (46.733 ms) : 0, 46733
AppSec [candidate] (46.714 ms) : 0, 46714
Logs Intake [baseline] (298.688 µs) : 0, 299
Logs Intake [candidate] (304.852 µs) : 0, 305
Remote Config [baseline] (563.57 µs) : 0, 564
Remote Config [candidate] (568.898 µs) : 0, 569
Telemetry [baseline] (6.939 ms) : 0, 6939
Telemetry [candidate] (9.971 ms) : 0, 9971
IAST [baseline] (26.369 ms) : 0, 26369
IAST [candidate] (25.315 ms) : 0, 25315
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.537 ms) : 0, 784537
BytebuddyAgent [candidate] (779.118 ms) : 0, 779118
GlobalTracer [baseline] (295.282 ms) : 0, 295282
GlobalTracer [candidate] (294.468 ms) : 0, 294468
AppSec [baseline] (46.886 ms) : 0, 46886
AppSec [candidate] (46.442 ms) : 0, 46442
Logs Intake [baseline] (307.578 µs) : 0, 308
Logs Intake [candidate] (296.556 µs) : 0, 297
Remote Config [baseline] (585.388 µs) : 0, 585
Remote Config [candidate] (567.032 µs) : 0, 567
Telemetry [baseline] (6.907 ms) : 0, 6907
Telemetry [candidate] (9.151 ms) : 0, 9151
IAST [baseline] (27.045 ms) : 0, 27045
IAST [candidate] (26.353 ms) : 0, 26353
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.168 ms) : 0, 792168
BytebuddyAgent [candidate] (780.929 ms) : 0, 780929
GlobalTracer [baseline] (298.932 ms) : 0, 298932
GlobalTracer [candidate] (294.657 ms) : 0, 294657
AppSec [baseline] (49.268 ms) : 0, 49268
AppSec [candidate] (48.651 ms) : 0, 48651
Logs Intake [baseline] (302.832 µs) : 0, 303
Logs Intake [candidate] (297.507 µs) : 0, 298
Remote Config [baseline] (589.611 µs) : 0, 590
Remote Config [candidate] (576.515 µs) : 0, 577
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (6.76 ms) : 0, 6760
IAST [baseline] (22.276 ms) : 0, 22276
IAST [candidate] (26.009 ms) : 0, 26009
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060556
Total [baseline] (10.403 s) : 0, 10402622
Agent [candidate] (1.06 s) : 0, 1060222
Total [candidate] (10.31 s) : 0, 10310045
section appsec
Agent [baseline] (1.181 s) : 0, 1180933
Total [baseline] (10.46 s) : 0, 10459680
Agent [candidate] (1.183 s) : 0, 1183202
Total [candidate] (10.49 s) : 0, 10490473
section iast
Agent [baseline] (1.18 s) : 0, 1179791
Total [baseline] (10.713 s) : 0, 10712837
Agent [candidate] (1.167 s) : 0, 1167136
Total [candidate] (10.701 s) : 0, 10701295
section profiling
Agent [baseline] (1.261 s) : 0, 1261493
Total [baseline] (10.731 s) : 0, 10730955
Agent [candidate] (1.269 s) : 0, 1268837
Total [candidate] (10.659 s) : 0, 10658776
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.181 s 120.377 ms (11.4%)
Agent iast 1.18 s 119.235 ms (11.2%)
Agent profiling 1.261 s 200.936 ms (18.9%)
Total tracing 10.403 s -
Total appsec 10.46 s 57.058 ms (0.5%)
Total iast 10.713 s 310.216 ms (3.0%)
Total profiling 10.731 s 328.334 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.183 s 122.98 ms (11.6%)
Agent iast 1.167 s 106.914 ms (10.1%)
Agent profiling 1.269 s 208.615 ms (19.7%)
Total tracing 10.31 s -
Total appsec 10.49 s 180.428 ms (1.8%)
Total iast 10.701 s 391.25 ms (3.8%)
Total profiling 10.659 s 348.732 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.857 ms) : 0, 663857
BytebuddyAgent [candidate] (663.742 ms) : 0, 663742
GlobalTracer [baseline] (303.706 ms) : 0, 303706
GlobalTracer [candidate] (303.465 ms) : 0, 303465
AppSec [baseline] (49.939 ms) : 0, 49939
AppSec [candidate] (50.034 ms) : 0, 50034
Logs Intake [baseline] (406.495 µs) : 0, 406
Logs Intake [candidate] (414.798 µs) : 0, 415
Remote Config [baseline] (658.707 µs) : 0, 659
Remote Config [candidate] (665.752 µs) : 0, 666
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.534 ms) : 0, 7534
section appsec
BytebuddyAgent [baseline] (676.671 ms) : 0, 676671
BytebuddyAgent [candidate] (677.723 ms) : 0, 677723
GlobalTracer [baseline] (297.714 ms) : 0, 297714
GlobalTracer [candidate] (298.052 ms) : 0, 298052
AppSec [baseline] (153.117 ms) : 0, 153117
AppSec [candidate] (152.881 ms) : 0, 152881
IAST [baseline] (20.445 ms) : 0, 20445
IAST [candidate] (21.788 ms) : 0, 21788
Logs Intake [baseline] (321.471 µs) : 0, 321
Logs Intake [candidate] (323.281 µs) : 0, 323
Remote Config [baseline] (637.039 µs) : 0, 637
Remote Config [candidate] (635.712 µs) : 0, 636
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (8.144 ms) : 0, 8144
section iast
BytebuddyAgent [baseline] (787.337 ms) : 0, 787337
BytebuddyAgent [candidate] (777.874 ms) : 0, 777874
GlobalTracer [baseline] (295.851 ms) : 0, 295851
GlobalTracer [candidate] (293.102 ms) : 0, 293102
AppSec [baseline] (47.178 ms) : 0, 47178
AppSec [candidate] (47.172 ms) : 0, 47172
IAST [baseline] (26.641 ms) : 0, 26641
IAST [candidate] (26.472 ms) : 0, 26472
Logs Intake [baseline] (312.685 µs) : 0, 313
Logs Intake [candidate] (304.951 µs) : 0, 305
Remote Config [baseline] (583.327 µs) : 0, 583
Remote Config [candidate] (569.034 µs) : 0, 569
Telemetry [baseline] (8.517 ms) : 0, 8517
Telemetry [candidate] (8.372 ms) : 0, 8372
section profiling
BytebuddyAgent [baseline] (662.499 ms) : 0, 662499
BytebuddyAgent [candidate] (666.911 ms) : 0, 666911
GlobalTracer [baseline] (386.325 ms) : 0, 386325
GlobalTracer [candidate] (388.291 ms) : 0, 388291
AppSec [baseline] (50.776 ms) : 0, 50776
AppSec [candidate] (51.166 ms) : 0, 51166
Logs Intake [baseline] (330.525 µs) : 0, 331
Logs Intake [candidate] (338.687 µs) : 0, 339
Remote Config [baseline] (746.615 µs) : 0, 747
Remote Config [candidate] (760.253 µs) : 0, 760
Telemetry [baseline] (7.332 ms) : 0, 7332
Telemetry [candidate] (7.429 ms) : 0, 7429
ProfilingAgent [baseline] (96.829 ms) : 0, 96829
ProfilingAgent [candidate] (96.94 ms) : 0, 96940
Profiling [baseline] (96.853 ms) : 0, 96853
Profiling [candidate] (96.965 ms) : 0, 96965
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-12T10:52:55 2024-06-12T10:59:47
git_branch master andrea.marziali/graphql-22
git_commit_date 1718180187 1718188464
git_commit_sha 222ce2c 10adc2d
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~10adc2d1b2
start_time 2024-06-12T10:52:42 2024-06-12T10:59:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718190333 1718190333
ci_job_id 540467389 540467389
ci_pipeline_id 36496109 36496109
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.942 µs) : 358, 398
.   : milestone, 378,
iast (488.809 µs) : 467, 510
.   : milestone, 489,
iast_FULL (557.308 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (527.427 µs) : 505, 550
.   : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (485.722 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (458.286 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (475.655 µs) : 455, 497
.   : milestone, 476,
tracing (444.031 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (370.233 µs) : 351, 390
.   : milestone, 370,
iast (490.604 µs) : 469, 512
.   : milestone, 491,
iast_FULL (553.416 µs) : 532, 575
.   : milestone, 553,
iast_GLOBAL (511.644 µs) : 490, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (483.65 µs) : 462, 505
.   : milestone, 484,
iast_INACTIVE (460.788 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (478.46 µs) : 457, 500
.   : milestone, 478,
tracing (446.516 µs) : 426, 467
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.942 µs [358.306 µs, 397.578 µs] -
iast 488.809 µs [467.436 µs, 510.183 µs] 110.867 µs (29.3%)
iast_FULL 557.308 µs [535.828 µs, 578.788 µs] 179.366 µs (47.5%)
iast_GLOBAL 527.427 µs [504.732 µs, 550.122 µs] 149.485 µs (39.6%)
iast_HARDCODED_SECRET_DISABLED 485.722 µs [464.007 µs, 507.438 µs] 107.78 µs (28.5%)
iast_INACTIVE 458.286 µs [436.94 µs, 479.632 µs] 80.344 µs (21.3%)
iast_TELEMETRY_OFF 475.655 µs [454.764 µs, 496.547 µs] 97.713 µs (25.9%)
tracing 444.031 µs [423.868 µs, 464.194 µs] 66.089 µs (17.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.233 µs [350.592 µs, 389.874 µs] -
iast 490.604 µs [468.777 µs, 512.431 µs] 120.371 µs (32.5%)
iast_FULL 553.416 µs [532.281 µs, 574.551 µs] 183.183 µs (49.5%)
iast_GLOBAL 511.644 µs [489.858 µs, 533.429 µs] 141.411 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 483.65 µs [462.479 µs, 504.821 µs] 113.418 µs (30.6%)
iast_INACTIVE 460.788 µs [439.196 µs, 482.379 µs] 90.555 µs (24.5%)
iast_TELEMETRY_OFF 478.46 µs [457.412 µs, 499.507 µs] 108.227 µs (29.2%)
tracing 446.516 µs [425.973 µs, 467.06 µs] 76.284 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
.   : milestone, 1361,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.729 ms) : 1704, 1753
.   : milestone, 1729,
iast (1.484 ms) : 1461, 1506
.   : milestone, 1484,
profiling (1.497 ms) : 1473, 1520
.   : milestone, 1497,
tracing (1.474 ms) : 1448, 1499
.   : milestone, 1474,
section candidate
no_agent (1.36 ms) : 1339, 1380
.   : milestone, 1360,
appsec (1.718 ms) : 1695, 1742
.   : milestone, 1718,
appsec_no_iast (1.731 ms) : 1707, 1756
.   : milestone, 1731,
iast (1.472 ms) : 1450, 1494
.   : milestone, 1472,
profiling (1.494 ms) : 1470, 1518
.   : milestone, 1494,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.341 ms, 1.381 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 382.577 µs (28.1%)
appsec_no_iast 1.729 ms [1.704 ms, 1.753 ms] 367.708 µs (27.0%)
iast 1.484 ms [1.461 ms, 1.506 ms] 122.941 µs (9.0%)
profiling 1.497 ms [1.473 ms, 1.52 ms] 135.693 µs (10.0%)
tracing 1.474 ms [1.448 ms, 1.499 ms] 112.597 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.339 ms, 1.38 ms] -
appsec 1.718 ms [1.695 ms, 1.742 ms] 358.601 µs (26.4%)
appsec_no_iast 1.731 ms [1.707 ms, 1.756 ms] 371.898 µs (27.4%)
iast 1.472 ms [1.45 ms, 1.494 ms] 112.741 µs (8.3%)
profiling 1.494 ms [1.47 ms, 1.518 ms] 134.487 µs (9.9%)
tracing 1.494 ms [1.469 ms, 1.519 ms] 134.515 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/graphql-22
git_commit_date 1718180187 1718188464
git_commit_sha 222ce2c 10adc2d
release_version 1.36.0-SNAPSHOT~222ce2c65e 1.36.0-SNAPSHOT~10adc2d1b2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718190834 1718190834
ci_job_id 540467390 540467390
ci_pipeline_id 36496109 36496109
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.203 ms) : 2169, 2237
.   : milestone, 2203,
iast (1.966 ms) : 1925, 2008
.   : milestone, 1966,
iast_GLOBAL (2.013 ms) : 1971, 2054
.   : milestone, 2013,
profiling (1.856 ms) : 1821, 1891
.   : milestone, 1856,
tracing (1.837 ms) : 1805, 1870
.   : milestone, 1837,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.195 ms) : 2162, 2229
.   : milestone, 2195,
iast (1.967 ms) : 1926, 2008
.   : milestone, 1967,
iast_GLOBAL (2.008 ms) : 1967, 2049
.   : milestone, 2008,
profiling (1.857 ms) : 1823, 1890
.   : milestone, 1857,
tracing (1.839 ms) : 1806, 1871
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.203 ms [2.169 ms, 2.237 ms] 740.61 µs (50.6%)
iast 1.966 ms [1.925 ms, 2.008 ms] 504.017 µs (34.5%)
iast_GLOBAL 2.013 ms [1.971 ms, 2.054 ms] 550.394 µs (37.6%)
profiling 1.856 ms [1.821 ms, 1.891 ms] 393.73 µs (26.9%)
tracing 1.837 ms [1.805 ms, 1.87 ms] 374.953 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.195 ms [2.162 ms, 2.229 ms] 732.764 µs (50.1%)
iast 1.967 ms [1.926 ms, 2.008 ms] 504.937 µs (34.5%)
iast_GLOBAL 2.008 ms [1.967 ms, 2.049 ms] 545.703 µs (37.3%)
profiling 1.857 ms [1.823 ms, 1.89 ms] 394.017 µs (26.9%)
tracing 1.839 ms [1.806 ms, 1.871 ms] 376.229 µs (25.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~10adc2d1b2, baseline=1.36.0-SNAPSHOT~222ce2c65e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
appsec (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
iast (18.751 s) : 18751000, 18751000
.   : milestone, 18751000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
.   : milestone, 18045000,
profiling (15.365 s) : 15365000, 15365000
.   : milestone, 15365000,
tracing (15.204 s) : 15204000, 15204000
.   : milestone, 15204000,
section candidate
no_agent (15.144 s) : 15144000, 15144000
.   : milestone, 15144000,
appsec (15.351 s) : 15351000, 15351000
.   : milestone, 15351000,
iast (18.498 s) : 18498000, 18498000
.   : milestone, 18498000,
iast_GLOBAL (18.041 s) : 18041000, 18041000
.   : milestone, 18041000,
profiling (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
tracing (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.029 s [15.029 s, 15.029 s] -
appsec 15.075 s [15.075 s, 15.075 s] 46.0 ms (0.3%)
iast 18.751 s [18.751 s, 18.751 s] 3.722 s (24.8%)
iast_GLOBAL 18.045 s [18.045 s, 18.045 s] 3.016 s (20.1%)
profiling 15.365 s [15.365 s, 15.365 s] 336.0 ms (2.2%)
tracing 15.204 s [15.204 s, 15.204 s] 175.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.144 s [15.144 s, 15.144 s] -
appsec 15.351 s [15.351 s, 15.351 s] 207.0 ms (1.4%)
iast 18.498 s [18.498 s, 18.498 s] 3.354 s (22.1%)
iast_GLOBAL 18.041 s [18.041 s, 18.041 s] 2.897 s (19.1%)
profiling 15.221 s [15.221 s, 15.221 s] 77.0 ms (0.5%)
tracing 15.059 s [15.059 s, 15.059 s] -85.0 ms (-0.6%)

ygree
ygree approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amarziali amarziali added this to the 1.36.0 milestone Jun 14, 2024
@amarziali amarziali enabled auto-merge (squash) June 14, 2024 12:44
@amarziali amarziali merged commit 33a2dcd into master Jun 14, 2024
77 of 80 checks passed
@amarziali amarziali deleted the andrea.marziali/graphql-22 branch June 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: others All other instrumentations
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amarziali @ygree