-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map OpenTelemetry environment variables to their Datadog equivalents #7185
Merged
mcculls
merged 3 commits into
release/v1.35.x
from
mcculls/otel-env-var-mapping-v1.35.1
Jun 13, 2024
Merged
Map OpenTelemetry environment variables to their Datadog equivalents #7185
mcculls
merged 3 commits into
release/v1.35.x
from
mcculls/otel-env-var-mapping-v1.35.1
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Datadog equivalents
f449a36
to
2b845a3
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.585 s) : 0, 1585376
Total [baseline] (14.406 s) : 0, 14405936
Agent [candidate] (1.584 s) : 0, 1584057
Total [candidate] (14.428 s) : 0, 14427577
section appsec
Agent [baseline] (1.765 s) : 0, 1765043
Total [baseline] (14.399 s) : 0, 14398667
Agent [candidate] (1.758 s) : 0, 1758011
Total [candidate] (14.435 s) : 0, 14434891
section iast
Agent [baseline] (1.708 s) : 0, 1708294
Total [baseline] (14.75 s) : 0, 14749988
Agent [candidate] (1.709 s) : 0, 1709442
Total [candidate] (14.72 s) : 0, 14719790
section profiling
Agent [baseline] (1.888 s) : 0, 1888136
Total [baseline] (14.824 s) : 0, 14824050
Agent [candidate] (1.896 s) : 0, 1895944
Total [candidate] (14.728 s) : 0, 14728191
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (990.762 ms) : 0, 990762
BytebuddyAgent [candidate] (988.875 ms) : 0, 988875
GlobalTracer [baseline] (451.463 ms) : 0, 451463
GlobalTracer [candidate] (451.467 ms) : 0, 451467
AppSec [baseline] (71.369 ms) : 0, 71369
AppSec [candidate] (71.963 ms) : 0, 71963
Logs Intake [baseline] (415.78 µs) : 0, 416
Logs Intake [candidate] (414.808 µs) : 0, 415
Remote Config [baseline] (918.167 µs) : 0, 918
Remote Config [candidate] (873.008 µs) : 0, 873
Telemetry [baseline] (9.791 ms) : 0, 9791
Telemetry [candidate] (9.825 ms) : 0, 9825
section appsec
BytebuddyAgent [baseline] (1.007 s) : 0, 1007161
BytebuddyAgent [candidate] (1.003 s) : 0, 1002553
GlobalTracer [baseline] (442.943 ms) : 0, 442943
GlobalTracer [candidate] (441.289 ms) : 0, 441289
AppSec [baseline] (231.857 ms) : 0, 231857
AppSec [candidate] (231.163 ms) : 0, 231163
Logs Intake [baseline] (413.791 µs) : 0, 414
Logs Intake [candidate] (421.126 µs) : 0, 421
Remote Config [baseline] (793.224 µs) : 0, 793
Remote Config [candidate] (776.263 µs) : 0, 776
Telemetry [baseline] (8.918 ms) : 0, 8918
Telemetry [candidate] (8.885 ms) : 0, 8885
IAST [baseline] (24.63 ms) : 0, 24630
IAST [candidate] (24.669 ms) : 0, 24669
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1145347
BytebuddyAgent [candidate] (1.146 s) : 0, 1145739
GlobalTracer [baseline] (431.938 ms) : 0, 431938
GlobalTracer [candidate] (432.149 ms) : 0, 432149
AppSec [baseline] (66.501 ms) : 0, 66501
AppSec [candidate] (66.21 ms) : 0, 66210
Logs Intake [baseline] (382.149 µs) : 0, 382
Logs Intake [candidate] (389.423 µs) : 0, 389
Remote Config [baseline] (735.858 µs) : 0, 736
Remote Config [candidate] (725.926 µs) : 0, 726
Telemetry [baseline] (12.275 ms) : 0, 12275
Telemetry [candidate] (11.322 ms) : 0, 11322
IAST [baseline] (31.454 ms) : 0, 31454
IAST [candidate] (33.142 ms) : 0, 33142
section profiling
ProfilingAgent [baseline] (148.461 ms) : 0, 148461
ProfilingAgent [candidate] (156.2 ms) : 0, 156200
BytebuddyAgent [baseline] (983.684 ms) : 0, 983684
BytebuddyAgent [candidate] (983.883 ms) : 0, 983883
GlobalTracer [baseline] (578.758 ms) : 0, 578758
GlobalTracer [candidate] (578.212 ms) : 0, 578212
AppSec [baseline] (72.88 ms) : 0, 72880
AppSec [candidate] (72.478 ms) : 0, 72478
Logs Intake [baseline] (415.414 µs) : 0, 415
Logs Intake [candidate] (422.424 µs) : 0, 422
Remote Config [baseline] (968.403 µs) : 0, 968
Remote Config [candidate] (942.766 µs) : 0, 943
Telemetry [baseline] (9.505 ms) : 0, 9505
Telemetry [candidate] (9.46 ms) : 0, 9460
Profiling [baseline] (148.523 ms) : 0, 148523
Profiling [candidate] (156.258 ms) : 0, 156258
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.581 s) : 0, 1581349
Total [baseline] (11.922 s) : 0, 11921517
Agent [candidate] (1.582 s) : 0, 1582232
Total [candidate] (11.95 s) : 0, 11949720
section iast
Agent [baseline] (1.707 s) : 0, 1706974
Total [baseline] (12.557 s) : 0, 12556886
Agent [candidate] (1.71 s) : 0, 1709502
Total [candidate] (12.552 s) : 0, 12552482
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.717 s) : 0, 1716552
Total [baseline] (12.526 s) : 0, 12525732
Agent [candidate] (1.713 s) : 0, 1713098
Total [candidate] (12.588 s) : 0, 12588302
section iast_TELEMETRY_OFF
Agent [baseline] (1.709 s) : 0, 1709003
Total [baseline] (12.52 s) : 0, 12520204
Agent [candidate] (1.706 s) : 0, 1706397
Total [candidate] (12.539 s) : 0, 12538691
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (987.46 ms) : 0, 987460
BytebuddyAgent [candidate] (986.869 ms) : 0, 986869
GlobalTracer [baseline] (450.842 ms) : 0, 450842
GlobalTracer [candidate] (451.624 ms) : 0, 451624
AppSec [baseline] (71.424 ms) : 0, 71424
AppSec [candidate] (72.004 ms) : 0, 72004
Logs Intake [baseline] (421.036 µs) : 0, 421
Logs Intake [candidate] (419.155 µs) : 0, 419
Remote Config [baseline] (893.885 µs) : 0, 894
Remote Config [candidate] (891.455 µs) : 0, 891
Telemetry [baseline] (9.803 ms) : 0, 9803
Telemetry [candidate] (9.753 ms) : 0, 9753
section iast
BytebuddyAgent [baseline] (1.146 s) : 0, 1145597
BytebuddyAgent [candidate] (1.147 s) : 0, 1147049
GlobalTracer [baseline] (431.758 ms) : 0, 431758
GlobalTracer [candidate] (432.53 ms) : 0, 432530
AppSec [baseline] (67.138 ms) : 0, 67138
AppSec [candidate] (66.331 ms) : 0, 66331
IAST [baseline] (31.634 ms) : 0, 31634
IAST [candidate] (33.478 ms) : 0, 33478
Logs Intake [baseline] (390.107 µs) : 0, 390
Logs Intake [candidate] (409.844 µs) : 0, 410
Remote Config [baseline] (762.44 µs) : 0, 762
Remote Config [candidate] (764.664 µs) : 0, 765
Telemetry [baseline] (9.998 ms) : 0, 9998
Telemetry [candidate] (9.122 ms) : 0, 9122
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.152 s) : 0, 1151525
BytebuddyAgent [candidate] (1.147 s) : 0, 1146776
GlobalTracer [baseline] (434.543 ms) : 0, 434543
GlobalTracer [candidate] (432.975 ms) : 0, 432975
AppSec [baseline] (67.302 ms) : 0, 67302
AppSec [candidate] (67.915 ms) : 0, 67915
IAST [baseline] (30.244 ms) : 0, 30244
IAST [candidate] (30.583 ms) : 0, 30583
Logs Intake [baseline] (404.263 µs) : 0, 404
Logs Intake [candidate] (391.808 µs) : 0, 392
Remote Config [baseline] (785.112 µs) : 0, 785
Remote Config [candidate] (739.399 µs) : 0, 739
Telemetry [baseline] (11.881 ms) : 0, 11881
Telemetry [candidate] (13.879 ms) : 0, 13879
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.144 s) : 0, 1144396
BytebuddyAgent [candidate] (1.147 s) : 0, 1147292
GlobalTracer [baseline] (434.033 ms) : 0, 434033
GlobalTracer [candidate] (431.849 ms) : 0, 431849
AppSec [baseline] (68.332 ms) : 0, 68332
AppSec [candidate] (67.78 ms) : 0, 67780
IAST [baseline] (31.324 ms) : 0, 31324
IAST [candidate] (28.526 ms) : 0, 28526
Logs Intake [baseline] (402.658 µs) : 0, 403
Logs Intake [candidate] (394.395 µs) : 0, 394
Remote Config [baseline] (775.366 µs) : 0, 775
Remote Config [candidate] (752.426 µs) : 0, 752
Telemetry [baseline] (9.925 ms) : 0, 9925
Telemetry [candidate] (9.924 ms) : 0, 9924
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.324 ms) : 1304, 1343
. : milestone, 1324,
appsec (1.728 ms) : 1704, 1753
. : milestone, 1728,
appsec_no_iast (1.704 ms) : 1680, 1728
. : milestone, 1704,
iast (1.501 ms) : 1477, 1526
. : milestone, 1501,
profiling (1.488 ms) : 1464, 1513
. : milestone, 1488,
tracing (1.462 ms) : 1438, 1486
. : milestone, 1462,
section candidate
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.711 ms) : 1687, 1736
. : milestone, 1711,
appsec_no_iast (1.707 ms) : 1682, 1732
. : milestone, 1707,
iast (1.466 ms) : 1443, 1489
. : milestone, 1466,
profiling (1.483 ms) : 1458, 1508
. : milestone, 1483,
tracing (1.459 ms) : 1434, 1484
. : milestone, 1459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (366.651 µs) : 347, 386
. : milestone, 367,
iast (481.651 µs) : 460, 503
. : milestone, 482,
iast_FULL (551.339 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (502.47 µs) : 481, 524
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (482.651 µs) : 461, 504
. : milestone, 483,
iast_INACTIVE (455.584 µs) : 434, 477
. : milestone, 456,
iast_TELEMETRY_OFF (472.001 µs) : 451, 493
. : milestone, 472,
tracing (443.98 µs) : 423, 465
. : milestone, 444,
section candidate
no_agent (363.865 µs) : 344, 383
. : milestone, 364,
iast (483.278 µs) : 462, 505
. : milestone, 483,
iast_FULL (551.863 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (504.906 µs) : 483, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (485.002 µs) : 463, 507
. : milestone, 485,
iast_INACTIVE (452.124 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (470.33 µs) : 449, 492
. : milestone, 470,
tracing (447.068 µs) : 426, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
. : milestone, 1460,
appsec (2.19 ms) : 2156, 2224
. : milestone, 2190,
iast (1.965 ms) : 1924, 2007
. : milestone, 1965,
iast_GLOBAL (1.997 ms) : 1957, 2038
. : milestone, 1997,
profiling (1.841 ms) : 1807, 1875
. : milestone, 1841,
tracing (1.829 ms) : 1797, 1861
. : milestone, 1829,
section candidate
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.198 ms) : 2163, 2232
. : milestone, 2198,
iast (1.957 ms) : 1917, 1998
. : milestone, 1957,
iast_GLOBAL (2.001 ms) : 1960, 2042
. : milestone, 2001,
profiling (1.854 ms) : 1821, 1887
. : milestone, 1854,
tracing (1.838 ms) : 1805, 1870
. : milestone, 1838,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~465d5218fc, baseline=1.36.0-SNAPSHOT~80850709c7
dateFormat X
axisFormat %s
section baseline
no_agent (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
appsec (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
iast (19.049 s) : 19049000, 19049000
. : milestone, 19049000,
iast_GLOBAL (17.954 s) : 17954000, 17954000
. : milestone, 17954000,
profiling (15.411 s) : 15411000, 15411000
. : milestone, 15411000,
tracing (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
section candidate
no_agent (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
appsec (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
iast (18.778 s) : 18778000, 18778000
. : milestone, 18778000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.411 s) : 15411000, 15411000
. : milestone, 15411000,
tracing (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
|
PerfectSlayer
approved these changes
Jun 13, 2024
amarziali
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7184 for v1.35.1