Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when kafka consumer info is not available #7190

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix NPE when kafka consumer info is not available #7190

merged 1 commit into from
Jun 14, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

The ConsumerCoordinatorInstrumentation is accessing kafka consumer info through the context store but does not checks for nullity

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: bug inst: kafka Kafka instrumentation labels Jun 14, 2024
@amarziali amarziali requested a review from a team as a code owner June 14, 2024 09:59
@pr-commenter
Copy link

pr-commenter bot commented Jun 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718359320 1718359064
git_commit_sha ca01312 a5d6b67
release_version 1.36.0-SNAPSHOT~ca01312252 1.36.0-SNAPSHOT~a5d6b6728b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718361919 1718361919
ci_job_id 543469504 543469504
ci_pipeline_id 36760632 36760632
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 14 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config worse
[+31.417µs; +75.138µs] or [+4.564%; +10.916%]		 741.593µs 688.316µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063541
Total [baseline] (8.654 s) : 0, 8654096
Agent [candidate] (1.072 s) : 0, 1072044
Total [candidate] (8.603 s) : 0, 8603108
section iast
Agent [baseline] (1.168 s) : 0, 1167815
Total [baseline] (8.981 s) : 0, 8981257
Agent [candidate] (1.17 s) : 0, 1169585
Total [candidate] (9.018 s) : 0, 9018146
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.167 s) : 0, 1166702
Total [baseline] (8.979 s) : 0, 8978685
Agent [candidate] (1.176 s) : 0, 1175910
Total [candidate] (9.015 s) : 0, 9014895
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1167342
Total [baseline] (9.003 s) : 0, 9003000
Agent [candidate] (1.164 s) : 0, 1163645
Total [candidate] (8.996 s) : 0, 8996369
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.168 s 104.274 ms (9.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.167 s 103.161 ms (9.7%)
Agent iast_TELEMETRY_OFF 1.167 s 103.801 ms (9.8%)
Total tracing 8.654 s -
Total iast 8.981 s 327.161 ms (3.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.979 s 324.589 ms (3.8%)
Total iast_TELEMETRY_OFF 9.003 s 348.904 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.17 s 97.541 ms (9.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 103.866 ms (9.7%)
Agent iast_TELEMETRY_OFF 1.164 s 91.601 ms (8.5%)
Total tracing 8.603 s -
Total iast 9.018 s 415.038 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.015 s 411.787 ms (4.8%)
Total iast_TELEMETRY_OFF 8.996 s 393.261 ms (4.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.393 ms) : 0, 665393
BytebuddyAgent [candidate] (671.642 ms) : 0, 671642
GlobalTracer [baseline] (304.68 ms) : 0, 304680
GlobalTracer [candidate] (306.562 ms) : 0, 306562
AppSec [baseline] (50.442 ms) : 0, 50442
AppSec [candidate] (50.471 ms) : 0, 50471
Logs Intake [baseline] (335.189 µs) : 0, 335
Logs Intake [candidate] (408.794 µs) : 0, 409
Remote Config [baseline] (681.114 µs) : 0, 681
Remote Config [candidate] (669.902 µs) : 0, 670
Telemetry [baseline] (7.601 ms) : 0, 7601
Telemetry [candidate] (7.59 ms) : 0, 7590
section iast
BytebuddyAgent [baseline] (778.156 ms) : 0, 778156
BytebuddyAgent [candidate] (780.152 ms) : 0, 780152
GlobalTracer [baseline] (293.036 ms) : 0, 293036
GlobalTracer [candidate] (294.077 ms) : 0, 294077
AppSec [baseline] (47.186 ms) : 0, 47186
AppSec [candidate] (47.151 ms) : 0, 47151
IAST [baseline] (27.722 ms) : 0, 27722
IAST [candidate] (25.532 ms) : 0, 25532
Logs Intake [baseline] (298.101 µs) : 0, 298
Logs Intake [candidate] (298.525 µs) : 0, 299
Remote Config [baseline] (560.71 µs) : 0, 561
Remote Config [candidate] (561.29 µs) : 0, 561
Telemetry [baseline] (7.561 ms) : 0, 7561
Telemetry [candidate] (8.467 ms) : 0, 8467
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.223 ms) : 0, 778223
BytebuddyAgent [candidate] (784.708 ms) : 0, 784708
GlobalTracer [baseline] (293.351 ms) : 0, 293351
GlobalTracer [candidate] (295.287 ms) : 0, 295287
AppSec [baseline] (46.942 ms) : 0, 46942
AppSec [candidate] (46.682 ms) : 0, 46682
IAST [baseline] (26.322 ms) : 0, 26322
IAST [candidate] (27.943 ms) : 0, 27943
Logs Intake [baseline] (301.87 µs) : 0, 302
Logs Intake [candidate] (303.08 µs) : 0, 303
Remote Config [baseline] (562.938 µs) : 0, 563
Remote Config [candidate] (578.339 µs) : 0, 578
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (6.969 ms) : 0, 6969
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.843 ms) : 0, 777843
BytebuddyAgent [candidate] (774.947 ms) : 0, 774947
GlobalTracer [baseline] (294.351 ms) : 0, 294351
GlobalTracer [candidate] (293.764 ms) : 0, 293764
AppSec [baseline] (50.298 ms) : 0, 50298
AppSec [candidate] (47.296 ms) : 0, 47296
IAST [baseline] (22.396 ms) : 0, 22396
IAST [candidate] (25.215 ms) : 0, 25215
Logs Intake [baseline] (291.9 µs) : 0, 292
Logs Intake [candidate] (301.232 µs) : 0, 301
Remote Config [baseline] (552.542 µs) : 0, 553
Remote Config [candidate] (571.086 µs) : 0, 571
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.244 ms) : 0, 8244
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061420
Total [baseline] (10.422 s) : 0, 10422333
Agent [candidate] (1.063 s) : 0, 1063341
Total [candidate] (10.388 s) : 0, 10387554
section appsec
Agent [baseline] (1.183 s) : 0, 1182678
Total [baseline] (10.465 s) : 0, 10465191
Agent [candidate] (1.18 s) : 0, 1180222
Total [candidate] (10.487 s) : 0, 10487403
section iast
Agent [baseline] (1.17 s) : 0, 1170436
Total [baseline] (10.688 s) : 0, 10688260
Agent [candidate] (1.17 s) : 0, 1170232
Total [candidate] (10.765 s) : 0, 10764901
section profiling
Agent [baseline] (1.262 s) : 0, 1262498
Total [baseline] (10.707 s) : 0, 10707344
Agent [candidate] (1.264 s) : 0, 1264288
Total [candidate] (10.738 s) : 0, 10737613
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.183 s 121.258 ms (11.4%)
Agent iast 1.17 s 109.016 ms (10.3%)
Agent profiling 1.262 s 201.078 ms (18.9%)
Total tracing 10.422 s -
Total appsec 10.465 s 42.858 ms (0.4%)
Total iast 10.688 s 265.927 ms (2.6%)
Total profiling 10.707 s 285.011 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.18 s 116.88 ms (11.0%)
Agent iast 1.17 s 106.891 ms (10.1%)
Agent profiling 1.264 s 200.947 ms (18.9%)
Total tracing 10.388 s -
Total appsec 10.487 s 99.85 ms (1.0%)
Total iast 10.765 s 377.348 ms (3.6%)
Total profiling 10.738 s 350.06 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.813 ms) : 0, 664813
BytebuddyAgent [candidate] (665.486 ms) : 0, 665486
GlobalTracer [baseline] (303.51 ms) : 0, 303510
GlobalTracer [candidate] (304.525 ms) : 0, 304525
AppSec [baseline] (50.279 ms) : 0, 50279
AppSec [candidate] (50.26 ms) : 0, 50260
Logs Intake [baseline] (330.415 µs) : 0, 330
Logs Intake [candidate] (418.007 µs) : 0, 418
Remote Config [baseline] (676.957 µs) : 0, 677
Remote Config [candidate] (663.202 µs) : 0, 663
Telemetry [baseline] (7.574 ms) : 0, 7574
Telemetry [candidate] (7.555 ms) : 0, 7555
section appsec
BytebuddyAgent [baseline] (677.271 ms) : 0, 677271
BytebuddyAgent [candidate] (675.182 ms) : 0, 675182
GlobalTracer [baseline] (297.734 ms) : 0, 297734
GlobalTracer [candidate] (296.882 ms) : 0, 296882
AppSec [baseline] (153.272 ms) : 0, 153272
AppSec [candidate] (152.852 ms) : 0, 152852
IAST [baseline] (21.126 ms) : 0, 21126
IAST [candidate] (21.102 ms) : 0, 21102
Logs Intake [baseline] (336.919 µs) : 0, 337
Logs Intake [candidate] (329.795 µs) : 0, 330
Remote Config [baseline] (636.366 µs) : 0, 636
Remote Config [candidate] (640.714 µs) : 0, 641
Telemetry [baseline] (8.438 ms) : 0, 8438
Telemetry [candidate] (9.455 ms) : 0, 9455
section iast
BytebuddyAgent [baseline] (779.78 ms) : 0, 779780
BytebuddyAgent [candidate] (781.364 ms) : 0, 781364
GlobalTracer [baseline] (293.485 ms) : 0, 293485
GlobalTracer [candidate] (293.76 ms) : 0, 293760
AppSec [baseline] (47.168 ms) : 0, 47168
AppSec [candidate] (47.041 ms) : 0, 47041
IAST [baseline] (26.621 ms) : 0, 26621
IAST [candidate] (24.674 ms) : 0, 24674
Logs Intake [baseline] (302.233 µs) : 0, 302
Logs Intake [candidate] (303.452 µs) : 0, 303
Remote Config [baseline] (569.049 µs) : 0, 569
Remote Config [candidate] (574.976 µs) : 0, 575
Telemetry [baseline] (9.25 ms) : 0, 9250
Telemetry [candidate] (9.225 ms) : 0, 9225
section profiling
BytebuddyAgent [baseline] (663.437 ms) : 0, 663437
BytebuddyAgent [candidate] (663.633 ms) : 0, 663633
GlobalTracer [baseline] (386.448 ms) : 0, 386448
GlobalTracer [candidate] (386.728 ms) : 0, 386728
AppSec [baseline] (51.077 ms) : 0, 51077
AppSec [candidate] (50.637 ms) : 0, 50637
Logs Intake [baseline] (330.528 µs) : 0, 331
Logs Intake [candidate] (336.43 µs) : 0, 336
Remote Config [baseline] (688.316 µs) : 0, 688
Remote Config [candidate] (741.593 µs) : 0, 742
Telemetry [baseline] (7.324 ms) : 0, 7324
Telemetry [candidate] (7.423 ms) : 0, 7423
ProfilingAgent [baseline] (96.117 ms) : 0, 96117
ProfilingAgent [candidate] (97.721 ms) : 0, 97721
Profiling [baseline] (96.142 ms) : 0, 96142
Profiling [candidate] (97.747 ms) : 0, 97747
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-14T10:16:02 2024-06-14T10:22:51
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718359320 1718359064
git_commit_sha ca01312 a5d6b67
release_version 1.36.0-SNAPSHOT~ca01312252 1.36.0-SNAPSHOT~a5d6b6728b
start_time 2024-06-14T10:15:49 2024-06-14T10:22:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718360916 1718360916
ci_job_id 543469505 543469505
ci_pipeline_id 36760632 36760632
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.227 µs) : 351, 392
.   : milestone, 371,
iast (481.682 µs) : 460, 503
.   : milestone, 482,
iast_FULL (555.957 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (512.395 µs) : 490, 535
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (476.109 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (445.533 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (467.416 µs) : 446, 489
.   : milestone, 467,
tracing (442.53 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (373.16 µs) : 353, 393
.   : milestone, 373,
iast (479.445 µs) : 458, 501
.   : milestone, 479,
iast_FULL (559.245 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (509.1 µs) : 486, 532
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (482.257 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (453.709 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (467.32 µs) : 446, 489
.   : milestone, 467,
tracing (432.698 µs) : 413, 453
.   : milestone, 433,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.227 µs [350.512 µs, 391.942 µs] -
iast 481.682 µs [460.112 µs, 503.251 µs] 110.455 µs (29.8%)
iast_FULL 555.957 µs [534.661 µs, 577.253 µs] 184.73 µs (49.8%)
iast_GLOBAL 512.395 µs [489.784 µs, 535.005 µs] 141.167 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 476.109 µs [455.211 µs, 497.006 µs] 104.881 µs (28.3%)
iast_INACTIVE 445.533 µs [424.813 µs, 466.253 µs] 74.306 µs (20.0%)
iast_TELEMETRY_OFF 467.416 µs [446.081 µs, 488.751 µs] 96.189 µs (25.9%)
tracing 442.53 µs [421.843 µs, 463.217 µs] 71.303 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.16 µs [353.003 µs, 393.318 µs] -
iast 479.445 µs [458.141 µs, 500.749 µs] 106.285 µs (28.5%)
iast_FULL 559.245 µs [538.151 µs, 580.339 µs] 186.085 µs (49.9%)
iast_GLOBAL 509.1 µs [486.467 µs, 531.734 µs] 135.94 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 482.257 µs [460.79 µs, 503.724 µs] 109.097 µs (29.2%)
iast_INACTIVE 453.709 µs [432.274 µs, 475.143 µs] 80.549 µs (21.6%)
iast_TELEMETRY_OFF 467.32 µs [446.092 µs, 488.548 µs] 94.16 µs (25.2%)
tracing 432.698 µs [412.764 µs, 452.632 µs] 59.538 µs (16.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.733 ms) : 1710, 1757
.   : milestone, 1733,
appsec_no_iast (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.483 ms) : 1458, 1507
.   : milestone, 1483,
profiling (1.507 ms) : 1481, 1533
.   : milestone, 1507,
tracing (1.483 ms) : 1459, 1506
.   : milestone, 1483,
section candidate
no_agent (1.342 ms) : 1322, 1362
.   : milestone, 1342,
appsec (1.711 ms) : 1687, 1736
.   : milestone, 1711,
appsec_no_iast (1.721 ms) : 1697, 1746
.   : milestone, 1721,
iast (1.462 ms) : 1437, 1486
.   : milestone, 1462,
profiling (1.497 ms) : 1474, 1520
.   : milestone, 1497,
tracing (1.487 ms) : 1463, 1512
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.733 ms [1.71 ms, 1.757 ms] 390.029 µs (29.0%)
appsec_no_iast 1.715 ms [1.69 ms, 1.74 ms] 371.887 µs (27.7%)
iast 1.483 ms [1.458 ms, 1.507 ms] 139.118 µs (10.4%)
profiling 1.507 ms [1.481 ms, 1.533 ms] 163.678 µs (12.2%)
tracing 1.483 ms [1.459 ms, 1.506 ms] 139.511 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.322 ms, 1.362 ms] -
appsec 1.711 ms [1.687 ms, 1.736 ms] 368.924 µs (27.5%)
appsec_no_iast 1.721 ms [1.697 ms, 1.746 ms] 378.947 µs (28.2%)
iast 1.462 ms [1.437 ms, 1.486 ms] 119.341 µs (8.9%)
profiling 1.497 ms [1.474 ms, 1.52 ms] 154.704 µs (11.5%)
tracing 1.487 ms [1.463 ms, 1.512 ms] 145.163 µs (10.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718359320 1718359064
git_commit_sha ca01312 a5d6b67
release_version 1.36.0-SNAPSHOT~ca01312252 1.36.0-SNAPSHOT~a5d6b6728b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718361536 1718361536
ci_job_id 543469506 543469506
ci_pipeline_id 36760632 36760632
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.038 s) : 15038000, 15038000
.   : milestone, 15038000,
appsec (15.366 s) : 15366000, 15366000
.   : milestone, 15366000,
iast (18.812 s) : 18812000, 18812000
.   : milestone, 18812000,
iast_GLOBAL (17.742 s) : 17742000, 17742000
.   : milestone, 17742000,
profiling (15.446 s) : 15446000, 15446000
.   : milestone, 15446000,
tracing (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
section candidate
no_agent (15.5 s) : 15500000, 15500000
.   : milestone, 15500000,
appsec (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
iast (18.548 s) : 18548000, 18548000
.   : milestone, 18548000,
iast_GLOBAL (18.108 s) : 18108000, 18108000
.   : milestone, 18108000,
profiling (15.387 s) : 15387000, 15387000
.   : milestone, 15387000,
tracing (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.038 s [15.038 s, 15.038 s] -
appsec 15.366 s [15.366 s, 15.366 s] 328.0 ms (2.2%)
iast 18.812 s [18.812 s, 18.812 s] 3.774 s (25.1%)
iast_GLOBAL 17.742 s [17.742 s, 17.742 s] 2.704 s (18.0%)
profiling 15.446 s [15.446 s, 15.446 s] 408.0 ms (2.7%)
tracing 14.988 s [14.988 s, 14.988 s] -50.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.5 s [15.5 s, 15.5 s] -
appsec 14.988 s [14.988 s, 14.988 s] -512.0 ms (-3.3%)
iast 18.548 s [18.548 s, 18.548 s] 3.048 s (19.7%)
iast_GLOBAL 18.108 s [18.108 s, 18.108 s] 2.608 s (16.8%)
profiling 15.387 s [15.387 s, 15.387 s] -113.0 ms (-0.7%)
tracing 15.152 s [15.152 s, 15.152 s] -348.0 ms (-2.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~a5d6b6728b, baseline=1.36.0-SNAPSHOT~ca01312252
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.209 ms) : 2174, 2243
.   : milestone, 2209,
iast (1.973 ms) : 1931, 2014
.   : milestone, 1973,
iast_GLOBAL (2.023 ms) : 1981, 2065
.   : milestone, 2023,
profiling (1.848 ms) : 1815, 1881
.   : milestone, 1848,
tracing (1.822 ms) : 1790, 1854
.   : milestone, 1822,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.207 ms) : 2174, 2241
.   : milestone, 2207,
iast (1.977 ms) : 1935, 2018
.   : milestone, 1977,
iast_GLOBAL (1.999 ms) : 1958, 2039
.   : milestone, 1999,
profiling (1.853 ms) : 1818, 1888
.   : milestone, 1853,
tracing (1.826 ms) : 1795, 1857
.   : milestone, 1826,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.209 ms [2.174 ms, 2.243 ms] 750.113 µs (51.4%)
iast 1.973 ms [1.931 ms, 2.014 ms] 514.28 µs (35.3%)
iast_GLOBAL 2.023 ms [1.981 ms, 2.065 ms] 564.454 µs (38.7%)
profiling 1.848 ms [1.815 ms, 1.881 ms] 389.617 µs (26.7%)
tracing 1.822 ms [1.79 ms, 1.854 ms] 363.445 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.207 ms [2.174 ms, 2.241 ms] 749.66 µs (51.4%)
iast 1.977 ms [1.935 ms, 2.018 ms] 519.218 µs (35.6%)
iast_GLOBAL 1.999 ms [1.958 ms, 2.039 ms] 541.215 µs (37.1%)
profiling 1.853 ms [1.818 ms, 1.888 ms] 395.19 µs (27.1%)
tracing 1.826 ms [1.795 ms, 1.857 ms] 368.462 µs (25.3%)

@amarziali amarziali merged commit f5b82e6 into master Jun 14, 2024
83 of 85 checks passed
@amarziali amarziali deleted the andrea.marziali/kafka-npe branch June 14, 2024 11:03
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 14, 2024
@amarziali amarziali modified the milestones: 1.35.1, 1.36.0 Jun 14, 2024
@amarziali amarziali mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
inst: kafka Kafka instrumentation type: bug
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amarziali @PerfectSlayer