Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude method handles exceptions from telemetry logs #7208

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Exclude method handles exceptions from telemetry logs #7208

merged 1 commit into from
Jun 17, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 17, 2024 •
edited by jira bot
Loading

What Does This Do

Adds LogCollector.EXCLUDE_TELEMETRY marker to logs in MethodHandles class.
As the result, these logs will not be reported to telemetry.

Motivation

By default every log that contains a throwable is reported to telemetry regardless of its log level.

The MethodHandles class contains some debug logs that log errors that are expected to occur in some envs, depending on dependency versions that the traced app is using (example: in one version of a testing framework there is a field named "a", while in a later version of the same framework the same field is named "b" - attempting to get one of these will always fail and it will not be an error, which is why it is logged with debug level).
These logs are there only in case a specific issue needs to be investigated, they are not needed in telemetry.

Jira ticket: SDTEST-461

@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/ci-vis-telemetry-ignores
git_commit_date 1718625530 1718626800
git_commit_sha a19c6d5 44c8c2a
release_version 1.36.0-SNAPSHOT~a19c6d5486 1.36.0-SNAPSHOT~44c8c2a5fa
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718630028 1718630028
ci_job_id 545024961 545024961
ci_pipeline_id 36884203 36884203
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063988
Total [baseline] (10.428 s) : 0, 10427851
Agent [candidate] (1.064 s) : 0, 1064190
Total [candidate] (10.336 s) : 0, 10336188
section appsec
Agent [baseline] (1.186 s) : 0, 1185574
Total [baseline] (10.472 s) : 0, 10471705
Agent [candidate] (1.186 s) : 0, 1185987
Total [candidate] (10.534 s) : 0, 10534080
section iast
Agent [baseline] (1.168 s) : 0, 1167874
Total [baseline] (10.694 s) : 0, 10693584
Agent [candidate] (1.179 s) : 0, 1178884
Total [candidate] (10.815 s) : 0, 10814588
section profiling
Agent [baseline] (1.266 s) : 0, 1265575
Total [baseline] (10.689 s) : 0, 10689110
Agent [candidate] (1.273 s) : 0, 1272634
Total [candidate] (10.702 s) : 0, 10701722
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.186 s 121.586 ms (11.4%)
Agent iast 1.168 s 103.886 ms (9.8%)
Agent profiling 1.266 s 201.587 ms (18.9%)
Total tracing 10.428 s -
Total appsec 10.472 s 43.854 ms (0.4%)
Total iast 10.694 s 265.732 ms (2.5%)
Total profiling 10.689 s 261.259 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.186 s 121.797 ms (11.4%)
Agent iast 1.179 s 114.694 ms (10.8%)
Agent profiling 1.273 s 208.444 ms (19.6%)
Total tracing 10.336 s -
Total appsec 10.534 s 197.891 ms (1.9%)
Total iast 10.815 s 478.4 ms (4.6%)
Total profiling 10.702 s 365.533 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.415 ms) : 0, 666415
BytebuddyAgent [candidate] (666.678 ms) : 0, 666678
GlobalTracer [baseline] (304.329 ms) : 0, 304329
GlobalTracer [candidate] (304.509 ms) : 0, 304509
AppSec [baseline] (50.395 ms) : 0, 50395
AppSec [candidate] (50.17 ms) : 0, 50170
Remote Config [baseline] (688.911 µs) : 0, 689
Remote Config [candidate] (685.402 µs) : 0, 685
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.607 ms) : 0, 7607
section appsec
BytebuddyAgent [baseline] (677.445 ms) : 0, 677445
BytebuddyAgent [candidate] (678.584 ms) : 0, 678584
GlobalTracer [baseline] (297.836 ms) : 0, 297836
GlobalTracer [candidate] (298.51 ms) : 0, 298510
AppSec [baseline] (154.558 ms) : 0, 154558
AppSec [candidate] (154.459 ms) : 0, 154459
IAST [baseline] (23.019 ms) : 0, 23019
IAST [candidate] (20.942 ms) : 0, 20942
Remote Config [baseline] (640.953 µs) : 0, 641
Remote Config [candidate] (644.599 µs) : 0, 645
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (8.763 ms) : 0, 8763
section iast
BytebuddyAgent [baseline] (779.181 ms) : 0, 779181
BytebuddyAgent [candidate] (785.602 ms) : 0, 785602
GlobalTracer [baseline] (293.496 ms) : 0, 293496
GlobalTracer [candidate] (295.709 ms) : 0, 295709
AppSec [baseline] (47.077 ms) : 0, 47077
AppSec [candidate] (47.41 ms) : 0, 47410
IAST [baseline] (27.357 ms) : 0, 27357
IAST [candidate] (29.166 ms) : 0, 29166
Remote Config [baseline] (613.504 µs) : 0, 614
Remote Config [candidate] (649.233 µs) : 0, 649
Telemetry [baseline] (6.88 ms) : 0, 6880
Telemetry [candidate] (6.946 ms) : 0, 6946
section profiling
BytebuddyAgent [baseline] (665.099 ms) : 0, 665099
BytebuddyAgent [candidate] (668.453 ms) : 0, 668453
GlobalTracer [baseline] (387.126 ms) : 0, 387126
GlobalTracer [candidate] (389.104 ms) : 0, 389104
AppSec [baseline] (51.466 ms) : 0, 51466
AppSec [candidate] (52.226 ms) : 0, 52226
Remote Config [baseline] (743.391 µs) : 0, 743
Remote Config [candidate] (747.686 µs) : 0, 748
Telemetry [baseline] (7.419 ms) : 0, 7419
Telemetry [candidate] (7.494 ms) : 0, 7494
ProfilingAgent [baseline] (96.719 ms) : 0, 96719
ProfilingAgent [candidate] (97.118 ms) : 0, 97118
Profiling [baseline] (96.744 ms) : 0, 96744
Profiling [candidate] (97.144 ms) : 0, 97144
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069391
Total [baseline] (8.549 s) : 0, 8548776
Agent [candidate] (1.062 s) : 0, 1062452
Total [candidate] (8.555 s) : 0, 8555471
section iast
Agent [baseline] (1.167 s) : 0, 1166654
Total [baseline] (9.021 s) : 0, 9021324
Agent [candidate] (1.177 s) : 0, 1177095
Total [candidate] (9.007 s) : 0, 9007081
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179707
Total [baseline] (9.036 s) : 0, 9036427
Agent [candidate] (1.172 s) : 0, 1171543
Total [candidate] (9.061 s) : 0, 9061060
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1166425
Total [baseline] (9.027 s) : 0, 9027139
Agent [candidate] (1.167 s) : 0, 1166743
Total [candidate] (9.008 s) : 0, 9007606
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.167 s 97.263 ms (9.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.18 s 110.315 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.166 s 97.033 ms (9.1%)
Total tracing 8.549 s -
Total iast 9.021 s 472.547 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.036 s 487.651 ms (5.7%)
Total iast_TELEMETRY_OFF 9.027 s 478.362 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.177 s 114.644 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 109.092 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.167 s 104.291 ms (9.8%)
Total tracing 8.555 s -
Total iast 9.007 s 451.61 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.061 s 505.589 ms (5.9%)
Total iast_TELEMETRY_OFF 9.008 s 452.135 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.034 ms) : 0, 670034
BytebuddyAgent [candidate] (665.296 ms) : 0, 665296
GlobalTracer [baseline] (305.799 ms) : 0, 305799
GlobalTracer [candidate] (304.237 ms) : 0, 304237
AppSec [baseline] (50.662 ms) : 0, 50662
AppSec [candidate] (50.275 ms) : 0, 50275
Remote Config [baseline] (693.366 µs) : 0, 693
Remote Config [candidate] (689.264 µs) : 0, 689
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (7.596 ms) : 0, 7596
section iast
BytebuddyAgent [baseline] (778.993 ms) : 0, 778993
BytebuddyAgent [candidate] (785.675 ms) : 0, 785675
GlobalTracer [baseline] (293.339 ms) : 0, 293339
GlobalTracer [candidate] (295.279 ms) : 0, 295279
AppSec [baseline] (47.067 ms) : 0, 47067
AppSec [candidate] (47.476 ms) : 0, 47476
IAST [baseline] (26.501 ms) : 0, 26501
IAST [candidate] (26.044 ms) : 0, 26044
Remote Config [baseline] (586.04 µs) : 0, 586
Remote Config [candidate] (659.412 µs) : 0, 659
Telemetry [baseline] (6.926 ms) : 0, 6926
Telemetry [candidate] (8.594 ms) : 0, 8594
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.181 ms) : 0, 786181
BytebuddyAgent [candidate] (780.78 ms) : 0, 780780
GlobalTracer [baseline] (296.551 ms) : 0, 296551
GlobalTracer [candidate] (293.492 ms) : 0, 293492
AppSec [baseline] (47.668 ms) : 0, 47668
AppSec [candidate] (47.28 ms) : 0, 47280
IAST [baseline] (28.191 ms) : 0, 28191
IAST [candidate] (29.093 ms) : 0, 29093
Remote Config [baseline] (656.024 µs) : 0, 656
Remote Config [candidate] (620.265 µs) : 0, 620
Telemetry [baseline] (7.034 ms) : 0, 7034
Telemetry [candidate] (6.939 ms) : 0, 6939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.845 ms) : 0, 777845
BytebuddyAgent [candidate] (776.82 ms) : 0, 776820
GlobalTracer [baseline] (294.166 ms) : 0, 294166
GlobalTracer [candidate] (294.173 ms) : 0, 294173
AppSec [baseline] (47.151 ms) : 0, 47151
AppSec [candidate] (47.147 ms) : 0, 47147
IAST [baseline] (24.951 ms) : 0, 24951
IAST [candidate] (26.3 ms) : 0, 26300
Remote Config [baseline] (580.288 µs) : 0, 580
Remote Config [candidate] (598.639 µs) : 0, 599
Telemetry [baseline] (8.393 ms) : 0, 8393
Telemetry [candidate] (8.371 ms) : 0, 8371
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-17T12:44:37 2024-06-17T12:51:27
git_branch master nikita-tkachenko/ci-vis-telemetry-ignores
git_commit_date 1718625530 1718626800
git_commit_sha a19c6d5 44c8c2a
release_version 1.36.0-SNAPSHOT~a19c6d5486 1.36.0-SNAPSHOT~44c8c2a5fa
start_time 2024-06-17T12:44:24 2024-06-17T12:51:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718629033 1718629033
ci_job_id 545024962 545024962
ci_pipeline_id 36884203 36884203
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.748 ms) : 1724, 1771
.   : milestone, 1748,
appsec_no_iast (1.718 ms) : 1693, 1743
.   : milestone, 1718,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.479 ms) : 1454, 1504
.   : milestone, 1479,
tracing (1.47 ms) : 1446, 1493
.   : milestone, 1470,
section candidate
no_agent (1.331 ms) : 1312, 1350
.   : milestone, 1331,
appsec (1.746 ms) : 1723, 1770
.   : milestone, 1746,
appsec_no_iast (1.738 ms) : 1714, 1763
.   : milestone, 1738,
iast (1.484 ms) : 1461, 1507
.   : milestone, 1484,
profiling (1.477 ms) : 1453, 1502
.   : milestone, 1477,
tracing (1.46 ms) : 1436, 1485
.   : milestone, 1460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.748 ms [1.724 ms, 1.771 ms] 396.384 µs (29.3%)
appsec_no_iast 1.718 ms [1.693 ms, 1.743 ms] 366.968 µs (27.2%)
iast 1.475 ms [1.453 ms, 1.498 ms] 124.158 µs (9.2%)
profiling 1.479 ms [1.454 ms, 1.504 ms] 127.752 µs (9.5%)
tracing 1.47 ms [1.446 ms, 1.493 ms] 118.532 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.312 ms, 1.35 ms] -
appsec 1.746 ms [1.723 ms, 1.77 ms] 415.123 µs (31.2%)
appsec_no_iast 1.738 ms [1.714 ms, 1.763 ms] 407.179 µs (30.6%)
iast 1.484 ms [1.461 ms, 1.507 ms] 152.783 µs (11.5%)
profiling 1.477 ms [1.453 ms, 1.502 ms] 145.959 µs (11.0%)
tracing 1.46 ms [1.436 ms, 1.485 ms] 129.187 µs (9.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.066 µs) : 351, 393
.   : milestone, 372,
iast (492.036 µs) : 470, 514
.   : milestone, 492,
iast_FULL (554.373 µs) : 533, 576
.   : milestone, 554,
iast_GLOBAL (508.663 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (489.252 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (461.766 µs) : 440, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (481.271 µs) : 459, 503
.   : milestone, 481,
tracing (448.992 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (372.98 µs) : 353, 392
.   : milestone, 373,
iast (489.975 µs) : 469, 511
.   : milestone, 490,
iast_FULL (555.121 µs) : 532, 578
.   : milestone, 555,
iast_GLOBAL (519.481 µs) : 496, 543
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (490.763 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (460.895 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (479.851 µs) : 458, 502
.   : milestone, 480,
tracing (446.616 µs) : 426, 467
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.066 µs [351.212 µs, 392.919 µs] -
iast 492.036 µs [470.304 µs, 513.768 µs] 119.97 µs (32.2%)
iast_FULL 554.373 µs [533.137 µs, 575.609 µs] 182.308 µs (49.0%)
iast_GLOBAL 508.663 µs [487.811 µs, 529.514 µs] 136.597 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 489.252 µs [467.942 µs, 510.563 µs] 117.187 µs (31.5%)
iast_INACTIVE 461.766 µs [439.84 µs, 483.691 µs] 89.7 µs (24.1%)
iast_TELEMETRY_OFF 481.271 µs [459.447 µs, 503.094 µs] 109.205 µs (29.4%)
tracing 448.992 µs [428.453 µs, 469.53 µs] 76.926 µs (20.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.98 µs [353.462 µs, 392.497 µs] -
iast 489.975 µs [468.596 µs, 511.354 µs] 116.995 µs (31.4%)
iast_FULL 555.121 µs [532.41 µs, 577.833 µs] 182.142 µs (48.8%)
iast_GLOBAL 519.481 µs [496.054 µs, 542.908 µs] 146.502 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED 490.763 µs [469.25 µs, 512.277 µs] 117.784 µs (31.6%)
iast_INACTIVE 460.895 µs [439.055 µs, 482.736 µs] 87.916 µs (23.6%)
iast_TELEMETRY_OFF 479.851 µs [458.117 µs, 501.585 µs] 106.871 µs (28.7%)
tracing 446.616 µs [425.839 µs, 467.394 µs] 73.637 µs (19.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/ci-vis-telemetry-ignores
git_commit_date 1718625530 1718626800
git_commit_sha a19c6d5 44c8c2a
release_version 1.36.0-SNAPSHOT~a19c6d5486 1.36.0-SNAPSHOT~44c8c2a5fa
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718629639 1718629639
ci_job_id 545024963 545024963
ci_pipeline_id 36884203 36884203
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.217 ms) : 2183, 2251
.   : milestone, 2217,
iast (1.969 ms) : 1927, 2010
.   : milestone, 1969,
iast_GLOBAL (2.016 ms) : 1974, 2058
.   : milestone, 2016,
profiling (1.85 ms) : 1815, 1884
.   : milestone, 1850,
tracing (1.834 ms) : 1802, 1866
.   : milestone, 1834,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.194 ms) : 2161, 2228
.   : milestone, 2194,
iast (1.971 ms) : 1930, 2013
.   : milestone, 1971,
iast_GLOBAL (2.005 ms) : 1964, 2046
.   : milestone, 2005,
profiling (1.857 ms) : 1822, 1891
.   : milestone, 1857,
tracing (1.838 ms) : 1805, 1870
.   : milestone, 1838,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.217 ms [2.183 ms, 2.251 ms] 751.613 µs (51.3%)
iast 1.969 ms [1.927 ms, 2.01 ms] 503.619 µs (34.4%)
iast_GLOBAL 2.016 ms [1.974 ms, 2.058 ms] 550.643 µs (37.6%)
profiling 1.85 ms [1.815 ms, 1.884 ms] 384.213 µs (26.2%)
tracing 1.834 ms [1.802 ms, 1.866 ms] 368.481 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.194 ms [2.161 ms, 2.228 ms] 731.788 µs (50.0%)
iast 1.971 ms [1.93 ms, 2.013 ms] 508.756 µs (34.8%)
iast_GLOBAL 2.005 ms [1.964 ms, 2.046 ms] 542.807 µs (37.1%)
profiling 1.857 ms [1.822 ms, 1.891 ms] 394.142 µs (27.0%)
tracing 1.838 ms [1.805 ms, 1.87 ms] 375.428 µs (25.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~44c8c2a5fa, baseline=1.36.0-SNAPSHOT~a19c6d5486
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.344 s) : 15344000, 15344000
.   : milestone, 15344000,
appsec (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
iast (18.651 s) : 18651000, 18651000
.   : milestone, 18651000,
iast_GLOBAL (17.795 s) : 17795000, 17795000
.   : milestone, 17795000,
profiling (15.196 s) : 15196000, 15196000
.   : milestone, 15196000,
tracing (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
appsec (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
iast (18.912 s) : 18912000, 18912000
.   : milestone, 18912000,
iast_GLOBAL (18.081 s) : 18081000, 18081000
.   : milestone, 18081000,
profiling (14.973 s) : 14973000, 14973000
.   : milestone, 14973000,
tracing (14.913 s) : 14913000, 14913000
.   : milestone, 14913000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.344 s [15.344 s, 15.344 s] -
appsec 15.076 s [15.076 s, 15.076 s] -268.0 ms (-1.7%)
iast 18.651 s [18.651 s, 18.651 s] 3.307 s (21.6%)
iast_GLOBAL 17.795 s [17.795 s, 17.795 s] 2.451 s (16.0%)
profiling 15.196 s [15.196 s, 15.196 s] -148.0 ms (-1.0%)
tracing 15.017 s [15.017 s, 15.017 s] -327.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.015 s [15.015 s, 15.015 s] -
appsec 15.21 s [15.21 s, 15.21 s] 195.0 ms (1.3%)
iast 18.912 s [18.912 s, 18.912 s] 3.897 s (26.0%)
iast_GLOBAL 18.081 s [18.081 s, 18.081 s] 3.066 s (20.4%)
profiling 14.973 s [14.973 s, 14.973 s] -42.0 ms (-0.3%)
tracing 14.913 s [14.913 s, 14.913 s] -102.0 ms (-0.7%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog added comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes labels Jun 17, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 17, 2024 13:33
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 17, 2024 13:33
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 5cf2f32 into master Jun 17, 2024
83 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/ci-vis-telemetry-ignores branch June 17, 2024 13:34
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 17, 2024
@mcculls mcculls modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikita-tkachenko-datadog @romainkomorndatadog @mcculls