Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing RFC parts for user event tacking #7213

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Update missing RFC parts for user event tacking #7213

merged 1 commit into from
Jun 25, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

What Does This Do

Updates support of user event tracking to support all functionality from the RFC, specially:

  • Use lower case values for the modes included in the spans
  • Allow to send user ids when alphanumeric/uuid in the safe mode.

Motivation

Additional Notes

RFC

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label Jun 18, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-user-events-system-test branch from bb7a2f4 to b74fdbf Compare June 18, 2024 14:14
@pr-commenter
Copy link

pr-commenter bot commented Jun 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-user-events-system-test
git_commit_date 1719240462 1719302354
git_commit_sha 2d36ca7 b9fdde2
release_version 1.36.0-SNAPSHOT~2d36ca7c31 1.36.0-SNAPSHOT~b9fdde2ef0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719305550 1719305550
ci_job_id 552330608 552330608
ci_pipeline_id 37480417 37480417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074039
Total [baseline] (10.399 s) : 0, 10398621
Agent [candidate] (1.07 s) : 0, 1070083
Total [candidate] (10.42 s) : 0, 10419913
section appsec
Agent [baseline] (1.185 s) : 0, 1185251
Total [baseline] (10.442 s) : 0, 10442401
Agent [candidate] (1.184 s) : 0, 1183507
Total [candidate] (10.484 s) : 0, 10483942
section iast
Agent [baseline] (1.168 s) : 0, 1167788
Total [baseline] (10.691 s) : 0, 10691271
Agent [candidate] (1.17 s) : 0, 1170336
Total [candidate] (10.596 s) : 0, 10595520
section profiling
Agent [baseline] (1.261 s) : 0, 1261205
Total [baseline] (10.675 s) : 0, 10674888
Agent [candidate] (1.265 s) : 0, 1264886
Total [candidate] (10.594 s) : 0, 10594000
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.185 s 111.213 ms (10.4%)
Agent iast 1.168 s 93.75 ms (8.7%)
Agent profiling 1.261 s 187.167 ms (17.4%)
Total tracing 10.399 s -
Total appsec 10.442 s 43.78 ms (0.4%)
Total iast 10.691 s 292.65 ms (2.8%)
Total profiling 10.675 s 276.267 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.184 s 113.424 ms (10.6%)
Agent iast 1.17 s 100.253 ms (9.4%)
Agent profiling 1.265 s 194.803 ms (18.2%)
Total tracing 10.42 s -
Total appsec 10.484 s 64.03 ms (0.6%)
Total iast 10.596 s 175.608 ms (1.7%)
Total profiling 10.594 s 174.087 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.584 ms) : 0, 673584
BytebuddyAgent [candidate] (670.717 ms) : 0, 670717
GlobalTracer [baseline] (306.564 ms) : 0, 306564
GlobalTracer [candidate] (305.927 ms) : 0, 305927
AppSec [baseline] (50.729 ms) : 0, 50729
AppSec [candidate] (50.365 ms) : 0, 50365
Remote Config [baseline] (696.726 µs) : 0, 697
Remote Config [candidate] (716.7 µs) : 0, 717
Telemetry [baseline] (7.58 ms) : 0, 7580
Telemetry [candidate] (7.667 ms) : 0, 7667
section appsec
BytebuddyAgent [baseline] (677.423 ms) : 0, 677423
BytebuddyAgent [candidate] (676.954 ms) : 0, 676954
GlobalTracer [baseline] (297.638 ms) : 0, 297638
GlobalTracer [candidate] (297.87 ms) : 0, 297870
AppSec [baseline] (154.103 ms) : 0, 154103
AppSec [candidate] (153.989 ms) : 0, 153989
IAST [baseline] (22.892 ms) : 0, 22892
IAST [candidate] (22.559 ms) : 0, 22559
Remote Config [baseline] (643.684 µs) : 0, 644
Remote Config [candidate] (634.247 µs) : 0, 634
Telemetry [baseline] (9.449 ms) : 0, 9449
Telemetry [candidate] (8.203 ms) : 0, 8203
section iast
BytebuddyAgent [baseline] (778.97 ms) : 0, 778970
BytebuddyAgent [candidate] (779.364 ms) : 0, 779364
GlobalTracer [baseline] (292.74 ms) : 0, 292740
GlobalTracer [candidate] (293.608 ms) : 0, 293608
AppSec [baseline] (47.024 ms) : 0, 47024
AppSec [candidate] (47.019 ms) : 0, 47019
IAST [baseline] (28.235 ms) : 0, 28235
IAST [candidate] (29.498 ms) : 0, 29498
Remote Config [baseline] (621.745 µs) : 0, 622
Remote Config [candidate] (661.958 µs) : 0, 662
Telemetry [baseline] (6.924 ms) : 0, 6924
Telemetry [candidate] (6.903 ms) : 0, 6903
section profiling
BytebuddyAgent [baseline] (662.332 ms) : 0, 662332
BytebuddyAgent [candidate] (665.742 ms) : 0, 665742
GlobalTracer [baseline] (385.812 ms) : 0, 385812
GlobalTracer [candidate] (385.742 ms) : 0, 385742
AppSec [baseline] (51.278 ms) : 0, 51278
AppSec [candidate] (51.172 ms) : 0, 51172
Remote Config [baseline] (718.824 µs) : 0, 719
Remote Config [candidate] (727.169 µs) : 0, 727
Telemetry [baseline] (7.391 ms) : 0, 7391
Telemetry [candidate] (7.36 ms) : 0, 7360
ProfilingAgent [baseline] (96.79 ms) : 0, 96790
ProfilingAgent [candidate] (96.752 ms) : 0, 96752
Profiling [baseline] (96.815 ms) : 0, 96815
Profiling [candidate] (96.776 ms) : 0, 96776
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060542
Total [baseline] (8.552 s) : 0, 8551942
Agent [candidate] (1.061 s) : 0, 1061222
Total [candidate] (8.561 s) : 0, 8561137
section iast
Agent [baseline] (1.169 s) : 0, 1168907
Total [baseline] (8.976 s) : 0, 8976286
Agent [candidate] (1.167 s) : 0, 1167300
Total [candidate] (8.966 s) : 0, 8965580
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176898
Total [baseline] (9.026 s) : 0, 9026116
Agent [candidate] (1.168 s) : 0, 1167829
Total [candidate] (8.989 s) : 0, 8988745
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1166202
Total [baseline] (8.974 s) : 0, 8973731
Agent [candidate] (1.17 s) : 0, 1169783
Total [candidate] (8.984 s) : 0, 8984428
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.169 s 108.365 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 116.355 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.166 s 105.659 ms (10.0%)
Total tracing 8.552 s -
Total iast 8.976 s 424.345 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.026 s 474.174 ms (5.5%)
Total iast_TELEMETRY_OFF 8.974 s 421.789 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.167 s 106.078 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 106.607 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.17 s 108.561 ms (10.2%)
Total tracing 8.561 s -
Total iast 8.966 s 404.443 ms (4.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.989 s 427.608 ms (5.0%)
Total iast_TELEMETRY_OFF 8.984 s 423.292 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.576 ms) : 0, 664576
BytebuddyAgent [candidate] (664.905 ms) : 0, 664905
GlobalTracer [baseline] (303.271 ms) : 0, 303271
GlobalTracer [candidate] (303.519 ms) : 0, 303519
AppSec [baseline] (50.163 ms) : 0, 50163
AppSec [candidate] (50.194 ms) : 0, 50194
Remote Config [baseline] (709.445 µs) : 0, 709
Remote Config [candidate] (693.919 µs) : 0, 694
Telemetry [baseline] (7.555 ms) : 0, 7555
Telemetry [candidate] (7.578 ms) : 0, 7578
section iast
BytebuddyAgent [baseline] (779.483 ms) : 0, 779483
BytebuddyAgent [candidate] (778.591 ms) : 0, 778591
GlobalTracer [baseline] (293.306 ms) : 0, 293306
GlobalTracer [candidate] (292.344 ms) : 0, 292344
AppSec [baseline] (46.949 ms) : 0, 46949
AppSec [candidate] (46.814 ms) : 0, 46814
IAST [baseline] (28.431 ms) : 0, 28431
IAST [candidate] (28.098 ms) : 0, 28098
Remote Config [baseline] (593.707 µs) : 0, 594
Remote Config [candidate] (628.035 µs) : 0, 628
Telemetry [baseline] (6.873 ms) : 0, 6873
Telemetry [candidate] (7.552 ms) : 0, 7552
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.907 ms) : 0, 784907
BytebuddyAgent [candidate] (778.057 ms) : 0, 778057
GlobalTracer [baseline] (295.238 ms) : 0, 295238
GlobalTracer [candidate] (292.966 ms) : 0, 292966
AppSec [baseline] (47.654 ms) : 0, 47654
AppSec [candidate] (47.363 ms) : 0, 47363
IAST [baseline] (28.028 ms) : 0, 28028
IAST [candidate] (28.511 ms) : 0, 28511
Remote Config [baseline] (668.881 µs) : 0, 669
Remote Config [candidate] (650.544 µs) : 0, 651
Telemetry [baseline] (6.977 ms) : 0, 6977
Telemetry [candidate] (6.949 ms) : 0, 6949
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.915 ms) : 0, 775915
BytebuddyAgent [candidate] (779.803 ms) : 0, 779803
GlobalTracer [baseline] (293.328 ms) : 0, 293328
GlobalTracer [candidate] (293.973 ms) : 0, 293973
AppSec [baseline] (47.106 ms) : 0, 47106
AppSec [candidate] (47.254 ms) : 0, 47254
IAST [baseline] (27.159 ms) : 0, 27159
IAST [candidate] (24.741 ms) : 0, 24741
Remote Config [baseline] (596.894 µs) : 0, 597
Remote Config [candidate] (612.829 µs) : 0, 613
Telemetry [baseline] (8.759 ms) : 0, 8759
Telemetry [candidate] (9.994 ms) : 0, 9994
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-25T08:24:36 2024-06-25T08:31:27
git_branch master malvarez/waf-user-events-system-test
git_commit_date 1719240462 1719302354
git_commit_sha 2d36ca7 b9fdde2
release_version 1.36.0-SNAPSHOT~2d36ca7c31 1.36.0-SNAPSHOT~b9fdde2ef0
start_time 2024-06-25T08:24:23 2024-06-25T08:31:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719304632 1719304632
ci_job_id 552330609 552330609
ci_pipeline_id 37480417 37480417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.679 µs) : 350, 393
.   : milestone, 372,
iast (484.742 µs) : 463, 507
.   : milestone, 485,
iast_FULL (551.985 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (517.655 µs) : 494, 541
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (483.246 µs) : 462, 505
.   : milestone, 483,
iast_INACTIVE (456.171 µs) : 435, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (471.218 µs) : 450, 492
.   : milestone, 471,
tracing (440.14 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (369.335 µs) : 350, 389
.   : milestone, 369,
iast (486.307 µs) : 465, 508
.   : milestone, 486,
iast_FULL (558.226 µs) : 537, 580
.   : milestone, 558,
iast_GLOBAL (509.13 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (480.365 µs) : 459, 502
.   : milestone, 480,
iast_INACTIVE (458.548 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (469.332 µs) : 449, 490
.   : milestone, 469,
tracing (440.193 µs) : 420, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.679 µs [350.495 µs, 392.863 µs] -
iast 484.742 µs [462.732 µs, 506.752 µs] 113.063 µs (30.4%)
iast_FULL 551.985 µs [530.813 µs, 573.156 µs] 180.306 µs (48.5%)
iast_GLOBAL 517.655 µs [494.225 µs, 541.085 µs] 145.976 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED 483.246 µs [461.837 µs, 504.654 µs] 111.567 µs (30.0%)
iast_INACTIVE 456.171 µs [434.572 µs, 477.77 µs] 84.492 µs (22.7%)
iast_TELEMETRY_OFF 471.218 µs [450.006 µs, 492.43 µs] 99.539 µs (26.8%)
tracing 440.14 µs [419.25 µs, 461.03 µs] 68.461 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.335 µs [349.879 µs, 388.792 µs] -
iast 486.307 µs [464.536 µs, 508.078 µs] 116.972 µs (31.7%)
iast_FULL 558.226 µs [536.846 µs, 579.606 µs] 188.89 µs (51.1%)
iast_GLOBAL 509.13 µs [487.423 µs, 530.838 µs] 139.795 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 480.365 µs [458.953 µs, 501.778 µs] 111.03 µs (30.1%)
iast_INACTIVE 458.548 µs [437.107 µs, 479.989 µs] 89.213 µs (24.2%)
iast_TELEMETRY_OFF 469.332 µs [448.646 µs, 490.018 µs] 99.996 µs (27.1%)
tracing 440.193 µs [420.05 µs, 460.336 µs] 70.858 µs (19.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1355, 1393
.   : milestone, 1374,
appsec (1.715 ms) : 1691, 1739
.   : milestone, 1715,
appsec_no_iast (1.727 ms) : 1702, 1752
.   : milestone, 1727,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.502 ms) : 1478, 1525
.   : milestone, 1502,
tracing (1.472 ms) : 1448, 1496
.   : milestone, 1472,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.722 ms) : 1697, 1747
.   : milestone, 1722,
appsec_no_iast (1.719 ms) : 1695, 1744
.   : milestone, 1719,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.479 ms) : 1454, 1504
.   : milestone, 1479,
tracing (1.47 ms) : 1447, 1494
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.355 ms, 1.393 ms] -
appsec 1.715 ms [1.691 ms, 1.739 ms] 341.119 µs (24.8%)
appsec_no_iast 1.727 ms [1.702 ms, 1.752 ms] 353.081 µs (25.7%)
iast 1.477 ms [1.454 ms, 1.5 ms] 103.014 µs (7.5%)
profiling 1.502 ms [1.478 ms, 1.525 ms] 127.475 µs (9.3%)
tracing 1.472 ms [1.448 ms, 1.496 ms] 98.003 µs (7.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.722 ms [1.697 ms, 1.747 ms] 367.938 µs (27.2%)
appsec_no_iast 1.719 ms [1.695 ms, 1.744 ms] 365.292 µs (27.0%)
iast 1.486 ms [1.463 ms, 1.509 ms] 131.665 µs (9.7%)
profiling 1.479 ms [1.454 ms, 1.504 ms] 124.856 µs (9.2%)
tracing 1.47 ms [1.447 ms, 1.494 ms] 116.302 µs (8.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-user-events-system-test
git_commit_date 1719240462 1719302354
git_commit_sha 2d36ca7 b9fdde2
release_version 1.36.0-SNAPSHOT~2d36ca7c31 1.36.0-SNAPSHOT~b9fdde2ef0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719305142 1719305142
ci_job_id 552330610 552330610
ci_pipeline_id 37480417 37480417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.454 ms) : 1443, 1466
.   : milestone, 1454,
appsec (2.192 ms) : 2157, 2226
.   : milestone, 2192,
iast (1.958 ms) : 1917, 1999
.   : milestone, 1958,
iast_GLOBAL (1.994 ms) : 1953, 2034
.   : milestone, 1994,
profiling (1.854 ms) : 1821, 1887
.   : milestone, 1854,
tracing (1.817 ms) : 1785, 1849
.   : milestone, 1817,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.196 ms) : 2161, 2230
.   : milestone, 2196,
iast (1.958 ms) : 1917, 1999
.   : milestone, 1958,
iast_GLOBAL (1.99 ms) : 1950, 2031
.   : milestone, 1990,
profiling (1.837 ms) : 1804, 1869
.   : milestone, 1837,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.443 ms, 1.466 ms] -
appsec 2.192 ms [2.157 ms, 2.226 ms] 737.621 µs (50.7%)
iast 1.958 ms [1.917 ms, 1.999 ms] 503.884 µs (34.7%)
iast_GLOBAL 1.994 ms [1.953 ms, 2.034 ms] 539.453 µs (37.1%)
profiling 1.854 ms [1.821 ms, 1.887 ms] 399.803 µs (27.5%)
tracing 1.817 ms [1.785 ms, 1.849 ms] 362.971 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.196 ms [2.161 ms, 2.23 ms] 740.095 µs (50.9%)
iast 1.958 ms [1.917 ms, 1.999 ms] 502.262 µs (34.5%)
iast_GLOBAL 1.99 ms [1.95 ms, 2.031 ms] 535.054 µs (36.8%)
profiling 1.837 ms [1.804 ms, 1.869 ms] 381.083 µs (26.2%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 369.864 µs (25.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b9fdde2ef0, baseline=1.36.0-SNAPSHOT~2d36ca7c31
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
appsec (14.904 s) : 14904000, 14904000
.   : milestone, 14904000,
iast (18.963 s) : 18963000, 18963000
.   : milestone, 18963000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
.   : milestone, 17800000,
profiling (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
tracing (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
section candidate
no_agent (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
appsec (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
iast (18.753 s) : 18753000, 18753000
.   : milestone, 18753000,
iast_GLOBAL (17.89 s) : 17890000, 17890000
.   : milestone, 17890000,
profiling (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
tracing (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.017 s [15.017 s, 15.017 s] -
appsec 14.904 s [14.904 s, 14.904 s] -113.0 ms (-0.8%)
iast 18.963 s [18.963 s, 18.963 s] 3.946 s (26.3%)
iast_GLOBAL 17.8 s [17.8 s, 17.8 s] 2.783 s (18.5%)
profiling 15.13 s [15.13 s, 15.13 s] 113.0 ms (0.8%)
tracing 15.155 s [15.155 s, 15.155 s] 138.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.416 s [15.416 s, 15.416 s] -
appsec 15.12 s [15.12 s, 15.12 s] -296.0 ms (-1.9%)
iast 18.753 s [18.753 s, 18.753 s] 3.337 s (21.6%)
iast_GLOBAL 17.89 s [17.89 s, 17.89 s] 2.474 s (16.0%)
profiling 15.004 s [15.004 s, 15.004 s] -412.0 ms (-2.7%)
tracing 15.147 s [15.147 s, 15.147 s] -269.0 ms (-1.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-user-events-system-test branch from b74fdbf to b9fdde2 Compare June 25, 2024 07:59
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-user-events-system-test branch from b9fdde2 to f26d253 Compare June 25, 2024 08:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit d19ceac into master Jun 25, 2024
77 of 78 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-user-events-system-test branch June 25, 2024 09:54
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@jandro996 jandro996 jandro996 approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuel-alvarez-alvarez @smola @jandro996