Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

 Add support for patch release to milestone automation #7217

Merged
merged 1 commit into from
Jun 28, 2024
Merged

 Add support for patch release to milestone automation #7217

merged 1 commit into from
Jun 28, 2024

Conversation

PerfectSlayer
Copy link
Contributor

What Does This Do

This PR fixes the GitHub milestone automation when patch release are opened.
This will fix the behavior for both minor and patch target PRs.

Motivation

The PRs where randomly affected to either the patch or the minor release milestone.

Additional Notes

I tested the workflow using act, a PAT and some event payload file.
It should catch most of the issues...

I also update GitHub script action version.

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added type: bug tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 19, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 19, 2024 11:43
@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci-github-workflow
git_commit_date 1718709557 1718797119
git_commit_sha ae0ed76 52bd6f7
release_version 1.36.0-SNAPSHOT~ae0ed76333 1.36.0-SNAPSHOT~52bd6f7cca
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718800273 1718800273
ci_job_id 547898043 547898043
ci_pipeline_id 37101236 37101236
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061627
Total [baseline] (10.385 s) : 0, 10385343
Agent [candidate] (1.064 s) : 0, 1063775
Total [candidate] (10.347 s) : 0, 10347443
section appsec
Agent [baseline] (1.184 s) : 0, 1184192
Total [baseline] (10.52 s) : 0, 10519551
Agent [candidate] (1.184 s) : 0, 1183928
Total [candidate] (10.487 s) : 0, 10486878
section iast
Agent [baseline] (1.17 s) : 0, 1169590
Total [baseline] (10.638 s) : 0, 10637933
Agent [candidate] (1.192 s) : 0, 1192062
Total [candidate] (10.74 s) : 0, 10740131
section profiling
Agent [baseline] (1.262 s) : 0, 1262458
Total [baseline] (10.648 s) : 0, 10647509
Agent [candidate] (1.27 s) : 0, 1270188
Total [candidate] (10.653 s) : 0, 10653148
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.184 s 122.566 ms (11.5%)
Agent iast 1.17 s 107.963 ms (10.2%)
Agent profiling 1.262 s 200.831 ms (18.9%)
Total tracing 10.385 s -
Total appsec 10.52 s 134.208 ms (1.3%)
Total iast 10.638 s 252.59 ms (2.4%)
Total profiling 10.648 s 262.165 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.184 s 120.152 ms (11.3%)
Agent iast 1.192 s 128.287 ms (12.1%)
Agent profiling 1.27 s 206.413 ms (19.4%)
Total tracing 10.347 s -
Total appsec 10.487 s 139.435 ms (1.3%)
Total iast 10.74 s 392.687 ms (3.8%)
Total profiling 10.653 s 305.705 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.241 ms) : 0, 665241
BytebuddyAgent [candidate] (666.654 ms) : 0, 666654
GlobalTracer [baseline] (303.206 ms) : 0, 303206
GlobalTracer [candidate] (304.089 ms) : 0, 304089
AppSec [baseline] (50.487 ms) : 0, 50487
AppSec [candidate] (50.272 ms) : 0, 50272
Remote Config [baseline] (682.627 µs) : 0, 683
Remote Config [candidate] (694.312 µs) : 0, 694
Telemetry [baseline] (7.57 ms) : 0, 7570
Telemetry [candidate] (7.592 ms) : 0, 7592
section appsec
BytebuddyAgent [baseline] (677.316 ms) : 0, 677316
BytebuddyAgent [candidate] (677.368 ms) : 0, 677368
GlobalTracer [baseline] (298.475 ms) : 0, 298475
GlobalTracer [candidate] (297.762 ms) : 0, 297762
AppSec [baseline] (154.329 ms) : 0, 154329
AppSec [candidate] (153.797 ms) : 0, 153797
Remote Config [baseline] (644.708 µs) : 0, 645
Remote Config [candidate] (633.434 µs) : 0, 633
Telemetry [baseline] (8.234 ms) : 0, 8234
Telemetry [candidate] (9.667 ms) : 0, 9667
IAST [baseline] (21.298 ms) : 0, 21298
IAST [candidate] (20.338 ms) : 0, 20338
section iast
BytebuddyAgent [baseline] (779.383 ms) : 0, 779383
BytebuddyAgent [candidate] (797.452 ms) : 0, 797452
GlobalTracer [baseline] (292.866 ms) : 0, 292866
GlobalTracer [candidate] (297.571 ms) : 0, 297571
AppSec [baseline] (47.181 ms) : 0, 47181
AppSec [candidate] (47.746 ms) : 0, 47746
Remote Config [baseline] (645.268 µs) : 0, 645
Remote Config [candidate] (612.889 µs) : 0, 613
Telemetry [baseline] (7.785 ms) : 0, 7785
Telemetry [candidate] (6.989 ms) : 0, 6989
IAST [baseline] (28.457 ms) : 0, 28457
IAST [candidate] (28.148 ms) : 0, 28148
section profiling
BytebuddyAgent [baseline] (663.962 ms) : 0, 663962
BytebuddyAgent [candidate] (667.529 ms) : 0, 667529
GlobalTracer [baseline] (386.39 ms) : 0, 386390
GlobalTracer [candidate] (387.741 ms) : 0, 387741
AppSec [baseline] (51.664 ms) : 0, 51664
AppSec [candidate] (52.054 ms) : 0, 52054
Remote Config [baseline] (736.437 µs) : 0, 736
Remote Config [candidate] (734.233 µs) : 0, 734
Telemetry [baseline] (7.371 ms) : 0, 7371
Telemetry [candidate] (7.41 ms) : 0, 7410
ProfilingAgent [baseline] (95.286 ms) : 0, 95286
ProfilingAgent [candidate] (97.271 ms) : 0, 97271
Profiling [baseline] (95.311 ms) : 0, 95311
Profiling [candidate] (97.297 ms) : 0, 97297
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060224
Total [baseline] (8.543 s) : 0, 8542854
Agent [candidate] (1.068 s) : 0, 1068043
Total [candidate] (8.546 s) : 0, 8545717
section iast
Agent [baseline] (1.168 s) : 0, 1168236
Total [baseline] (8.999 s) : 0, 8998661
Agent [candidate] (1.168 s) : 0, 1168446
Total [candidate] (9.012 s) : 0, 9012407
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179095
Total [baseline] (9.011 s) : 0, 9010558
Agent [candidate] (1.172 s) : 0, 1172231
Total [candidate] (8.976 s) : 0, 8976172
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1164406
Total [baseline] (8.985 s) : 0, 8985207
Agent [candidate] (1.17 s) : 0, 1169522
Total [candidate] (8.999 s) : 0, 8998878
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.168 s 108.012 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 118.871 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.164 s 104.182 ms (9.8%)
Total tracing 8.543 s -
Total iast 8.999 s 455.808 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.011 s 467.704 ms (5.5%)
Total iast_TELEMETRY_OFF 8.985 s 442.353 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.168 s 100.403 ms (9.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 104.188 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.17 s 101.479 ms (9.5%)
Total tracing 8.546 s -
Total iast 9.012 s 466.691 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.976 s 430.455 ms (5.0%)
Total iast_TELEMETRY_OFF 8.999 s 453.162 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.449 ms) : 0, 664449
BytebuddyAgent [candidate] (669.27 ms) : 0, 669270
GlobalTracer [baseline] (303.184 ms) : 0, 303184
GlobalTracer [candidate] (305.278 ms) : 0, 305278
AppSec [baseline] (50.112 ms) : 0, 50112
AppSec [candidate] (50.591 ms) : 0, 50591
Remote Config [baseline] (692.081 µs) : 0, 692
Remote Config [candidate] (694.879 µs) : 0, 695
Telemetry [baseline] (7.521 ms) : 0, 7521
Telemetry [candidate] (7.658 ms) : 0, 7658
section iast
BytebuddyAgent [baseline] (778.818 ms) : 0, 778818
BytebuddyAgent [candidate] (778.808 ms) : 0, 778808
GlobalTracer [baseline] (293.148 ms) : 0, 293148
GlobalTracer [candidate] (293.025 ms) : 0, 293025
AppSec [baseline] (46.95 ms) : 0, 46950
AppSec [candidate] (46.9 ms) : 0, 46900
Remote Config [baseline] (607.359 µs) : 0, 607
Remote Config [candidate] (609.675 µs) : 0, 610
Telemetry [baseline] (6.819 ms) : 0, 6819
Telemetry [candidate] (6.872 ms) : 0, 6872
IAST [baseline] (28.652 ms) : 0, 28652
IAST [candidate] (28.968 ms) : 0, 28968
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.515 ms) : 0, 784515
BytebuddyAgent [candidate] (781.648 ms) : 0, 781648
GlobalTracer [baseline] (296.905 ms) : 0, 296905
GlobalTracer [candidate] (293.977 ms) : 0, 293977
AppSec [baseline] (48.037 ms) : 0, 48037
AppSec [candidate] (47.315 ms) : 0, 47315
Remote Config [baseline] (661.127 µs) : 0, 661
Remote Config [candidate] (662.693 µs) : 0, 663
Telemetry [baseline] (7.807 ms) : 0, 7807
Telemetry [candidate] (6.992 ms) : 0, 6992
IAST [baseline] (27.768 ms) : 0, 27768
IAST [candidate] (28.234 ms) : 0, 28234
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.47 ms) : 0, 776470
BytebuddyAgent [candidate] (778.753 ms) : 0, 778753
GlobalTracer [baseline] (293.201 ms) : 0, 293201
GlobalTracer [candidate] (294.936 ms) : 0, 294936
AppSec [baseline] (47.238 ms) : 0, 47238
AppSec [candidate] (47.538 ms) : 0, 47538
Remote Config [baseline] (589.5 µs) : 0, 590
Remote Config [candidate] (596.96 µs) : 0, 597
Telemetry [baseline] (8.43 ms) : 0, 8430
Telemetry [candidate] (7.74 ms) : 0, 7740
IAST [baseline] (25.176 ms) : 0, 25176
IAST [candidate] (26.587 ms) : 0, 26587
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-19T12:01:59 2024-06-19T12:08:48
git_branch master bbujon/ci-github-workflow
git_commit_date 1718709557 1718797119
git_commit_sha ae0ed76 52bd6f7
release_version 1.36.0-SNAPSHOT~ae0ed76333 1.36.0-SNAPSHOT~52bd6f7cca
start_time 2024-06-19T12:01:46 2024-06-19T12:08:35
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718799273 1718799273
ci_job_id 547898045 547898045
ci_pipeline_id 37101236 37101236
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1358
.   : milestone, 1337,
appsec (1.734 ms) : 1711, 1757
.   : milestone, 1734,
appsec_no_iast (1.717 ms) : 1693, 1741
.   : milestone, 1717,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.509 ms) : 1484, 1535
.   : milestone, 1509,
tracing (1.464 ms) : 1440, 1488
.   : milestone, 1464,
section candidate
no_agent (1.35 ms) : 1331, 1370
.   : milestone, 1350,
appsec (1.72 ms) : 1696, 1744
.   : milestone, 1720,
appsec_no_iast (1.736 ms) : 1712, 1761
.   : milestone, 1736,
iast (1.469 ms) : 1446, 1491
.   : milestone, 1469,
profiling (1.476 ms) : 1451, 1502
.   : milestone, 1476,
tracing (1.468 ms) : 1442, 1494
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.358 ms] -
appsec 1.734 ms [1.711 ms, 1.757 ms] 396.381 µs (29.6%)
appsec_no_iast 1.717 ms [1.693 ms, 1.741 ms] 379.805 µs (28.4%)
iast 1.479 ms [1.456 ms, 1.502 ms] 142.004 µs (10.6%)
profiling 1.509 ms [1.484 ms, 1.535 ms] 171.928 µs (12.9%)
tracing 1.464 ms [1.44 ms, 1.488 ms] 126.428 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.37 ms] -
appsec 1.72 ms [1.696 ms, 1.744 ms] 370.007 µs (27.4%)
appsec_no_iast 1.736 ms [1.712 ms, 1.761 ms] 386.187 µs (28.6%)
iast 1.469 ms [1.446 ms, 1.491 ms] 118.537 µs (8.8%)
profiling 1.476 ms [1.451 ms, 1.502 ms] 126.121 µs (9.3%)
tracing 1.468 ms [1.442 ms, 1.494 ms] 117.98 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.816 µs) : 349, 390
.   : milestone, 370,
iast (477.179 µs) : 456, 498
.   : milestone, 477,
iast_FULL (550.189 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (507.839 µs) : 487, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (472.068 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (450.444 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (468.492 µs) : 447, 490
.   : milestone, 468,
tracing (442.245 µs) : 421, 463
.   : milestone, 442,
section candidate
no_agent (360.674 µs) : 341, 380
.   : milestone, 361,
iast (474.735 µs) : 454, 496
.   : milestone, 475,
iast_FULL (550.515 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (503.369 µs) : 482, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (498.105 µs) : 477, 520
.   : milestone, 498,
iast_INACTIVE (452.472 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (471.446 µs) : 450, 493
.   : milestone, 471,
tracing (438.983 µs) : 419, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.816 µs [349.189 µs, 390.444 µs] -
iast 477.179 µs [456.194 µs, 498.165 µs] 107.363 µs (29.0%)
iast_FULL 550.189 µs [529.192 µs, 571.186 µs] 180.373 µs (48.8%)
iast_GLOBAL 507.839 µs [486.792 µs, 528.885 µs] 138.022 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 472.068 µs [451.486 µs, 492.65 µs] 102.251 µs (27.6%)
iast_INACTIVE 450.444 µs [429.251 µs, 471.637 µs] 80.628 µs (21.8%)
iast_TELEMETRY_OFF 468.492 µs [447.233 µs, 489.752 µs] 98.676 µs (26.7%)
tracing 442.245 µs [421.207 µs, 463.283 µs] 72.429 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.674 µs [341.253 µs, 380.096 µs] -
iast 474.735 µs [453.815 µs, 495.654 µs] 114.06 µs (31.6%)
iast_FULL 550.515 µs [529.361 µs, 571.669 µs] 189.841 µs (52.6%)
iast_GLOBAL 503.369 µs [481.787 µs, 524.952 µs] 142.695 µs (39.6%)
iast_HARDCODED_SECRET_DISABLED 498.105 µs [476.531 µs, 519.679 µs] 137.43 µs (38.1%)
iast_INACTIVE 452.472 µs [431.127 µs, 473.817 µs] 91.798 µs (25.5%)
iast_TELEMETRY_OFF 471.446 µs [450.0 µs, 492.891 µs] 110.771 µs (30.7%)
tracing 438.983 µs [418.534 µs, 459.433 µs] 78.309 µs (21.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci-github-workflow
git_commit_date 1718709557 1718797119
git_commit_sha ae0ed76 52bd6f7
release_version 1.36.0-SNAPSHOT~ae0ed76333 1.36.0-SNAPSHOT~52bd6f7cca
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718799811 1718799811
ci_job_id 547898046 547898046
ci_pipeline_id 37101236 37101236
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
appsec (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
iast (18.771 s) : 18771000, 18771000
.   : milestone, 18771000,
iast_GLOBAL (17.824 s) : 17824000, 17824000
.   : milestone, 17824000,
profiling (15.805 s) : 15805000, 15805000
.   : milestone, 15805000,
tracing (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
section candidate
no_agent (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
appsec (14.691 s) : 14691000, 14691000
.   : milestone, 14691000,
iast (18.857 s) : 18857000, 18857000
.   : milestone, 18857000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
.   : milestone, 18008000,
profiling (15.941 s) : 15941000, 15941000
.   : milestone, 15941000,
tracing (15.248 s) : 15248000, 15248000
.   : milestone, 15248000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.053 s [15.053 s, 15.053 s] -
appsec 15.006 s [15.006 s, 15.006 s] -47.0 ms (-0.3%)
iast 18.771 s [18.771 s, 18.771 s] 3.718 s (24.7%)
iast_GLOBAL 17.824 s [17.824 s, 17.824 s] 2.771 s (18.4%)
profiling 15.805 s [15.805 s, 15.805 s] 752.0 ms (5.0%)
tracing 15.009 s [15.009 s, 15.009 s] -44.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.937 s [14.937 s, 14.937 s] -
appsec 14.691 s [14.691 s, 14.691 s] -246.0 ms (-1.6%)
iast 18.857 s [18.857 s, 18.857 s] 3.92 s (26.2%)
iast_GLOBAL 18.008 s [18.008 s, 18.008 s] 3.071 s (20.6%)
profiling 15.941 s [15.941 s, 15.941 s] 1.004 s (6.7%)
tracing 15.248 s [15.248 s, 15.248 s] 311.0 ms (2.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~52bd6f7cca, baseline=1.36.0-SNAPSHOT~ae0ed76333
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.224 ms) : 2190, 2258
.   : milestone, 2224,
iast (1.964 ms) : 1923, 2004
.   : milestone, 1964,
iast_GLOBAL (2.015 ms) : 1974, 2057
.   : milestone, 2015,
profiling (1.853 ms) : 1819, 1887
.   : milestone, 1853,
tracing (1.834 ms) : 1802, 1866
.   : milestone, 1834,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.212 ms) : 2179, 2246
.   : milestone, 2212,
iast (1.977 ms) : 1935, 2018
.   : milestone, 1977,
iast_GLOBAL (2.021 ms) : 1979, 2062
.   : milestone, 2021,
profiling (1.852 ms) : 1819, 1886
.   : milestone, 1852,
tracing (1.84 ms) : 1808, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.224 ms [2.19 ms, 2.258 ms] 759.094 µs (51.8%)
iast 1.964 ms [1.923 ms, 2.004 ms] 498.464 µs (34.0%)
iast_GLOBAL 2.015 ms [1.974 ms, 2.057 ms] 550.01 µs (37.5%)
profiling 1.853 ms [1.819 ms, 1.887 ms] 388.02 µs (26.5%)
tracing 1.834 ms [1.802 ms, 1.866 ms] 368.694 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.212 ms [2.179 ms, 2.246 ms] 749.126 µs (51.2%)
iast 1.977 ms [1.935 ms, 2.018 ms] 513.63 µs (35.1%)
iast_GLOBAL 2.021 ms [1.979 ms, 2.062 ms] 557.615 µs (38.1%)
profiling 1.852 ms [1.819 ms, 1.886 ms] 389.24 µs (26.6%)
tracing 1.84 ms [1.808 ms, 1.872 ms] 376.998 µs (25.8%)

ygree
ygree approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PerfectSlayer PerfectSlayer merged commit ebb3c0b into master Jun 28, 2024
77 of 81 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/ci-github-workflow branch June 28, 2024 07:51
@PerfectSlayer PerfectSlayer mentioned this pull request Jul 1, 2024
Merged
@PerfectSlayer PerfectSlayer added this to the 1.37.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PerfectSlayer @ygree