Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Gradle version catalog #7230

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Move to Gradle version catalog #7230

merged 3 commits into from
Jun 24, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Jun 21, 2024

What Does This Do

This PRs moves our common dependencies definitions from Gradle custom script to Gradle version catalog.

Motivation

  • Follow gradle conventions rather than our custom build scripts
  • Enjoy code completion and related IDE features
  • Might help with security scanners

Additional Notes

Related Gradle documentation

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added tag: experimental Experimental changes comp: tooling Build & Tooling labels Jun 21, 2024
Release tests will be moved as submodules of the main project later
@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/lib-catalog
git_commit_date 1719219814 1719226981
git_commit_sha 46c883a cb08639
release_version 1.36.0-SNAPSHOT~46c883aa3a 1.36.0-SNAPSHOT~cb08639cd0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719229968 1719229968
ci_job_id 551476764 551476764
ci_pipeline_id 37402564 37402564
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062172
Total [baseline] (8.587 s) : 0, 8587353
Agent [candidate] (1.061 s) : 0, 1061493
Total [candidate] (8.551 s) : 0, 8550552
section iast
Agent [baseline] (1.168 s) : 0, 1168259
Total [baseline] (9.01 s) : 0, 9010045
Agent [candidate] (1.169 s) : 0, 1169468
Total [candidate] (9.013 s) : 0, 9012773
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185702
Total [baseline] (9.059 s) : 0, 9058676
Agent [candidate] (1.169 s) : 0, 1169312
Total [candidate] (9.024 s) : 0, 9023887
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174382
Total [baseline] (8.998 s) : 0, 8998289
Agent [candidate] (1.162 s) : 0, 1162121
Total [candidate] (9.003 s) : 0, 9002793
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.168 s 106.087 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 123.53 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.174 s 112.21 ms (10.6%)
Total tracing 8.587 s -
Total iast 9.01 s 422.693 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.059 s 471.324 ms (5.5%)
Total iast_TELEMETRY_OFF 8.998 s 410.936 ms (4.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.169 s 107.975 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 107.82 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.162 s 100.629 ms (9.5%)
Total tracing 8.551 s -
Total iast 9.013 s 462.221 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.024 s 473.335 ms (5.5%)
Total iast_TELEMETRY_OFF 9.003 s 452.242 ms (5.3%)
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.373 ms) : 0, 665373
BytebuddyAgent [candidate] (665.322 ms) : 0, 665322
GlobalTracer [baseline] (303.969 ms) : 0, 303969
GlobalTracer [candidate] (303.613 ms) : 0, 303613
AppSec [baseline] (50.392 ms) : 0, 50392
AppSec [candidate] (50.014 ms) : 0, 50014
Remote Config [baseline] (682.947 µs) : 0, 683
Remote Config [candidate] (691.125 µs) : 0, 691
Telemetry [baseline] (7.51 ms) : 0, 7510
Telemetry [candidate] (7.587 ms) : 0, 7587
section iast
BytebuddyAgent [baseline] (779.068 ms) : 0, 779068
BytebuddyAgent [candidate] (778.776 ms) : 0, 778776
GlobalTracer [baseline] (293.37 ms) : 0, 293370
GlobalTracer [candidate] (293.252 ms) : 0, 293252
AppSec [baseline] (47.094 ms) : 0, 47094
AppSec [candidate] (47.085 ms) : 0, 47085
IAST [baseline] (27.983 ms) : 0, 27983
IAST [candidate] (29.49 ms) : 0, 29490
Remote Config [baseline] (590.705 µs) : 0, 591
Remote Config [candidate] (663.613 µs) : 0, 664
Telemetry [baseline] (6.863 ms) : 0, 6863
Telemetry [candidate] (6.919 ms) : 0, 6919
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.868 ms) : 0, 789868
BytebuddyAgent [candidate] (779.409 ms) : 0, 779409
GlobalTracer [baseline] (297.579 ms) : 0, 297579
GlobalTracer [candidate] (293.583 ms) : 0, 293583
AppSec [baseline] (47.899 ms) : 0, 47899
AppSec [candidate] (47.196 ms) : 0, 47196
IAST [baseline] (29.252 ms) : 0, 29252
IAST [candidate] (28.239 ms) : 0, 28239
Remote Config [baseline] (609.098 µs) : 0, 609
Remote Config [candidate] (615.235 µs) : 0, 615
Telemetry [baseline] (7.009 ms) : 0, 7009
Telemetry [candidate] (6.939 ms) : 0, 6939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.725 ms) : 0, 782725
BytebuddyAgent [candidate] (775.637 ms) : 0, 775637
GlobalTracer [baseline] (295.757 ms) : 0, 295757
GlobalTracer [candidate] (293.369 ms) : 0, 293369
AppSec [baseline] (47.352 ms) : 0, 47352
AppSec [candidate] (47.042 ms) : 0, 47042
IAST [baseline] (26.892 ms) : 0, 26892
IAST [candidate] (25.258 ms) : 0, 25258
Remote Config [baseline] (601.459 µs) : 0, 601
Remote Config [candidate] (587.617 µs) : 0, 588
Telemetry [baseline] (7.636 ms) : 0, 7636
Telemetry [candidate] (6.925 ms) : 0, 6925
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061816
Total [baseline] (10.292 s) : 0, 10292003
Agent [candidate] (1.069 s) : 0, 1068992
Total [candidate] (10.367 s) : 0, 10367108
section appsec
Agent [baseline] (1.183 s) : 0, 1182942
Total [baseline] (10.473 s) : 0, 10473309
Agent [candidate] (1.196 s) : 0, 1195780
Total [candidate] (10.609 s) : 0, 10609444
section iast
Agent [baseline] (1.172 s) : 0, 1171517
Total [baseline] (10.768 s) : 0, 10767774
Agent [candidate] (1.171 s) : 0, 1171337
Total [candidate] (10.7 s) : 0, 10699661
section profiling
Agent [baseline] (1.263 s) : 0, 1262971
Total [baseline] (10.601 s) : 0, 10600845
Agent [candidate] (1.269 s) : 0, 1269412
Total [candidate] (10.73 s) : 0, 10729700
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.183 s 121.126 ms (11.4%)
Agent iast 1.172 s 109.701 ms (10.3%)
Agent profiling 1.263 s 201.154 ms (18.9%)
Total tracing 10.292 s -
Total appsec 10.473 s 181.305 ms (1.8%)
Total iast 10.768 s 475.77 ms (4.6%)
Total profiling 10.601 s 308.842 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.196 s 126.788 ms (11.9%)
Agent iast 1.171 s 102.346 ms (9.6%)
Agent profiling 1.269 s 200.42 ms (18.7%)
Total tracing 10.367 s -
Total appsec 10.609 s 242.336 ms (2.3%)
Total iast 10.7 s 332.554 ms (3.2%)
Total profiling 10.73 s 362.592 ms (3.5%)
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.474 ms) : 0, 665474
BytebuddyAgent [candidate] (669.964 ms) : 0, 669964
GlobalTracer [baseline] (303.398 ms) : 0, 303398
GlobalTracer [candidate] (305.732 ms) : 0, 305732
AppSec [baseline] (50.27 ms) : 0, 50270
AppSec [candidate] (50.347 ms) : 0, 50347
Remote Config [baseline] (688.604 µs) : 0, 689
Remote Config [candidate] (687.59 µs) : 0, 688
Telemetry [baseline] (7.587 ms) : 0, 7587
Telemetry [candidate] (7.588 ms) : 0, 7588
section appsec
BytebuddyAgent [baseline] (676.1 ms) : 0, 676100
BytebuddyAgent [candidate] (684.189 ms) : 0, 684189
GlobalTracer [baseline] (297.725 ms) : 0, 297725
GlobalTracer [candidate] (301.533 ms) : 0, 301533
AppSec [baseline] (153.845 ms) : 0, 153845
AppSec [candidate] (155.264 ms) : 0, 155264
Remote Config [baseline] (636.264 µs) : 0, 636
Remote Config [candidate] (659.37 µs) : 0, 659
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (8.005 ms) : 0, 8005
IAST [baseline] (22.285 ms) : 0, 22285
IAST [candidate] (22.659 ms) : 0, 22659
section iast
BytebuddyAgent [baseline] (780.437 ms) : 0, 780437
BytebuddyAgent [candidate] (780.438 ms) : 0, 780438
GlobalTracer [baseline] (294.154 ms) : 0, 294154
GlobalTracer [candidate] (294.851 ms) : 0, 294851
AppSec [baseline] (47.176 ms) : 0, 47176
AppSec [candidate] (47.089 ms) : 0, 47089
Remote Config [baseline] (620.544 µs) : 0, 621
Remote Config [candidate] (633.507 µs) : 0, 634
Telemetry [baseline] (6.842 ms) : 0, 6842
Telemetry [candidate] (6.911 ms) : 0, 6911
IAST [baseline] (28.984 ms) : 0, 28984
IAST [candidate] (28.092 ms) : 0, 28092
section profiling
ProfilingAgent [baseline] (96.434 ms) : 0, 96434
ProfilingAgent [candidate] (97.544 ms) : 0, 97544
BytebuddyAgent [baseline] (663.184 ms) : 0, 663184
BytebuddyAgent [candidate] (666.625 ms) : 0, 666625
GlobalTracer [baseline] (386.778 ms) : 0, 386778
GlobalTracer [candidate] (387.882 ms) : 0, 387882
AppSec [baseline] (51.476 ms) : 0, 51476
AppSec [candidate] (51.895 ms) : 0, 51895
Remote Config [baseline] (727.773 µs) : 0, 728
Remote Config [candidate] (735.979 µs) : 0, 736
Telemetry [baseline] (7.364 ms) : 0, 7364
Telemetry [candidate] (7.419 ms) : 0, 7419
Profiling [baseline] (96.46 ms) : 0, 96460
Profiling [candidate] (97.569 ms) : 0, 97569
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-24T11:23:35 2024-06-24T11:30:26
git_branch master bbujon/lib-catalog
git_commit_date 1719219814 1719226981
git_commit_sha 46c883a cb08639
release_version 1.36.0-SNAPSHOT~46c883aa3a 1.36.0-SNAPSHOT~cb08639cd0
start_time 2024-06-24T11:23:21 2024-06-24T11:30:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719228970 1719228970
ci_job_id 551476765 551476765
ci_pipeline_id 37402564 37402564
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1361
.   : milestone, 1342,
appsec (1.711 ms) : 1686, 1735
.   : milestone, 1711,
appsec_no_iast (1.71 ms) : 1685, 1734
.   : milestone, 1710,
iast (1.482 ms) : 1458, 1505
.   : milestone, 1482,
profiling (1.543 ms) : 1517, 1568
.   : milestone, 1543,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
section candidate
no_agent (1.359 ms) : 1339, 1380
.   : milestone, 1359,
appsec (1.721 ms) : 1697, 1744
.   : milestone, 1721,
appsec_no_iast (1.715 ms) : 1690, 1740
.   : milestone, 1715,
iast (1.467 ms) : 1444, 1490
.   : milestone, 1467,
profiling (1.49 ms) : 1465, 1514
.   : milestone, 1490,
tracing (1.473 ms) : 1449, 1496
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.322 ms, 1.361 ms] -
appsec 1.711 ms [1.686 ms, 1.735 ms] 368.778 µs (27.5%)
appsec_no_iast 1.71 ms [1.685 ms, 1.734 ms] 367.806 µs (27.4%)
iast 1.482 ms [1.458 ms, 1.505 ms] 139.781 µs (10.4%)
profiling 1.543 ms [1.517 ms, 1.568 ms] 200.744 µs (15.0%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 139.347 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.339 ms, 1.38 ms] -
appsec 1.721 ms [1.697 ms, 1.744 ms] 361.515 µs (26.6%)
appsec_no_iast 1.715 ms [1.69 ms, 1.74 ms] 355.285 µs (26.1%)
iast 1.467 ms [1.444 ms, 1.49 ms] 107.287 µs (7.9%)
profiling 1.49 ms [1.465 ms, 1.514 ms] 130.316 µs (9.6%)
tracing 1.473 ms [1.449 ms, 1.496 ms] 113.099 µs (8.3%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.143 µs) : 358, 397
.   : milestone, 377,
iast (478.917 µs) : 457, 501
.   : milestone, 479,
iast_FULL (559.44 µs) : 538, 581
.   : milestone, 559,
iast_GLOBAL (509.615 µs) : 488, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (477.39 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (451.767 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (475.449 µs) : 453, 498
.   : milestone, 475,
tracing (442.892 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (369.266 µs) : 350, 389
.   : milestone, 369,
iast (481.271 µs) : 460, 502
.   : milestone, 481,
iast_FULL (548.126 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (509.536 µs) : 488, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (477.794 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (450.996 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (470.266 µs) : 449, 492
.   : milestone, 470,
tracing (443.486 µs) : 423, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.143 µs [357.578 µs, 396.708 µs] -
iast 478.917 µs [457.253 µs, 500.582 µs] 101.774 µs (27.0%)
iast_FULL 559.44 µs [537.937 µs, 580.944 µs] 182.297 µs (48.3%)
iast_GLOBAL 509.615 µs [488.087 µs, 531.142 µs] 132.471 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 477.39 µs [456.318 µs, 498.462 µs] 100.247 µs (26.6%)
iast_INACTIVE 451.767 µs [430.251 µs, 473.282 µs] 74.624 µs (19.8%)
iast_TELEMETRY_OFF 475.449 µs [453.311 µs, 497.587 µs] 98.306 µs (26.1%)
tracing 442.892 µs [421.537 µs, 464.247 µs] 65.749 µs (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.266 µs [349.828 µs, 388.705 µs] -
iast 481.271 µs [460.313 µs, 502.228 µs] 112.004 µs (30.3%)
iast_FULL 548.126 µs [527.132 µs, 569.121 µs] 178.86 µs (48.4%)
iast_GLOBAL 509.536 µs [487.657 µs, 531.415 µs] 140.27 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 477.794 µs [456.901 µs, 498.686 µs] 108.528 µs (29.4%)
iast_INACTIVE 450.996 µs [429.748 µs, 472.244 µs] 81.73 µs (22.1%)
iast_TELEMETRY_OFF 470.266 µs [448.899 µs, 491.633 µs] 101.0 µs (27.4%)
tracing 443.486 µs [422.619 µs, 464.353 µs] 74.22 µs (20.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/lib-catalog
git_commit_date 1719219814 1719226981
git_commit_sha 46c883a cb08639
release_version 1.36.0-SNAPSHOT~46c883aa3a 1.36.0-SNAPSHOT~cb08639cd0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719230265 1719230265
ci_job_id 551476766 551476766
ci_pipeline_id 37402564 37402564
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.606 s) : 20606000, 20606000
.   : milestone, 20606000,
appsec (21.308 s) : 21308000, 21308000
.   : milestone, 21308000,
iast (24.264 s) : 24264000, 24264000
.   : milestone, 24264000,
iast_GLOBAL (25.158 s) : 25158000, 25158000
.   : milestone, 25158000,
profiling (20.864 s) : 20864000, 20864000
.   : milestone, 20864000,
tracing (20.958 s) : 20958000, 20958000
.   : milestone, 20958000,
section candidate
no_agent (20.758 s) : 20758000, 20758000
.   : milestone, 20758000,
appsec (21.05 s) : 21050000, 21050000
.   : milestone, 21050000,
iast (24.705 s) : 24705000, 24705000
.   : milestone, 24705000,
iast_GLOBAL (24.98 s) : 24980000, 24980000
.   : milestone, 24980000,
profiling (20.708 s) : 20708000, 20708000
.   : milestone, 20708000,
tracing (21.67 s) : 21670000, 21670000
.   : milestone, 21670000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.606 s [20.606 s, 20.606 s] -
appsec 21.308 s [21.308 s, 21.308 s] 702.0 ms (3.4%)
iast 24.264 s [24.264 s, 24.264 s] 3.658 s (17.8%)
iast_GLOBAL 25.158 s [25.158 s, 25.158 s] 4.552 s (22.1%)
profiling 20.864 s [20.864 s, 20.864 s] 258.0 ms (1.3%)
tracing 20.958 s [20.958 s, 20.958 s] 352.0 ms (1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.758 s [20.758 s, 20.758 s] -
appsec 21.05 s [21.05 s, 21.05 s] 292.0 ms (1.4%)
iast 24.705 s [24.705 s, 24.705 s] 3.947 s (19.0%)
iast_GLOBAL 24.98 s [24.98 s, 24.98 s] 4.222 s (20.3%)
profiling 20.708 s [20.708 s, 20.708 s] -50.0 ms (-0.2%)
tracing 21.67 s [21.67 s, 21.67 s] 912.0 ms (4.4%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~cb08639cd0, baseline=1.36.0-SNAPSHOT~46c883aa3a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.552 ms) : 1539, 1564
.   : milestone, 1552,
appsec (2.68 ms) : 2619, 2741
.   : milestone, 2680,
iast (2.344 ms) : 2273, 2414
.   : milestone, 2344,
iast_GLOBAL (2.424 ms) : 2351, 2498
.   : milestone, 2424,
profiling (2.201 ms) : 2141, 2261
.   : milestone, 2201,
tracing (2.176 ms) : 2117, 2234
.   : milestone, 2176,
section candidate
no_agent (1.545 ms) : 1532, 1558
.   : milestone, 1545,
appsec (2.697 ms) : 2636, 2757
.   : milestone, 2697,
iast (2.344 ms) : 2273, 2414
.   : milestone, 2344,
iast_GLOBAL (2.394 ms) : 2324, 2465
.   : milestone, 2394,
profiling (2.217 ms) : 2155, 2279
.   : milestone, 2217,
tracing (2.163 ms) : 2105, 2220
.   : milestone, 2163,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.552 ms [1.539 ms, 1.564 ms] -
appsec 2.68 ms [2.619 ms, 2.741 ms] 1.128 ms (72.7%)
iast 2.344 ms [2.273 ms, 2.414 ms] 791.963 µs (51.0%)
iast_GLOBAL 2.424 ms [2.351 ms, 2.498 ms] 872.584 µs (56.2%)
profiling 2.201 ms [2.141 ms, 2.261 ms] 649.596 µs (41.9%)
tracing 2.176 ms [2.117 ms, 2.234 ms] 624.051 µs (40.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.545 ms [1.532 ms, 1.558 ms] -
appsec 2.697 ms [2.636 ms, 2.757 ms] 1.152 ms (74.6%)
iast 2.344 ms [2.273 ms, 2.414 ms] 798.922 µs (51.7%)
iast_GLOBAL 2.394 ms [2.324 ms, 2.465 ms] 849.744 µs (55.0%)
profiling 2.217 ms [2.155 ms, 2.279 ms] 672.324 µs (43.5%)
tracing 2.163 ms [2.105 ms, 2.22 ms] 617.896 µs (40.0%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/lib-catalog
git_commit_date 1719219814 1719226981
git_commit_sha 46c883a cb08639
See matching parameters
Baseline Candidate
ci_job_date 1719228846 1719228846
ci_job_id 551476768 551476768
ci_pipeline_id 37402564 37402564
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/lib-catalog
git_commit_date 1719219814 1719226981
git_commit_sha 46c883a cb08639
See matching parameters
Baseline Candidate
ci_job_date 1719228759 1719228759
ci_job_id 551476769 551476769
ci_pipeline_id 37402564 37402564
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[-6904.384op/s; -730.853op/s] or [-3.941%; -0.417%]

@PerfectSlayer PerfectSlayer added type: refactoring and removed tag: experimental Experimental changes labels Jun 24, 2024
@PerfectSlayer PerfectSlayer marked this pull request as ready for review June 24, 2024 12:11
@PerfectSlayer PerfectSlayer requested review from a team as code owners June 24, 2024 12:11
@PerfectSlayer PerfectSlayer requested review from smola, jandro996, cimi, juan-fernandez, ygree and nayeem-kamal and removed request for a team June 24, 2024 12:11
@PerfectSlayer PerfectSlayer merged commit 2d36ca7 into master Jun 24, 2024
84 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/lib-catalog branch June 24, 2024 14:47
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 24, 2024
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants