Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avro instrumentation for schema tracking #7236

Merged
merged 18 commits into from
Jun 27, 2024
Merged

Avro instrumentation for schema tracking #7236

merged 18 commits into from
Jun 27, 2024

Conversation

nayeem-kamal
Copy link
Contributor

@nayeem-kamal nayeem-kamal commented Jun 24, 2024 •
edited by jira bot
Loading

What Does This Do

Adds schema tracking functionality for Avro's serializing library

Motivation

Additional Notes

Jira ticket: AIT-10052

@pr-commenter
Copy link

pr-commenter bot commented Jun 24, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nayeem-kamal/avro-integration-datumreader
git_commit_date 1719434594 1719448262
git_commit_sha 2f63f03 dc5f4fb
release_version 1.36.0-SNAPSHOT~2f63f03a0d 1.36.0-SNAPSHOT~dc5f4fb76e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719451376 1719451376
ci_job_id 554208406 554208406
ci_pipeline_id 37636860 37636860
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config worse
[+16.148µs; +75.099µs] or [+2.365%; +10.997%]		 728.541µs 682.917µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060415
Total [baseline] (10.313 s) : 0, 10313058
Agent [candidate] (1.061 s) : 0, 1061488
Total [candidate] (10.334 s) : 0, 10334268
section appsec
Agent [baseline] (1.186 s) : 0, 1186418
Total [baseline] (10.444 s) : 0, 10443535
Agent [candidate] (1.18 s) : 0, 1179706
Total [candidate] (10.42 s) : 0, 10420339
section iast
Agent [baseline] (1.168 s) : 0, 1167941
Total [baseline] (10.671 s) : 0, 10671203
Agent [candidate] (1.186 s) : 0, 1186494
Total [candidate] (10.833 s) : 0, 10833228
section profiling
Agent [baseline] (1.266 s) : 0, 1265938
Total [baseline] (10.595 s) : 0, 10595381
Agent [candidate] (1.27 s) : 0, 1270176
Total [candidate] (10.692 s) : 0, 10691913
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.186 s 126.003 ms (11.9%)
Agent iast 1.168 s 107.526 ms (10.1%)
Agent profiling 1.266 s 205.523 ms (19.4%)
Total tracing 10.313 s -
Total appsec 10.444 s 130.477 ms (1.3%)
Total iast 10.671 s 358.145 ms (3.5%)
Total profiling 10.595 s 282.323 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.18 s 118.218 ms (11.1%)
Agent iast 1.186 s 125.006 ms (11.8%)
Agent profiling 1.27 s 208.688 ms (19.7%)
Total tracing 10.334 s -
Total appsec 10.42 s 86.071 ms (0.8%)
Total iast 10.833 s 498.959 ms (4.8%)
Total profiling 10.692 s 357.645 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.573 ms) : 0, 664573
BytebuddyAgent [candidate] (665.4 ms) : 0, 665400
GlobalTracer [baseline] (303.51 ms) : 0, 303510
GlobalTracer [candidate] (303.3 ms) : 0, 303300
AppSec [baseline] (49.66 ms) : 0, 49660
AppSec [candidate] (50.148 ms) : 0, 50148
Remote Config [baseline] (691.096 µs) : 0, 691
Remote Config [candidate] (680.043 µs) : 0, 680
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.551 ms) : 0, 7551
section appsec
BytebuddyAgent [baseline] (677.455 ms) : 0, 677455
BytebuddyAgent [candidate] (674.539 ms) : 0, 674539
GlobalTracer [baseline] (299.552 ms) : 0, 299552
GlobalTracer [candidate] (297.133 ms) : 0, 297133
AppSec [baseline] (153.672 ms) : 0, 153672
AppSec [candidate] (153.678 ms) : 0, 153678
IAST [baseline] (22.534 ms) : 0, 22534
IAST [candidate] (19.679 ms) : 0, 19679
Remote Config [baseline] (640.109 µs) : 0, 640
Remote Config [candidate] (632.983 µs) : 0, 633
Telemetry [baseline] (9.388 ms) : 0, 9388
Telemetry [candidate] (9.472 ms) : 0, 9472
section iast
BytebuddyAgent [baseline] (778.652 ms) : 0, 778652
BytebuddyAgent [candidate] (789.398 ms) : 0, 789398
GlobalTracer [baseline] (293.965 ms) : 0, 293965
GlobalTracer [candidate] (298.78 ms) : 0, 298780
AppSec [baseline] (47.108 ms) : 0, 47108
AppSec [candidate] (47.93 ms) : 0, 47930
IAST [baseline] (27.389 ms) : 0, 27389
IAST [candidate] (29.214 ms) : 0, 29214
Remote Config [baseline] (618.245 µs) : 0, 618
Remote Config [candidate] (638.896 µs) : 0, 639
Telemetry [baseline] (6.963 ms) : 0, 6963
Telemetry [candidate] (7.046 ms) : 0, 7046
section profiling
BytebuddyAgent [baseline] (664.447 ms) : 0, 664447
BytebuddyAgent [candidate] (667.111 ms) : 0, 667111
GlobalTracer [baseline] (388.829 ms) : 0, 388829
GlobalTracer [candidate] (388.159 ms) : 0, 388159
AppSec [baseline] (51.162 ms) : 0, 51162
AppSec [candidate] (52.04 ms) : 0, 52040
Remote Config [baseline] (682.917 µs) : 0, 683
Remote Config [candidate] (728.541 µs) : 0, 729
Telemetry [baseline] (7.393 ms) : 0, 7393
Telemetry [candidate] (7.39 ms) : 0, 7390
ProfilingAgent [baseline] (96.092 ms) : 0, 96092
ProfilingAgent [candidate] (97.453 ms) : 0, 97453
Profiling [baseline] (96.116 ms) : 0, 96116
Profiling [candidate] (97.478 ms) : 0, 97478
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066952
Total [baseline] (8.532 s) : 0, 8532302
Agent [candidate] (1.062 s) : 0, 1061568
Total [candidate] (8.546 s) : 0, 8546189
section iast
Agent [baseline] (1.17 s) : 0, 1169588
Total [baseline] (8.972 s) : 0, 8972398
Agent [candidate] (1.166 s) : 0, 1166217
Total [candidate] (8.978 s) : 0, 8978144
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174009
Total [baseline] (8.992 s) : 0, 8992252
Agent [candidate] (1.169 s) : 0, 1168522
Total [candidate] (9.006 s) : 0, 9005969
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163130
Total [baseline] (8.999 s) : 0, 8999461
Agent [candidate] (1.161 s) : 0, 1160820
Total [candidate] (8.969 s) : 0, 8968541
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.17 s 102.635 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 107.057 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.163 s 96.177 ms (9.0%)
Total tracing 8.532 s -
Total iast 8.972 s 440.095 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.992 s 459.949 ms (5.4%)
Total iast_TELEMETRY_OFF 8.999 s 467.158 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.166 s 104.65 ms (9.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 106.955 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.161 s 99.252 ms (9.3%)
Total tracing 8.546 s -
Total iast 8.978 s 431.955 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.006 s 459.78 ms (5.4%)
Total iast_TELEMETRY_OFF 8.969 s 422.352 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.643 ms) : 0, 668643
BytebuddyAgent [candidate] (665.113 ms) : 0, 665113
GlobalTracer [baseline] (305.768 ms) : 0, 305768
GlobalTracer [candidate] (303.593 ms) : 0, 303593
AppSec [baseline] (49.91 ms) : 0, 49910
AppSec [candidate] (50.21 ms) : 0, 50210
Remote Config [baseline] (705.417 µs) : 0, 705
Remote Config [candidate] (685.338 µs) : 0, 685
Telemetry [baseline] (7.491 ms) : 0, 7491
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast
BytebuddyAgent [baseline] (780.038 ms) : 0, 780038
BytebuddyAgent [candidate] (777.549 ms) : 0, 777549
GlobalTracer [baseline] (293.611 ms) : 0, 293611
GlobalTracer [candidate] (293.276 ms) : 0, 293276
AppSec [baseline] (47.124 ms) : 0, 47124
AppSec [candidate] (47.21 ms) : 0, 47210
IAST [baseline] (28.125 ms) : 0, 28125
IAST [candidate] (27.371 ms) : 0, 27371
Remote Config [baseline] (563.771 µs) : 0, 564
Remote Config [candidate] (599.165 µs) : 0, 599
Telemetry [baseline] (6.886 ms) : 0, 6886
Telemetry [candidate] (6.932 ms) : 0, 6932
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.049 ms) : 0, 782049
BytebuddyAgent [candidate] (778.512 ms) : 0, 778512
GlobalTracer [baseline] (294.839 ms) : 0, 294839
GlobalTracer [candidate] (293.582 ms) : 0, 293582
AppSec [baseline] (47.342 ms) : 0, 47342
AppSec [candidate] (47.228 ms) : 0, 47228
IAST [baseline] (27.436 ms) : 0, 27436
IAST [candidate] (28.242 ms) : 0, 28242
Remote Config [baseline] (582.728 µs) : 0, 583
Remote Config [candidate] (627.337 µs) : 0, 627
Telemetry [baseline] (8.443 ms) : 0, 8443
Telemetry [candidate] (7.021 ms) : 0, 7021
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (773.682 ms) : 0, 773682
BytebuddyAgent [candidate] (772.926 ms) : 0, 772926
GlobalTracer [baseline] (293.183 ms) : 0, 293183
GlobalTracer [candidate] (292.534 ms) : 0, 292534
AppSec [baseline] (46.924 ms) : 0, 46924
AppSec [candidate] (46.601 ms) : 0, 46601
IAST [baseline] (28.606 ms) : 0, 28606
IAST [candidate] (26.572 ms) : 0, 26572
Remote Config [baseline] (595.263 µs) : 0, 595
Remote Config [candidate] (584.976 µs) : 0, 585
Telemetry [baseline] (6.838 ms) : 0, 6838
Telemetry [candidate] (8.361 ms) : 0, 8361
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-27T00:53:37 2024-06-27T01:00:30
git_branch master nayeem-kamal/avro-integration-datumreader
git_commit_date 1719434594 1719448262
git_commit_sha 2f63f03 dc5f4fb
release_version 1.36.0-SNAPSHOT~2f63f03a0d 1.36.0-SNAPSHOT~dc5f4fb76e
start_time 2024-06-27T00:53:23 2024-06-27T01:00:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719450378 1719450378
ci_job_id 554208407 554208407
ci_pipeline_id 37636860 37636860
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.027 µs) : 355, 395
.   : milestone, 375,
iast (497.908 µs) : 477, 519
.   : milestone, 498,
iast_FULL (564.888 µs) : 544, 586
.   : milestone, 565,
iast_GLOBAL (508.954 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (494.157 µs) : 473, 516
.   : milestone, 494,
iast_INACTIVE (463.611 µs) : 442, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (481.158 µs) : 460, 502
.   : milestone, 481,
tracing (455.831 µs) : 434, 477
.   : milestone, 456,
section candidate
no_agent (381.478 µs) : 359, 404
.   : milestone, 381,
iast (497.175 µs) : 475, 519
.   : milestone, 497,
iast_FULL (562.127 µs) : 541, 584
.   : milestone, 562,
iast_GLOBAL (517.31 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (490.801 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (460.543 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (484.262 µs) : 463, 506
.   : milestone, 484,
tracing (449.322 µs) : 429, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.027 µs [354.68 µs, 395.374 µs] -
iast 497.908 µs [476.611 µs, 519.206 µs] 122.881 µs (32.8%)
iast_FULL 564.888 µs [543.786 µs, 585.991 µs] 189.861 µs (50.6%)
iast_GLOBAL 508.954 µs [487.875 µs, 530.033 µs] 133.927 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED 494.157 µs [472.733 µs, 515.58 µs] 119.129 µs (31.8%)
iast_INACTIVE 463.611 µs [442.332 µs, 484.89 µs] 88.584 µs (23.6%)
iast_TELEMETRY_OFF 481.158 µs [459.903 µs, 502.413 µs] 106.131 µs (28.3%)
tracing 455.831 µs [434.38 µs, 477.281 µs] 80.804 µs (21.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.478 µs [359.382 µs, 403.573 µs] -
iast 497.175 µs [475.03 µs, 519.32 µs] 115.697 µs (30.3%)
iast_FULL 562.127 µs [540.741 µs, 583.512 µs] 180.649 µs (47.4%)
iast_GLOBAL 517.31 µs [495.331 µs, 539.288 µs] 135.832 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 490.801 µs [469.475 µs, 512.127 µs] 109.323 µs (28.7%)
iast_INACTIVE 460.543 µs [439.539 µs, 481.547 µs] 79.066 µs (20.7%)
iast_TELEMETRY_OFF 484.262 µs [462.82 µs, 505.703 µs] 102.784 µs (26.9%)
tracing 449.322 µs [428.954 µs, 469.691 µs] 67.845 µs (17.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.379 ms) : 1360, 1398
.   : milestone, 1379,
appsec (1.714 ms) : 1689, 1739
.   : milestone, 1714,
appsec_no_iast (1.744 ms) : 1720, 1768
.   : milestone, 1744,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.507 ms) : 1483, 1532
.   : milestone, 1507,
tracing (1.46 ms) : 1435, 1484
.   : milestone, 1460,
section candidate
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.712 ms) : 1687, 1736
.   : milestone, 1712,
appsec_no_iast (1.711 ms) : 1686, 1736
.   : milestone, 1711,
iast (1.504 ms) : 1482, 1526
.   : milestone, 1504,
profiling (1.521 ms) : 1494, 1547
.   : milestone, 1521,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.379 ms [1.36 ms, 1.398 ms] -
appsec 1.714 ms [1.689 ms, 1.739 ms] 335.576 µs (24.3%)
appsec_no_iast 1.744 ms [1.72 ms, 1.768 ms] 365.172 µs (26.5%)
iast 1.491 ms [1.468 ms, 1.514 ms] 112.294 µs (8.1%)
profiling 1.507 ms [1.483 ms, 1.532 ms] 128.704 µs (9.3%)
tracing 1.46 ms [1.435 ms, 1.484 ms] 80.989 µs (5.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.712 ms [1.687 ms, 1.736 ms] 379.69 µs (28.5%)
appsec_no_iast 1.711 ms [1.686 ms, 1.736 ms] 379.18 µs (28.5%)
iast 1.504 ms [1.482 ms, 1.526 ms] 172.241 µs (12.9%)
profiling 1.521 ms [1.494 ms, 1.547 ms] 188.714 µs (14.2%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 150.394 µs (11.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nayeem-kamal/avro-integration-datumreader
git_commit_date 1719434594 1719448262
git_commit_sha 2f63f03 dc5f4fb
release_version 1.36.0-SNAPSHOT~2f63f03a0d 1.36.0-SNAPSHOT~dc5f4fb76e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719450874 1719450874
ci_job_id 554208408 554208408
ci_pipeline_id 37636860 37636860
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.426 s) : 15426000, 15426000
.   : milestone, 15426000,
appsec (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
iast (18.995 s) : 18995000, 18995000
.   : milestone, 18995000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
profiling (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
tracing (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
section candidate
no_agent (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
appsec (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
iast (18.787 s) : 18787000, 18787000
.   : milestone, 18787000,
iast_GLOBAL (17.687 s) : 17687000, 17687000
.   : milestone, 17687000,
profiling (15.481 s) : 15481000, 15481000
.   : milestone, 15481000,
tracing (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.426 s [15.426 s, 15.426 s] -
appsec 15.17 s [15.17 s, 15.17 s] -256.0 ms (-1.7%)
iast 18.995 s [18.995 s, 18.995 s] 3.569 s (23.1%)
iast_GLOBAL 17.947 s [17.947 s, 17.947 s] 2.521 s (16.3%)
profiling 15.047 s [15.047 s, 15.047 s] -379.0 ms (-2.5%)
tracing 15.022 s [15.022 s, 15.022 s] -404.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.075 s [15.075 s, 15.075 s] -
appsec 14.928 s [14.928 s, 14.928 s] -147.0 ms (-1.0%)
iast 18.787 s [18.787 s, 18.787 s] 3.712 s (24.6%)
iast_GLOBAL 17.687 s [17.687 s, 17.687 s] 2.612 s (17.3%)
profiling 15.481 s [15.481 s, 15.481 s] 406.0 ms (2.7%)
tracing 14.997 s [14.997 s, 14.997 s] -78.0 ms (-0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~dc5f4fb76e, baseline=1.36.0-SNAPSHOT~2f63f03a0d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.218 ms) : 2184, 2253
.   : milestone, 2218,
iast (1.975 ms) : 1934, 2016
.   : milestone, 1975,
iast_GLOBAL (2.013 ms) : 1972, 2053
.   : milestone, 2013,
profiling (2.322 ms) : 2144, 2501
.   : milestone, 2322,
tracing (1.841 ms) : 1809, 1874
.   : milestone, 1841,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.22 ms) : 2186, 2254
.   : milestone, 2220,
iast (1.983 ms) : 1941, 2025
.   : milestone, 1983,
iast_GLOBAL (2.011 ms) : 1970, 2052
.   : milestone, 2011,
profiling (1.87 ms) : 1836, 1903
.   : milestone, 1870,
tracing (1.845 ms) : 1812, 1877
.   : milestone, 1845,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.218 ms [2.184 ms, 2.253 ms] 754.647 µs (51.6%)
iast 1.975 ms [1.934 ms, 2.016 ms] 512.009 µs (35.0%)
iast_GLOBAL 2.013 ms [1.972 ms, 2.053 ms] 549.118 µs (37.5%)
profiling 2.322 ms [2.144 ms, 2.501 ms] 858.851 µs (58.7%)
tracing 1.841 ms [1.809 ms, 1.874 ms] 377.834 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.22 ms [2.186 ms, 2.254 ms] 752.346 µs (51.3%)
iast 1.983 ms [1.941 ms, 2.025 ms] 515.556 µs (35.1%)
iast_GLOBAL 2.011 ms [1.97 ms, 2.052 ms] 543.584 µs (37.0%)
profiling 1.87 ms [1.836 ms, 1.903 ms] 402.163 µs (27.4%)
tracing 1.845 ms [1.812 ms, 1.877 ms] 376.857 µs (25.7%)

@nayeem-kamal nayeem-kamal marked this pull request as ready for review June 27, 2024 00:34
@nayeem-kamal nayeem-kamal requested review from a team as code owners June 27, 2024 00:34
@nayeem-kamal nayeem-kamal added the comp: data streams Data Streams Monitoring label Jun 27, 2024
@nayeem-kamal nayeem-kamal changed the title [WIP] Alternative Avro instrumentation Avro instrumentation for schema tracking Jun 27, 2024
@nayeem-kamal nayeem-kamal merged commit 001c89e into master Jun 27, 2024
82 checks passed
@nayeem-kamal nayeem-kamal deleted the nayeem-kamal/avro-integration-datumreader branch June 27, 2024 01:39
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 27, 2024
PerfectSlayer
PerfectSlayer reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see compileOnly solved your issue!

@PerfectSlayer PerfectSlayer added the inst: others All other instrumentations label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@piochelepiotr piochelepiotr piochelepiotr approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: data streams Data Streams Monitoring inst: others All other instrumentations
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nayeem-kamal @mcculls @PerfectSlayer @piochelepiotr