Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Span Decoration probe evaluateAt=ENTRY #7238

Closed
wants to merge 1 commit into from

Conversation

jpbempel
Copy link
Member

What Does This Do

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2024

Benchmarks

Startup

Load

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-span-deco-entry
git_commit_date 1719309238 1719325998
git_commit_sha d19ceac 3554ced
release_version 1.36.0-SNAPSHOT~d19ceac03e 1.36.0-SNAPSHOT~3554ced5bf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719328735 1719328735
ci_job_id 552738505 552738505
ci_pipeline_id 37509168 37509168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~3554ced5bf, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.218 ms) : 2184, 2253
.   : milestone, 2218,
iast (1.978 ms) : 1936, 2021
.   : milestone, 1978,
iast_GLOBAL (2.025 ms) : 1983, 2067
.   : milestone, 2025,
profiling (1.861 ms) : 1828, 1895
.   : milestone, 1861,
tracing (1.839 ms) : 1807, 1872
.   : milestone, 1839,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.232 ms) : 2198, 2267
.   : milestone, 2232,
iast (1.975 ms) : 1934, 2016
.   : milestone, 1975,
iast_GLOBAL (2.015 ms) : 1973, 2057
.   : milestone, 2015,
profiling (1.862 ms) : 1829, 1896
.   : milestone, 1862,
tracing (1.836 ms) : 1805, 1868
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.218 ms [2.184 ms, 2.253 ms] 749.256 µs (51.0%)
iast 1.978 ms [1.936 ms, 2.021 ms] 509.331 µs (34.7%)
iast_GLOBAL 2.025 ms [1.983 ms, 2.067 ms] 555.878 µs (37.8%)
profiling 1.861 ms [1.828 ms, 1.895 ms] 392.089 µs (26.7%)
tracing 1.839 ms [1.807 ms, 1.872 ms] 370.216 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.232 ms [2.198 ms, 2.267 ms] 772.605 µs (52.9%)
iast 1.975 ms [1.934 ms, 2.016 ms] 515.319 µs (35.3%)
iast_GLOBAL 2.015 ms [1.973 ms, 2.057 ms] 555.001 µs (38.0%)
profiling 1.862 ms [1.829 ms, 1.896 ms] 402.52 µs (27.6%)
tracing 1.836 ms [1.805 ms, 1.868 ms] 376.614 µs (25.8%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~3554ced5bf, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
appsec (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
iast (18.864 s) : 18864000, 18864000
.   : milestone, 18864000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
.   : milestone, 18036000,
profiling (15.24 s) : 15240000, 15240000
.   : milestone, 15240000,
tracing (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
section candidate
no_agent (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
appsec (14.773 s) : 14773000, 14773000
.   : milestone, 14773000,
iast (18.673 s) : 18673000, 18673000
.   : milestone, 18673000,
iast_GLOBAL (17.918 s) : 17918000, 17918000
.   : milestone, 17918000,
profiling (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
tracing (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.023 s [15.023 s, 15.023 s] -
appsec 15.215 s [15.215 s, 15.215 s] 192.0 ms (1.3%)
iast 18.864 s [18.864 s, 18.864 s] 3.841 s (25.6%)
iast_GLOBAL 18.036 s [18.036 s, 18.036 s] 3.013 s (20.1%)
profiling 15.24 s [15.24 s, 15.24 s] 217.0 ms (1.4%)
tracing 15.077 s [15.077 s, 15.077 s] 54.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.141 s [15.141 s, 15.141 s] -
appsec 14.773 s [14.773 s, 14.773 s] -368.0 ms (-2.4%)
iast 18.673 s [18.673 s, 18.673 s] 3.532 s (23.3%)
iast_GLOBAL 17.918 s [17.918 s, 17.918 s] 2.777 s (18.3%)
profiling 15.095 s [15.095 s, 15.095 s] -46.0 ms (-0.3%)
tracing 14.974 s [14.974 s, 14.974 s] -167.0 ms (-1.1%)

@jpbempel jpbempel closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant