Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language detection logic #7245

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Fix language detection logic #7245

merged 6 commits into from
Jun 28, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 26, 2024 •
edited
Loading

What Does This Do

Fixes the logic that detects language for a class.

Motivation

Currently the logic is broken for:

  • Groovy classes that inherit from other Groovy classes
  • Groovy interfaces and annotations
  • certain Scala classes and objects

Jira ticket: SDTEST-494

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Jun 26, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-language-detection
git_commit_date 1719496894 1719500859
git_commit_sha 8daf509 51ee200
release_version 1.37.0-SNAPSHOT~8daf50933c 1.36.0-SNAPSHOT~51ee20028e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719504035 1719504035
ci_job_id 555029989 555029989
ci_pipeline_id 37711080 37711080
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065897
Total [baseline] (10.394 s) : 0, 10394123
Agent [candidate] (1.065 s) : 0, 1064926
Total [candidate] (10.35 s) : 0, 10350249
section appsec
Agent [baseline] (1.184 s) : 0, 1184057
Total [baseline] (10.494 s) : 0, 10493601
Agent [candidate] (1.188 s) : 0, 1188067
Total [candidate] (10.459 s) : 0, 10458647
section iast
Agent [baseline] (1.171 s) : 0, 1171391
Total [baseline] (10.828 s) : 0, 10828054
Agent [candidate] (1.171 s) : 0, 1171326
Total [candidate] (10.72 s) : 0, 10719519
section profiling
Agent [baseline] (1.272 s) : 0, 1271870
Total [baseline] (10.58 s) : 0, 10579937
Agent [candidate] (1.271 s) : 0, 1270614
Total [candidate] (10.748 s) : 0, 10747753
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.184 s 118.16 ms (11.1%)
Agent iast 1.171 s 105.494 ms (9.9%)
Agent profiling 1.272 s 205.972 ms (19.3%)
Total tracing 10.394 s -
Total appsec 10.494 s 99.478 ms (1.0%)
Total iast 10.828 s 433.931 ms (4.2%)
Total profiling 10.58 s 185.814 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.188 s 123.141 ms (11.6%)
Agent iast 1.171 s 106.4 ms (10.0%)
Agent profiling 1.271 s 205.688 ms (19.3%)
Total tracing 10.35 s -
Total appsec 10.459 s 108.399 ms (1.0%)
Total iast 10.72 s 369.271 ms (3.6%)
Total profiling 10.748 s 397.504 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.288 ms) : 0, 667288
BytebuddyAgent [candidate] (666.334 ms) : 0, 666334
GlobalTracer [baseline] (305.644 ms) : 0, 305644
GlobalTracer [candidate] (305.775 ms) : 0, 305775
AppSec [baseline] (50.066 ms) : 0, 50066
AppSec [candidate] (50.051 ms) : 0, 50051
Remote Config [baseline] (745.449 µs) : 0, 745
Remote Config [candidate] (708.982 µs) : 0, 709
Telemetry [baseline] (7.662 ms) : 0, 7662
Telemetry [candidate] (7.571 ms) : 0, 7571
section appsec
BytebuddyAgent [baseline] (677.777 ms) : 0, 677777
BytebuddyAgent [candidate] (679.669 ms) : 0, 679669
GlobalTracer [baseline] (298.448 ms) : 0, 298448
GlobalTracer [candidate] (299.681 ms) : 0, 299681
AppSec [baseline] (153.658 ms) : 0, 153658
AppSec [candidate] (154.407 ms) : 0, 154407
Remote Config [baseline] (639.094 µs) : 0, 639
Remote Config [candidate] (639.306 µs) : 0, 639
Telemetry [baseline] (7.798 ms) : 0, 7798
Telemetry [candidate] (8.178 ms) : 0, 8178
IAST [baseline] (22.449 ms) : 0, 22449
IAST [candidate] (21.742 ms) : 0, 21742
section iast
BytebuddyAgent [baseline] (780.211 ms) : 0, 780211
BytebuddyAgent [candidate] (779.806 ms) : 0, 779806
GlobalTracer [baseline] (294.287 ms) : 0, 294287
GlobalTracer [candidate] (294.105 ms) : 0, 294105
AppSec [baseline] (47.257 ms) : 0, 47257
AppSec [candidate] (47.155 ms) : 0, 47155
Remote Config [baseline] (614.37 µs) : 0, 614
Remote Config [candidate] (563.487 µs) : 0, 563
Telemetry [baseline] (7.032 ms) : 0, 7032
Telemetry [candidate] (6.835 ms) : 0, 6835
IAST [baseline] (28.693 ms) : 0, 28693
IAST [candidate] (29.553 ms) : 0, 29553
section profiling
BytebuddyAgent [baseline] (667.507 ms) : 0, 667507
BytebuddyAgent [candidate] (667.225 ms) : 0, 667225
GlobalTracer [baseline] (390.339 ms) : 0, 390339
GlobalTracer [candidate] (388.178 ms) : 0, 388178
AppSec [baseline] (51.647 ms) : 0, 51647
AppSec [candidate] (52.03 ms) : 0, 52030
Remote Config [baseline] (673.576 µs) : 0, 674
Remote Config [candidate] (676.495 µs) : 0, 676
Telemetry [baseline] (7.436 ms) : 0, 7436
Telemetry [candidate] (7.445 ms) : 0, 7445
ProfilingAgent [baseline] (96.799 ms) : 0, 96799
ProfilingAgent [candidate] (97.494 ms) : 0, 97494
Profiling [baseline] (96.823 ms) : 0, 96823
Profiling [candidate] (97.52 ms) : 0, 97520
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064838
Total [baseline] (8.552 s) : 0, 8551948
Agent [candidate] (1.065 s) : 0, 1064970
Total [candidate] (8.544 s) : 0, 8543944
section iast
Agent [baseline] (1.179 s) : 0, 1178812
Total [baseline] (9.022 s) : 0, 9022159
Agent [candidate] (1.169 s) : 0, 1169406
Total [candidate] (9.008 s) : 0, 9008478
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175653
Total [baseline] (8.984 s) : 0, 8983610
Agent [candidate] (1.172 s) : 0, 1172148
Total [candidate] (8.986 s) : 0, 8986221
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169232
Total [baseline] (8.992 s) : 0, 8991908
Agent [candidate] (1.168 s) : 0, 1168348
Total [candidate] (9.0 s) : 0, 8999585
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.179 s 113.974 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 110.815 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.169 s 104.394 ms (9.8%)
Total tracing 8.552 s -
Total iast 9.022 s 470.21 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.984 s 431.662 ms (5.0%)
Total iast_TELEMETRY_OFF 8.992 s 439.96 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.169 s 104.436 ms (9.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 107.178 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.168 s 103.378 ms (9.7%)
Total tracing 8.544 s -
Total iast 9.008 s 464.534 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.986 s 442.277 ms (5.2%)
Total iast_TELEMETRY_OFF 9.0 s 455.641 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.424 ms) : 0, 666424
BytebuddyAgent [candidate] (666.274 ms) : 0, 666274
GlobalTracer [baseline] (305.615 ms) : 0, 305615
GlobalTracer [candidate] (305.703 ms) : 0, 305703
AppSec [baseline] (49.901 ms) : 0, 49901
AppSec [candidate] (50.182 ms) : 0, 50182
Remote Config [baseline] (772.875 µs) : 0, 773
Remote Config [candidate] (766.357 µs) : 0, 766
Telemetry [baseline] (7.691 ms) : 0, 7691
Telemetry [candidate] (7.658 ms) : 0, 7658
section iast
BytebuddyAgent [baseline] (785.574 ms) : 0, 785574
BytebuddyAgent [candidate] (779.34 ms) : 0, 779340
GlobalTracer [baseline] (296.145 ms) : 0, 296145
GlobalTracer [candidate] (294.438 ms) : 0, 294438
AppSec [baseline] (47.314 ms) : 0, 47314
AppSec [candidate] (46.9 ms) : 0, 46900
Remote Config [baseline] (646.547 µs) : 0, 647
Remote Config [candidate] (611.953 µs) : 0, 612
Telemetry [baseline] (6.979 ms) : 0, 6979
Telemetry [candidate] (7.637 ms) : 0, 7637
IAST [baseline] (28.811 ms) : 0, 28811
IAST [candidate] (27.213 ms) : 0, 27213
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.679 ms) : 0, 784679
BytebuddyAgent [candidate] (779.983 ms) : 0, 779983
GlobalTracer [baseline] (294.65 ms) : 0, 294650
GlobalTracer [candidate] (294.878 ms) : 0, 294878
AppSec [baseline] (47.271 ms) : 0, 47271
AppSec [candidate] (47.263 ms) : 0, 47263
Remote Config [baseline] (613.441 µs) : 0, 613
Remote Config [candidate] (597.035 µs) : 0, 597
Telemetry [baseline] (6.966 ms) : 0, 6966
Telemetry [candidate] (6.905 ms) : 0, 6905
IAST [baseline] (28.089 ms) : 0, 28089
IAST [candidate] (29.174 ms) : 0, 29174
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.474 ms) : 0, 778474
BytebuddyAgent [candidate] (777.822 ms) : 0, 777822
GlobalTracer [baseline] (295.533 ms) : 0, 295533
GlobalTracer [candidate] (294.644 ms) : 0, 294644
AppSec [baseline] (46.859 ms) : 0, 46859
AppSec [candidate] (47.243 ms) : 0, 47243
Remote Config [baseline] (611.303 µs) : 0, 611
Remote Config [candidate] (608.484 µs) : 0, 608
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (9.146 ms) : 0, 9146
IAST [baseline] (26.882 ms) : 0, 26882
IAST [candidate] (25.526 ms) : 0, 25526
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-27T15:33:06 2024-06-27T15:39:54
git_branch master nikita-tkachenko/fix-language-detection
git_commit_date 1719496894 1719500859
git_commit_sha 8daf509 51ee200
release_version 1.37.0-SNAPSHOT~8daf50933c 1.36.0-SNAPSHOT~51ee20028e
start_time 2024-06-27T15:32:53 2024-06-27T15:39:40
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719503139 1719503139
ci_job_id 555029990 555029990
ci_pipeline_id 37711080 37711080
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.075 µs) : 349, 389
.   : milestone, 369,
iast (473.291 µs) : 452, 494
.   : milestone, 473,
iast_FULL (547.256 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (498.297 µs) : 477, 520
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (482.806 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (459.834 µs) : 438, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (461.937 µs) : 441, 483
.   : milestone, 462,
tracing (439.826 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (364.518 µs) : 345, 384
.   : milestone, 365,
iast (479.903 µs) : 458, 502
.   : milestone, 480,
iast_FULL (549.011 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (505.336 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (477.331 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (444.931 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (466.525 µs) : 445, 488
.   : milestone, 467,
tracing (439.55 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.075 µs [349.349 µs, 388.802 µs] -
iast 473.291 µs [452.368 µs, 494.214 µs] 104.215 µs (28.2%)
iast_FULL 547.256 µs [526.155 µs, 568.358 µs] 178.181 µs (48.3%)
iast_GLOBAL 498.297 µs [476.566 µs, 520.027 µs] 129.221 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 482.806 µs [461.148 µs, 504.465 µs] 113.731 µs (30.8%)
iast_INACTIVE 459.834 µs [438.331 µs, 481.337 µs] 90.759 µs (24.6%)
iast_TELEMETRY_OFF 461.937 µs [441.051 µs, 482.823 µs] 92.862 µs (25.2%)
tracing 439.826 µs [418.598 µs, 461.054 µs] 70.751 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.518 µs [345.274 µs, 383.762 µs] -
iast 479.903 µs [458.259 µs, 501.546 µs] 115.385 µs (31.7%)
iast_FULL 549.011 µs [527.541 µs, 570.48 µs] 184.493 µs (50.6%)
iast_GLOBAL 505.336 µs [483.401 µs, 527.272 µs] 140.818 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 477.331 µs [456.188 µs, 498.474 µs] 112.813 µs (30.9%)
iast_INACTIVE 444.931 µs [424.081 µs, 465.781 µs] 80.413 µs (22.1%)
iast_TELEMETRY_OFF 466.525 µs [445.353 µs, 487.697 µs] 102.007 µs (28.0%)
tracing 439.55 µs [418.664 µs, 460.435 µs] 75.032 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.703 ms) : 1679, 1728
.   : milestone, 1703,
appsec_no_iast (1.73 ms) : 1706, 1754
.   : milestone, 1730,
iast (1.463 ms) : 1440, 1485
.   : milestone, 1463,
profiling (1.476 ms) : 1452, 1501
.   : milestone, 1476,
tracing (1.473 ms) : 1450, 1497
.   : milestone, 1473,
section candidate
no_agent (1.313 ms) : 1294, 1332
.   : milestone, 1313,
appsec (1.716 ms) : 1692, 1741
.   : milestone, 1716,
appsec_no_iast (1.712 ms) : 1689, 1736
.   : milestone, 1712,
iast (1.479 ms) : 1457, 1502
.   : milestone, 1479,
profiling (1.508 ms) : 1483, 1533
.   : milestone, 1508,
tracing (1.479 ms) : 1455, 1503
.   : milestone, 1479,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.359 ms] -
appsec 1.703 ms [1.679 ms, 1.728 ms] 364.171 µs (27.2%)
appsec_no_iast 1.73 ms [1.706 ms, 1.754 ms] 390.673 µs (29.2%)
iast 1.463 ms [1.44 ms, 1.485 ms] 123.369 µs (9.2%)
profiling 1.476 ms [1.452 ms, 1.501 ms] 136.986 µs (10.2%)
tracing 1.473 ms [1.45 ms, 1.497 ms] 134.173 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.313 ms [1.294 ms, 1.332 ms] -
appsec 1.716 ms [1.692 ms, 1.741 ms] 403.79 µs (30.8%)
appsec_no_iast 1.712 ms [1.689 ms, 1.736 ms] 399.799 µs (30.5%)
iast 1.479 ms [1.457 ms, 1.502 ms] 166.539 µs (12.7%)
profiling 1.508 ms [1.483 ms, 1.533 ms] 195.512 µs (14.9%)
tracing 1.479 ms [1.455 ms, 1.503 ms] 166.382 µs (12.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-language-detection
git_commit_date 1719496894 1719500859
git_commit_sha 8daf509 51ee200
release_version 1.37.0-SNAPSHOT~8daf50933c 1.36.0-SNAPSHOT~51ee20028e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719503540 1719503540
ci_job_id 555029992 555029992
ci_pipeline_id 37711080 37711080
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.169 s) : 15169000, 15169000
.   : milestone, 15169000,
appsec (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
iast (19.056 s) : 19056000, 19056000
.   : milestone, 19056000,
iast_GLOBAL (17.793 s) : 17793000, 17793000
.   : milestone, 17793000,
profiling (15.446 s) : 15446000, 15446000
.   : milestone, 15446000,
tracing (14.731 s) : 14731000, 14731000
.   : milestone, 14731000,
section candidate
no_agent (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
appsec (14.904 s) : 14904000, 14904000
.   : milestone, 14904000,
iast (18.608 s) : 18608000, 18608000
.   : milestone, 18608000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
.   : milestone, 17780000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.169 s [15.169 s, 15.169 s] -
appsec 15.008 s [15.008 s, 15.008 s] -161.0 ms (-1.1%)
iast 19.056 s [19.056 s, 19.056 s] 3.887 s (25.6%)
iast_GLOBAL 17.793 s [17.793 s, 17.793 s] 2.624 s (17.3%)
profiling 15.446 s [15.446 s, 15.446 s] 277.0 ms (1.8%)
tracing 14.731 s [14.731 s, 14.731 s] -438.0 ms (-2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.035 s [15.035 s, 15.035 s] -
appsec 14.904 s [14.904 s, 14.904 s] -131.0 ms (-0.9%)
iast 18.608 s [18.608 s, 18.608 s] 3.573 s (23.8%)
iast_GLOBAL 17.78 s [17.78 s, 17.78 s] 2.745 s (18.3%)
profiling 15.279 s [15.279 s, 15.279 s] 244.0 ms (1.6%)
tracing 14.966 s [14.966 s, 14.966 s] -69.0 ms (-0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~51ee20028e, baseline=1.37.0-SNAPSHOT~8daf50933c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.207 ms) : 2173, 2241
.   : milestone, 2207,
iast (1.973 ms) : 1932, 2015
.   : milestone, 1973,
iast_GLOBAL (2.008 ms) : 1967, 2050
.   : milestone, 2008,
profiling (1.848 ms) : 1815, 1882
.   : milestone, 1848,
tracing (1.837 ms) : 1805, 1869
.   : milestone, 1837,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.22 ms) : 2185, 2255
.   : milestone, 2220,
iast (1.966 ms) : 1925, 2008
.   : milestone, 1966,
iast_GLOBAL (2.007 ms) : 1965, 2048
.   : milestone, 2007,
profiling (1.846 ms) : 1812, 1881
.   : milestone, 1846,
tracing (1.837 ms) : 1805, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.207 ms [2.173 ms, 2.241 ms] 740.277 µs (50.5%)
iast 1.973 ms [1.932 ms, 2.015 ms] 506.412 µs (34.5%)
iast_GLOBAL 2.008 ms [1.967 ms, 2.05 ms] 541.168 µs (36.9%)
profiling 1.848 ms [1.815 ms, 1.882 ms] 381.516 µs (26.0%)
tracing 1.837 ms [1.805 ms, 1.869 ms] 370.308 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.22 ms [2.185 ms, 2.255 ms] 760.472 µs (52.1%)
iast 1.966 ms [1.925 ms, 2.008 ms] 506.552 µs (34.7%)
iast_GLOBAL 2.007 ms [1.965 ms, 2.048 ms] 546.909 µs (37.5%)
profiling 1.846 ms [1.812 ms, 1.881 ms] 386.35 µs (26.5%)
tracing 1.837 ms [1.805 ms, 1.87 ms] 377.584 µs (25.9%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 27, 2024 16:16
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 97b5fe7 into master Jun 28, 2024
82 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-language-detection branch June 28, 2024 08:22
@PerfectSlayer PerfectSlayer added this to the 1.37.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikita-tkachenko-datadog @anmarchenko @PerfectSlayer