Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set appsec.blocked in local root span #7251

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Set appsec.blocked in local root span #7251

merged 3 commits into from
Jul 1, 2024

Conversation

smola
Copy link
Member

@smola smola commented Jun 28, 2024 •
edited
Loading

What Does This Do

  • Always set appsec.blocked:true in the local root span.

Motivation

  • In some cases, such as mid-request blocks (e.g. path params, RASP) or certain web frameworks, a block will happen while the active span is not the root span. We use appsec.blocked to mark local roots, so make sure we always set the tag there.

Additional Notes

Jira ticket: APPSEC-53857

@smola smola added the comp: asm waf Application Security Management (WAF) label Jun 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/fix-appsec-blocked-root-span
git_commit_date 1719562931 1719570417
git_commit_sha 97b5fe7 ccfb03b
release_version 1.37.0-SNAPSHOT~97b5fe71f8 1.37.0-SNAPSHOT~ccfb03b59b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719580577 1719580577
ci_job_id 556374003 556374003
ci_pipeline_id 37844323 37844323
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062005
Total [baseline] (10.31 s) : 0, 10309623
Agent [candidate] (1.07 s) : 0, 1070255
Total [candidate] (10.338 s) : 0, 10337921
section appsec
Agent [baseline] (1.185 s) : 0, 1185165
Total [baseline] (10.518 s) : 0, 10517724
Agent [candidate] (1.187 s) : 0, 1186730
Total [candidate] (10.544 s) : 0, 10543509
section iast
Agent [baseline] (1.179 s) : 0, 1179053
Total [baseline] (10.818 s) : 0, 10817738
Agent [candidate] (1.172 s) : 0, 1172442
Total [candidate] (10.77 s) : 0, 10769893
section profiling
Agent [baseline] (1.284 s) : 0, 1283763
Total [baseline] (10.668 s) : 0, 10667739
Agent [candidate] (1.265 s) : 0, 1265101
Total [candidate] (10.583 s) : 0, 10583051
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.185 s 123.16 ms (11.6%)
Agent iast 1.179 s 117.048 ms (11.0%)
Agent profiling 1.284 s 221.758 ms (20.9%)
Total tracing 10.31 s -
Total appsec 10.518 s 208.101 ms (2.0%)
Total iast 10.818 s 508.115 ms (4.9%)
Total profiling 10.668 s 358.116 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.187 s 116.475 ms (10.9%)
Agent iast 1.172 s 102.187 ms (9.5%)
Agent profiling 1.265 s 194.845 ms (18.2%)
Total tracing 10.338 s -
Total appsec 10.544 s 205.588 ms (2.0%)
Total iast 10.77 s 431.973 ms (4.2%)
Total profiling 10.583 s 245.13 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.07 ms) : 0, 665070
BytebuddyAgent [candidate] (670.201 ms) : 0, 670201
GlobalTracer [baseline] (303.949 ms) : 0, 303949
GlobalTracer [candidate] (306.335 ms) : 0, 306335
AppSec [baseline] (50.118 ms) : 0, 50118
AppSec [candidate] (50.543 ms) : 0, 50543
Remote Config [baseline] (766.143 µs) : 0, 766
Remote Config [candidate] (750.691 µs) : 0, 751
Telemetry [baseline] (7.59 ms) : 0, 7590
Telemetry [candidate] (7.599 ms) : 0, 7599
section appsec
BytebuddyAgent [baseline] (678.423 ms) : 0, 678423
BytebuddyAgent [candidate] (678.567 ms) : 0, 678567
GlobalTracer [baseline] (298.8 ms) : 0, 298800
GlobalTracer [candidate] (299.026 ms) : 0, 299026
AppSec [baseline] (154.097 ms) : 0, 154097
AppSec [candidate] (154.171 ms) : 0, 154171
IAST [baseline] (20.264 ms) : 0, 20264
IAST [candidate] (21.878 ms) : 0, 21878
Remote Config [baseline] (632.508 µs) : 0, 633
Remote Config [candidate] (630.414 µs) : 0, 630
Telemetry [baseline] (8.401 ms) : 0, 8401
Telemetry [candidate] (8.713 ms) : 0, 8713
section iast
BytebuddyAgent [baseline] (784.923 ms) : 0, 784923
BytebuddyAgent [candidate] (780.227 ms) : 0, 780227
GlobalTracer [baseline] (295.98 ms) : 0, 295980
GlobalTracer [candidate] (294.937 ms) : 0, 294937
AppSec [baseline] (48.03 ms) : 0, 48030
AppSec [candidate] (47.266 ms) : 0, 47266
IAST [baseline] (29.033 ms) : 0, 29033
IAST [candidate] (29.008 ms) : 0, 29008
Remote Config [baseline] (609.084 µs) : 0, 609
Remote Config [candidate] (599.248 µs) : 0, 599
Telemetry [baseline] (7.02 ms) : 0, 7020
Telemetry [candidate] (6.945 ms) : 0, 6945
section profiling
BytebuddyAgent [baseline] (675.291 ms) : 0, 675291
BytebuddyAgent [candidate] (663.772 ms) : 0, 663772
GlobalTracer [baseline] (391.776 ms) : 0, 391776
GlobalTracer [candidate] (388.903 ms) : 0, 388903
AppSec [baseline] (52.459 ms) : 0, 52459
AppSec [candidate] (51.651 ms) : 0, 51651
Remote Config [baseline] (666.096 µs) : 0, 666
Remote Config [candidate] (655.563 µs) : 0, 656
Telemetry [baseline] (7.444 ms) : 0, 7444
Telemetry [candidate] (7.341 ms) : 0, 7341
ProfilingAgent [baseline] (97.742 ms) : 0, 97742
ProfilingAgent [candidate] (95.582 ms) : 0, 95582
Profiling [baseline] (97.766 ms) : 0, 97766
Profiling [candidate] (95.607 ms) : 0, 95607
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064080
Total [baseline] (8.556 s) : 0, 8555709
Agent [candidate] (1.075 s) : 0, 1074520
Total [candidate] (8.556 s) : 0, 8555754
section iast
Agent [baseline] (1.175 s) : 0, 1175450
Total [baseline] (9.014 s) : 0, 9013771
Agent [candidate] (1.171 s) : 0, 1170752
Total [candidate] (8.978 s) : 0, 8978069
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168703
Total [baseline] (8.956 s) : 0, 8956276
Agent [candidate] (1.176 s) : 0, 1175984
Total [candidate] (8.989 s) : 0, 8989321
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1182352
Total [baseline] (8.996 s) : 0, 8996006
Agent [candidate] (1.173 s) : 0, 1173016
Total [candidate] (9.002 s) : 0, 9001515
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.175 s 111.37 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 104.624 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.182 s 118.272 ms (11.1%)
Total tracing 8.556 s -
Total iast 9.014 s 458.062 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.956 s 400.567 ms (4.7%)
Total iast_TELEMETRY_OFF 8.996 s 440.297 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.171 s 96.232 ms (9.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 101.464 ms (9.4%)
Agent iast_TELEMETRY_OFF 1.173 s 98.496 ms (9.2%)
Total tracing 8.556 s -
Total iast 8.978 s 422.315 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.989 s 433.567 ms (5.1%)
Total iast_TELEMETRY_OFF 9.002 s 445.761 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.038 ms) : 0, 666038
BytebuddyAgent [candidate] (674.447 ms) : 0, 674447
GlobalTracer [baseline] (304.885 ms) : 0, 304885
GlobalTracer [candidate] (306.26 ms) : 0, 306260
AppSec [baseline] (50.321 ms) : 0, 50321
AppSec [candidate] (50.514 ms) : 0, 50514
Remote Config [baseline] (720.573 µs) : 0, 721
Remote Config [candidate] (764.201 µs) : 0, 764
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.645 ms) : 0, 7645
section iast
BytebuddyAgent [baseline] (785.31 ms) : 0, 785310
BytebuddyAgent [candidate] (779.875 ms) : 0, 779875
GlobalTracer [baseline] (294.598 ms) : 0, 294598
GlobalTracer [candidate] (294.18 ms) : 0, 294180
AppSec [baseline] (47.639 ms) : 0, 47639
AppSec [candidate] (47.548 ms) : 0, 47548
IAST [baseline] (26.795 ms) : 0, 26795
IAST [candidate] (28.116 ms) : 0, 28116
Remote Config [baseline] (573.433 µs) : 0, 573
Remote Config [candidate] (604.353 µs) : 0, 604
Telemetry [baseline] (7.07 ms) : 0, 7070
Telemetry [candidate] (6.993 ms) : 0, 6993
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.839 ms) : 0, 778839
BytebuddyAgent [candidate] (783.969 ms) : 0, 783969
GlobalTracer [baseline] (293.721 ms) : 0, 293721
GlobalTracer [candidate] (296.13 ms) : 0, 296130
AppSec [baseline] (47.387 ms) : 0, 47387
AppSec [candidate] (47.52 ms) : 0, 47520
IAST [baseline] (27.749 ms) : 0, 27749
IAST [candidate] (27.208 ms) : 0, 27208
Remote Config [baseline] (619.745 µs) : 0, 620
Remote Config [candidate] (603.13 µs) : 0, 603
Telemetry [baseline] (6.975 ms) : 0, 6975
Telemetry [candidate] (7.017 ms) : 0, 7017
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.362 ms) : 0, 787362
BytebuddyAgent [candidate] (782.386 ms) : 0, 782386
GlobalTracer [baseline] (297.447 ms) : 0, 297447
GlobalTracer [candidate] (296.615 ms) : 0, 296615
AppSec [baseline] (47.925 ms) : 0, 47925
AppSec [candidate] (47.44 ms) : 0, 47440
IAST [baseline] (27.719 ms) : 0, 27719
IAST [candidate] (25.509 ms) : 0, 25509
Remote Config [baseline] (587.292 µs) : 0, 587
Remote Config [candidate] (596.033 µs) : 0, 596
Telemetry [baseline] (7.718 ms) : 0, 7718
Telemetry [candidate] (6.962 ms) : 0, 6962
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-28T12:47:02 2024-06-28T12:53:51
git_branch master smola/fix-appsec-blocked-root-span
git_commit_date 1719562931 1719570417
git_commit_sha 97b5fe7 ccfb03b
release_version 1.37.0-SNAPSHOT~97b5fe71f8 1.37.0-SNAPSHOT~ccfb03b59b
start_time 2024-06-28T12:46:49 2024-06-28T12:53:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719579576 1719579576
ci_job_id 556374005 556374005
ci_pipeline_id 37844323 37844323
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1373
.   : milestone, 1354,
appsec (1.708 ms) : 1683, 1733
.   : milestone, 1708,
appsec_no_iast (1.723 ms) : 1698, 1748
.   : milestone, 1723,
iast (1.484 ms) : 1462, 1507
.   : milestone, 1484,
profiling (1.479 ms) : 1455, 1503
.   : milestone, 1479,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
section candidate
no_agent (1.341 ms) : 1322, 1361
.   : milestone, 1341,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.7 ms) : 1676, 1723
.   : milestone, 1700,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.481 ms) : 1457, 1505
.   : milestone, 1481,
tracing (1.457 ms) : 1434, 1481
.   : milestone, 1457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.373 ms] -
appsec 1.708 ms [1.683 ms, 1.733 ms] 354.342 µs (26.2%)
appsec_no_iast 1.723 ms [1.698 ms, 1.748 ms] 369.658 µs (27.3%)
iast 1.484 ms [1.462 ms, 1.507 ms] 130.95 µs (9.7%)
profiling 1.479 ms [1.455 ms, 1.503 ms] 125.312 µs (9.3%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 130.585 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.361 ms] -
appsec 1.736 ms [1.712 ms, 1.76 ms] 394.272 µs (29.4%)
appsec_no_iast 1.7 ms [1.676 ms, 1.723 ms] 358.083 µs (26.7%)
iast 1.478 ms [1.455 ms, 1.501 ms] 136.657 µs (10.2%)
profiling 1.481 ms [1.457 ms, 1.505 ms] 139.448 µs (10.4%)
tracing 1.457 ms [1.434 ms, 1.481 ms] 115.834 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.375 µs) : 349, 391
.   : milestone, 370,
iast (480.552 µs) : 460, 502
.   : milestone, 481,
iast_FULL (551.364 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (498.33 µs) : 478, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (461.976 µs) : 440, 484
.   : milestone, 462,
iast_INACTIVE (453.932 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (473.714 µs) : 453, 495
.   : milestone, 474,
tracing (444.98 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (369.097 µs) : 350, 388
.   : milestone, 369,
iast (482.485 µs) : 461, 504
.   : milestone, 482,
iast_FULL (551.498 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (498.624 µs) : 477, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (487.441 µs) : 465, 509
.   : milestone, 487,
iast_INACTIVE (455.143 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (477.479 µs) : 456, 499
.   : milestone, 477,
tracing (447.25 µs) : 426, 469
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.375 µs [349.473 µs, 391.277 µs] -
iast 480.552 µs [459.536 µs, 501.569 µs] 110.177 µs (29.7%)
iast_FULL 551.364 µs [530.056 µs, 572.672 µs] 180.99 µs (48.9%)
iast_GLOBAL 498.33 µs [477.589 µs, 519.071 µs] 127.955 µs (34.5%)
iast_HARDCODED_SECRET_DISABLED 461.976 µs [440.038 µs, 483.914 µs] 91.601 µs (24.7%)
iast_INACTIVE 453.932 µs [432.926 µs, 474.938 µs] 83.557 µs (22.6%)
iast_TELEMETRY_OFF 473.714 µs [452.642 µs, 494.785 µs] 103.339 µs (27.9%)
tracing 444.98 µs [424.032 µs, 465.928 µs] 74.605 µs (20.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.097 µs [349.701 µs, 388.492 µs] -
iast 482.485 µs [461.228 µs, 503.742 µs] 113.388 µs (30.7%)
iast_FULL 551.498 µs [530.387 µs, 572.609 µs] 182.401 µs (49.4%)
iast_GLOBAL 498.624 µs [477.384 µs, 519.863 µs] 129.527 µs (35.1%)
iast_HARDCODED_SECRET_DISABLED 487.441 µs [465.472 µs, 509.41 µs] 118.344 µs (32.1%)
iast_INACTIVE 455.143 µs [433.814 µs, 476.472 µs] 86.046 µs (23.3%)
iast_TELEMETRY_OFF 477.479 µs [455.66 µs, 499.298 µs] 108.382 µs (29.4%)
tracing 447.25 µs [425.995 µs, 468.505 µs] 78.153 µs (21.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/fix-appsec-blocked-root-span
git_commit_date 1719562931 1719570417
git_commit_sha 97b5fe7 ccfb03b
release_version 1.37.0-SNAPSHOT~97b5fe71f8 1.37.0-SNAPSHOT~ccfb03b59b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719580075 1719580075
ci_job_id 556374007 556374007
ci_pipeline_id 37844323 37844323
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.202 ms) : 2169, 2236
.   : milestone, 2202,
iast (1.96 ms) : 1919, 2001
.   : milestone, 1960,
iast_GLOBAL (2.005 ms) : 1964, 2046
.   : milestone, 2005,
profiling (1.858 ms) : 1824, 1892
.   : milestone, 1858,
tracing (1.841 ms) : 1809, 1874
.   : milestone, 1841,
section candidate
no_agent (1.458 ms) : 1447, 1469
.   : milestone, 1458,
appsec (2.2 ms) : 2166, 2233
.   : milestone, 2200,
iast (1.963 ms) : 1922, 2004
.   : milestone, 1963,
iast_GLOBAL (2.016 ms) : 1974, 2058
.   : milestone, 2016,
profiling (1.862 ms) : 1828, 1896
.   : milestone, 1862,
tracing (1.83 ms) : 1798, 1862
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.202 ms [2.169 ms, 2.236 ms] 741.644 µs (50.8%)
iast 1.96 ms [1.919 ms, 2.001 ms] 499.257 µs (34.2%)
iast_GLOBAL 2.005 ms [1.964 ms, 2.046 ms] 544.066 µs (37.2%)
profiling 1.858 ms [1.824 ms, 1.892 ms] 397.061 µs (27.2%)
tracing 1.841 ms [1.809 ms, 1.874 ms] 380.528 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.469 ms] -
appsec 2.2 ms [2.166 ms, 2.233 ms] 741.586 µs (50.9%)
iast 1.963 ms [1.922 ms, 2.004 ms] 504.86 µs (34.6%)
iast_GLOBAL 2.016 ms [1.974 ms, 2.058 ms] 557.996 µs (38.3%)
profiling 1.862 ms [1.828 ms, 1.896 ms] 403.91 µs (27.7%)
tracing 1.83 ms [1.798 ms, 1.862 ms] 371.782 µs (25.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~ccfb03b59b, baseline=1.37.0-SNAPSHOT~97b5fe71f8
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.95 s) : 14950000, 14950000
.   : milestone, 14950000,
appsec (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
iast (18.709 s) : 18709000, 18709000
.   : milestone, 18709000,
iast_GLOBAL (17.81 s) : 17810000, 17810000
.   : milestone, 17810000,
profiling (15.404 s) : 15404000, 15404000
.   : milestone, 15404000,
tracing (14.873 s) : 14873000, 14873000
.   : milestone, 14873000,
section candidate
no_agent (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
appsec (14.833 s) : 14833000, 14833000
.   : milestone, 14833000,
iast (18.769 s) : 18769000, 18769000
.   : milestone, 18769000,
iast_GLOBAL (18.115 s) : 18115000, 18115000
.   : milestone, 18115000,
profiling (15.795 s) : 15795000, 15795000
.   : milestone, 15795000,
tracing (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.95 s [14.95 s, 14.95 s] -
appsec 14.997 s [14.997 s, 14.997 s] 47.0 ms (0.3%)
iast 18.709 s [18.709 s, 18.709 s] 3.759 s (25.1%)
iast_GLOBAL 17.81 s [17.81 s, 17.81 s] 2.86 s (19.1%)
profiling 15.404 s [15.404 s, 15.404 s] 454.0 ms (3.0%)
tracing 14.873 s [14.873 s, 14.873 s] -77.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.034 s [15.034 s, 15.034 s] -
appsec 14.833 s [14.833 s, 14.833 s] -201.0 ms (-1.3%)
iast 18.769 s [18.769 s, 18.769 s] 3.735 s (24.8%)
iast_GLOBAL 18.115 s [18.115 s, 18.115 s] 3.081 s (20.5%)
profiling 15.795 s [15.795 s, 15.795 s] 761.0 ms (5.1%)
tracing 15.018 s [15.018 s, 15.018 s] -16.0 ms (-0.1%)

@smola smola marked this pull request as ready for review June 28, 2024 14:49
@smola smola requested a review from a team as a code owner June 28, 2024 14:49
@smola smola merged commit 97e2337 into master Jul 1, 2024
82 checks passed
@smola smola deleted the smola/fix-appsec-blocked-root-span branch July 1, 2024 08:42
@PerfectSlayer PerfectSlayer added this to the 1.37.0 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez was automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 was automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: bug
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smola @ValentinZakharov @PerfectSlayer