Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace JMS Queue and Topic producers when destination is explicit #7266

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Trace JMS Queue and Topic producers when destination is explicit #7266

merged 2 commits into from
Jul 2, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

The java agent today is not instrumenting jms send for signatures QueueProducer.send(Queue, Message, ..) or TopicPublisher.send(Topic, Message).
Instead, we trace MessageProducer.send(Destination, Message, ..) only.

This is generally OK when specialized classes are delegating to superclasses. In fact for ActiveMQ we have

public class ActiveMQQueueSender extends ActiveMQMessageProducer implements QueueSender {
   ....

    public void send(Queue queue, Message message) throws JMSException {
        super.send(queue, message);
    }

But it's not OK when the specialized class does not delegate to super. Hence we lost the tracing on the producer.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner July 2, 2024 10:11
@amarziali amarziali added type: enhancement inst: jms JMS instrumentation labels Jul 2, 2024
mcculls
mcculls approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The existing call-depth checks should avoid duplicate spans

@amarziali amarziali enabled auto-merge (squash) July 2, 2024 10:20
@pr-commenter
Copy link

pr-commenter bot commented Jul 2, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jms-producer-plusplus
git_commit_date 1719910036 1719914800
git_commit_sha a9dde4f 7d53edb
release_version 1.37.0-SNAPSHOT~a9dde4fd66 1.37.0-SNAPSHOT~7d53edba58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719917576 1719917576
ci_job_id 559371355 559371355
ci_pipeline_id 38107184 38107184
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063541
Total [baseline] (10.382 s) : 0, 10381657
Agent [candidate] (1.071 s) : 0, 1071450
Total [candidate] (10.376 s) : 0, 10375782
section appsec
Agent [baseline] (1.19 s) : 0, 1190404
Total [baseline] (10.492 s) : 0, 10491677
Agent [candidate] (1.184 s) : 0, 1184012
Total [candidate] (10.543 s) : 0, 10542601
section iast
Agent [baseline] (1.178 s) : 0, 1177872
Total [baseline] (10.839 s) : 0, 10838697
Agent [candidate] (1.173 s) : 0, 1173090
Total [candidate] (10.784 s) : 0, 10783592
section profiling
Agent [baseline] (1.265 s) : 0, 1265076
Total [baseline] (10.545 s) : 0, 10545037
Agent [candidate] (1.268 s) : 0, 1268194
Total [candidate] (10.658 s) : 0, 10658017
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.19 s 126.863 ms (11.9%)
Agent iast 1.178 s 114.331 ms (10.8%)
Agent profiling 1.265 s 201.535 ms (18.9%)
Total tracing 10.382 s -
Total appsec 10.492 s 110.02 ms (1.1%)
Total iast 10.839 s 457.04 ms (4.4%)
Total profiling 10.545 s 163.38 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.184 s 112.562 ms (10.5%)
Agent iast 1.173 s 101.64 ms (9.5%)
Agent profiling 1.268 s 196.744 ms (18.4%)
Total tracing 10.376 s -
Total appsec 10.543 s 166.819 ms (1.6%)
Total iast 10.784 s 407.81 ms (3.9%)
Total profiling 10.658 s 282.235 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.692 ms) : 0, 665692
BytebuddyAgent [candidate] (672.211 ms) : 0, 672211
GlobalTracer [baseline] (304.679 ms) : 0, 304679
GlobalTracer [candidate] (305.731 ms) : 0, 305731
AppSec [baseline] (50.298 ms) : 0, 50298
AppSec [candidate] (50.275 ms) : 0, 50275
Remote Config [baseline] (720.867 µs) : 0, 721
Remote Config [candidate] (728.189 µs) : 0, 728
Telemetry [baseline] (7.61 ms) : 0, 7610
Telemetry [candidate] (7.573 ms) : 0, 7573
section appsec
BytebuddyAgent [baseline] (680.528 ms) : 0, 680528
BytebuddyAgent [candidate] (676.474 ms) : 0, 676474
GlobalTracer [baseline] (300.601 ms) : 0, 300601
GlobalTracer [candidate] (298.871 ms) : 0, 298871
AppSec [baseline] (154.571 ms) : 0, 154571
AppSec [candidate] (154.13 ms) : 0, 154130
Remote Config [baseline] (638.135 µs) : 0, 638
Remote Config [candidate] (636.942 µs) : 0, 637
Telemetry [baseline] (9.351 ms) : 0, 9351
Telemetry [candidate] (8.787 ms) : 0, 8787
IAST [baseline] (19.858 ms) : 0, 19858
IAST [candidate] (21.143 ms) : 0, 21143
section iast
BytebuddyAgent [baseline] (783.314 ms) : 0, 783314
BytebuddyAgent [candidate] (781.239 ms) : 0, 781239
GlobalTracer [baseline] (297.719 ms) : 0, 297719
GlobalTracer [candidate] (295.916 ms) : 0, 295916
AppSec [baseline] (47.842 ms) : 0, 47842
AppSec [candidate] (47.495 ms) : 0, 47495
Remote Config [baseline] (601.488 µs) : 0, 601
Remote Config [candidate] (646.356 µs) : 0, 646
Telemetry [baseline] (7.964 ms) : 0, 7964
Telemetry [candidate] (7.844 ms) : 0, 7844
IAST [baseline] (26.953 ms) : 0, 26953
IAST [candidate] (26.494 ms) : 0, 26494
section profiling
BytebuddyAgent [baseline] (663.314 ms) : 0, 663314
BytebuddyAgent [candidate] (664.808 ms) : 0, 664808
GlobalTracer [baseline] (388.506 ms) : 0, 388506
GlobalTracer [candidate] (389.887 ms) : 0, 389887
AppSec [baseline] (51.759 ms) : 0, 51759
AppSec [candidate] (51.878 ms) : 0, 51878
Remote Config [baseline] (645.27 µs) : 0, 645
Remote Config [candidate] (650.405 µs) : 0, 650
Telemetry [baseline] (7.452 ms) : 0, 7452
Telemetry [candidate] (7.395 ms) : 0, 7395
ProfilingAgent [baseline] (96.312 ms) : 0, 96312
ProfilingAgent [candidate] (96.431 ms) : 0, 96431
Profiling [baseline] (96.336 ms) : 0, 96336
Profiling [candidate] (96.455 ms) : 0, 96455
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067526
Total [baseline] (8.568 s) : 0, 8567721
Agent [candidate] (1.064 s) : 0, 1064461
Total [candidate] (8.567 s) : 0, 8566615
section iast
Agent [baseline] (1.184 s) : 0, 1184117
Total [baseline] (9.072 s) : 0, 9071878
Agent [candidate] (1.172 s) : 0, 1172137
Total [candidate] (9.008 s) : 0, 9008431
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171517
Total [baseline] (8.972 s) : 0, 8972300
Agent [candidate] (1.172 s) : 0, 1172017
Total [candidate] (9.062 s) : 0, 9062080
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177650
Total [baseline] (9.036 s) : 0, 9036381
Agent [candidate] (1.169 s) : 0, 1169196
Total [candidate] (9.035 s) : 0, 9035200
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.184 s 116.59 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 103.991 ms (9.7%)
Agent iast_TELEMETRY_OFF 1.178 s 110.123 ms (10.3%)
Total tracing 8.568 s -
Total iast 9.072 s 504.157 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.972 s 404.579 ms (4.7%)
Total iast_TELEMETRY_OFF 9.036 s 468.66 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.172 s 107.676 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 107.556 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.169 s 104.735 ms (9.8%)
Total tracing 8.567 s -
Total iast 9.008 s 441.817 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.062 s 495.465 ms (5.8%)
Total iast_TELEMETRY_OFF 9.035 s 468.585 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.206 ms) : 0, 668206
BytebuddyAgent [candidate] (666.299 ms) : 0, 666299
GlobalTracer [baseline] (305.835 ms) : 0, 305835
GlobalTracer [candidate] (304.994 ms) : 0, 304994
AppSec [baseline] (50.542 ms) : 0, 50542
AppSec [candidate] (50.39 ms) : 0, 50390
Remote Config [baseline] (743.728 µs) : 0, 744
Remote Config [candidate] (721.396 µs) : 0, 721
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (7.621 ms) : 0, 7621
section iast
BytebuddyAgent [baseline] (787.79 ms) : 0, 787790
BytebuddyAgent [candidate] (781.383 ms) : 0, 781383
GlobalTracer [baseline] (299.253 ms) : 0, 299253
GlobalTracer [candidate] (294.769 ms) : 0, 294769
AppSec [baseline] (48.034 ms) : 0, 48034
AppSec [candidate] (47.523 ms) : 0, 47523
IAST [baseline] (26.947 ms) : 0, 26947
IAST [candidate] (27.27 ms) : 0, 27270
Remote Config [baseline] (629.439 µs) : 0, 629
Remote Config [candidate] (605.305 µs) : 0, 605
Telemetry [baseline] (7.961 ms) : 0, 7961
Telemetry [candidate] (7.135 ms) : 0, 7135
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.486 ms) : 0, 779486
BytebuddyAgent [candidate] (779.959 ms) : 0, 779959
GlobalTracer [baseline] (295.068 ms) : 0, 295068
GlobalTracer [candidate] (295.633 ms) : 0, 295633
AppSec [baseline] (47.388 ms) : 0, 47388
AppSec [candidate] (47.41 ms) : 0, 47410
IAST [baseline] (26.201 ms) : 0, 26201
IAST [candidate] (28.036 ms) : 0, 28036
Remote Config [baseline] (604.719 µs) : 0, 605
Remote Config [candidate] (591.246 µs) : 0, 591
Telemetry [baseline] (9.316 ms) : 0, 9316
Telemetry [candidate] (6.948 ms) : 0, 6948
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.061 ms) : 0, 784061
BytebuddyAgent [candidate] (777.758 ms) : 0, 777758
GlobalTracer [baseline] (296.886 ms) : 0, 296886
GlobalTracer [candidate] (294.761 ms) : 0, 294761
AppSec [baseline] (47.372 ms) : 0, 47372
AppSec [candidate] (47.161 ms) : 0, 47161
IAST [baseline] (26.087 ms) : 0, 26087
IAST [candidate] (27.651 ms) : 0, 27651
Remote Config [baseline] (647.065 µs) : 0, 647
Remote Config [candidate] (652.884 µs) : 0, 653
Telemetry [baseline] (9.095 ms) : 0, 9095
Telemetry [candidate] (7.771 ms) : 0, 7771
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-02T10:25:08 2024-07-02T10:31:58
git_branch master andrea.marziali/jms-producer-plusplus
git_commit_date 1719910036 1719914800
git_commit_sha a9dde4f 7d53edb
release_version 1.37.0-SNAPSHOT~a9dde4fd66 1.37.0-SNAPSHOT~7d53edba58
start_time 2024-07-02T10:24:55 2024-07-02T10:31:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719916663 1719916663
ci_job_id 559371356 559371356
ci_pipeline_id 38107184 38107184
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-105.875µs; -51.350µs] or [-6.787%; -3.292%]		 unstable
[-323.520op/s; +797.594op/s] or [-10.919%; +26.919%]		 1.481ms 3200.000op/s 1.560ms 2962.963op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.584 µs) : 347, 386
.   : milestone, 367,
iast (486.428 µs) : 465, 508
.   : milestone, 486,
iast_FULL (550.785 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (509.196 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (482.064 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (452.001 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (473.065 µs) : 451, 495
.   : milestone, 473,
tracing (440.482 µs) : 420, 461
.   : milestone, 440,
section candidate
no_agent (368.323 µs) : 349, 388
.   : milestone, 368,
iast (485.886 µs) : 464, 508
.   : milestone, 486,
iast_FULL (551.244 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (509.417 µs) : 487, 532
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (480.382 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (456.054 µs) : 434, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (471.024 µs) : 450, 493
.   : milestone, 471,
tracing (435.656 µs) : 415, 456
.   : milestone, 436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.584 µs [346.685 µs, 386.483 µs] -
iast 486.428 µs [465.099 µs, 507.757 µs] 119.844 µs (32.7%)
iast_FULL 550.785 µs [529.431 µs, 572.138 µs] 184.2 µs (50.2%)
iast_GLOBAL 509.196 µs [486.974 µs, 531.417 µs] 142.612 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 482.064 µs [460.872 µs, 503.256 µs] 115.48 µs (31.5%)
iast_INACTIVE 452.001 µs [430.902 µs, 473.1 µs] 85.417 µs (23.3%)
iast_TELEMETRY_OFF 473.065 µs [451.198 µs, 494.932 µs] 106.481 µs (29.0%)
tracing 440.482 µs [419.555 µs, 461.409 µs] 73.898 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.323 µs [348.952 µs, 387.693 µs] -
iast 485.886 µs [464.112 µs, 507.66 µs] 117.563 µs (31.9%)
iast_FULL 551.244 µs [529.983 µs, 572.504 µs] 182.921 µs (49.7%)
iast_GLOBAL 509.417 µs [487.202 µs, 531.631 µs] 141.094 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 480.382 µs [459.462 µs, 501.302 µs] 112.059 µs (30.4%)
iast_INACTIVE 456.054 µs [434.063 µs, 478.046 µs] 87.732 µs (23.8%)
iast_TELEMETRY_OFF 471.024 µs [449.536 µs, 492.513 µs] 102.701 µs (27.9%)
tracing 435.656 µs [415.1 µs, 456.211 µs] 67.333 µs (18.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1317, 1356
.   : milestone, 1336,
appsec (1.718 ms) : 1693, 1743
.   : milestone, 1718,
appsec_no_iast (1.716 ms) : 1691, 1740
.   : milestone, 1716,
iast (1.467 ms) : 1444, 1489
.   : milestone, 1467,
profiling (1.56 ms) : 1535, 1585
.   : milestone, 1560,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.339 ms) : 1318, 1359
.   : milestone, 1339,
appsec (1.71 ms) : 1686, 1734
.   : milestone, 1710,
appsec_no_iast (1.708 ms) : 1683, 1732
.   : milestone, 1708,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.481 ms) : 1456, 1507
.   : milestone, 1481,
tracing (1.465 ms) : 1440, 1489
.   : milestone, 1465,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.356 ms] -
appsec 1.718 ms [1.693 ms, 1.743 ms] 381.889 µs (28.6%)
appsec_no_iast 1.716 ms [1.691 ms, 1.74 ms] 379.562 µs (28.4%)
iast 1.467 ms [1.444 ms, 1.489 ms] 130.421 µs (9.8%)
profiling 1.56 ms [1.535 ms, 1.585 ms] 223.777 µs (16.7%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 133.308 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.318 ms, 1.359 ms] -
appsec 1.71 ms [1.686 ms, 1.734 ms] 371.476 µs (27.8%)
appsec_no_iast 1.708 ms [1.683 ms, 1.732 ms] 369.015 µs (27.6%)
iast 1.473 ms [1.45 ms, 1.496 ms] 134.78 µs (10.1%)
profiling 1.481 ms [1.456 ms, 1.507 ms] 142.706 µs (10.7%)
tracing 1.465 ms [1.44 ms, 1.489 ms] 126.106 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jms-producer-plusplus
git_commit_date 1719910036 1719914800
git_commit_sha a9dde4f 7d53edb
release_version 1.37.0-SNAPSHOT~a9dde4fd66 1.37.0-SNAPSHOT~7d53edba58
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719917179 1719917179
ci_job_id 559371357 559371357
ci_pipeline_id 38107184 38107184
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.228 ms) : 2191, 2264
.   : milestone, 2228,
iast (1.991 ms) : 1948, 2035
.   : milestone, 1991,
iast_GLOBAL (2.022 ms) : 1979, 2065
.   : milestone, 2022,
profiling (1.86 ms) : 1824, 1896
.   : milestone, 1860,
tracing (1.851 ms) : 1817, 1885
.   : milestone, 1851,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.224 ms) : 2188, 2260
.   : milestone, 2224,
iast (1.98 ms) : 1938, 2023
.   : milestone, 1980,
iast_GLOBAL (2.023 ms) : 1980, 2067
.   : milestone, 2023,
profiling (1.864 ms) : 1829, 1899
.   : milestone, 1864,
tracing (1.835 ms) : 1802, 1868
.   : milestone, 1835,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.228 ms [2.191 ms, 2.264 ms] 770.559 µs (52.9%)
iast 1.991 ms [1.948 ms, 2.035 ms] 534.23 µs (36.7%)
iast_GLOBAL 2.022 ms [1.979 ms, 2.065 ms] 565.006 µs (38.8%)
profiling 1.86 ms [1.824 ms, 1.896 ms] 402.873 µs (27.6%)
tracing 1.851 ms [1.817 ms, 1.885 ms] 393.999 µs (27.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.224 ms [2.188 ms, 2.26 ms] 760.903 µs (52.0%)
iast 1.98 ms [1.938 ms, 2.023 ms] 516.774 µs (35.3%)
iast_GLOBAL 2.023 ms [1.98 ms, 2.067 ms] 559.779 µs (38.3%)
profiling 1.864 ms [1.829 ms, 1.899 ms] 400.683 µs (27.4%)
tracing 1.835 ms [1.802 ms, 1.868 ms] 371.932 µs (25.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~7d53edba58, baseline=1.37.0-SNAPSHOT~a9dde4fd66
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.446 s) : 15446000, 15446000
.   : milestone, 15446000,
appsec (14.757 s) : 14757000, 14757000
.   : milestone, 14757000,
iast (19.011 s) : 19011000, 19011000
.   : milestone, 19011000,
iast_GLOBAL (17.772 s) : 17772000, 17772000
.   : milestone, 17772000,
profiling (15.675 s) : 15675000, 15675000
.   : milestone, 15675000,
tracing (15.042 s) : 15042000, 15042000
.   : milestone, 15042000,
section candidate
no_agent (15.356 s) : 15356000, 15356000
.   : milestone, 15356000,
appsec (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
iast (18.863 s) : 18863000, 18863000
.   : milestone, 18863000,
iast_GLOBAL (17.847 s) : 17847000, 17847000
.   : milestone, 17847000,
profiling (15.472 s) : 15472000, 15472000
.   : milestone, 15472000,
tracing (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.446 s [15.446 s, 15.446 s] -
appsec 14.757 s [14.757 s, 14.757 s] -689.0 ms (-4.5%)
iast 19.011 s [19.011 s, 19.011 s] 3.565 s (23.1%)
iast_GLOBAL 17.772 s [17.772 s, 17.772 s] 2.326 s (15.1%)
profiling 15.675 s [15.675 s, 15.675 s] 229.0 ms (1.5%)
tracing 15.042 s [15.042 s, 15.042 s] -404.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.356 s [15.356 s, 15.356 s] -
appsec 14.959 s [14.959 s, 14.959 s] -397.0 ms (-2.6%)
iast 18.863 s [18.863 s, 18.863 s] 3.507 s (22.8%)
iast_GLOBAL 17.847 s [17.847 s, 17.847 s] 2.491 s (16.2%)
profiling 15.472 s [15.472 s, 15.472 s] 116.0 ms (0.8%)
tracing 15.202 s [15.202 s, 15.202 s] -154.0 ms (-1.0%)

@amarziali amarziali merged commit 38e8294 into master Jul 2, 2024
78 of 81 checks passed
@amarziali amarziali deleted the andrea.marziali/jms-producer-plusplus branch July 2, 2024 11:21
@github-actions github-actions bot added this to the 1.37.0 milestone Jul 2, 2024
@PerfectSlayer PerfectSlayer changed the title JMS: trace Queue and Topic producers when destination is explicit Trace JMS Queue and Topic producers when destination is explicit Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

Assignees
No one assigned
Labels
inst: jms JMS instrumentation type: enhancement
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amarziali @mcculls