-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch uri information correctly when httphost argument is null #7276
Conversation
👋 Thank you for your contribution. There are some test failing so I've to understand the impact and perhaps do a commit in order to have the CI pass. Afterwards I will be able to approve this PR |
@abagavat can you share the way you reproduce the issue? Perhaps the way the request is done with httpclient? I will add a test for it |
@amarziali I didn't specifically try to reproduce it as it was happening at a large scale across many of our applications. This started happening after a recent SpringBoot upgrade. We use Spring RestTemplate which internally uses apache httpclient to make the http request. Between the two versions the signature of the execute method to httpclient has changed. As you can see after the upgrade Spring is explicitly setting the host to null. I think you can repro this in the tests by using a different variant of this test fixture where the host is set to null. Line 101 in 23a8164
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What Does This Do
Fixes the issue described in #7275
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]