Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advices for GraphQl 22+ #7295

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix advices for GraphQl 22+ #7295

merged 1 commit into from
Jul 9, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

This PR fixes the missing tracing for 22+. The cause was due to advices that were not correctly applying hence the instrumentation was not installed. Also, I updated the lockfile because tests were executed with a wrong version and I also added latestDep for 20 and 21

Motivation

Additional Notes

See #7291

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner July 9, 2024 08:56
vandonr
vandonr approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢

@pr-commenter
Copy link

pr-commenter bot commented Jul 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/graphql-bis
git_commit_date 1720513897 1720515259
git_commit_sha 9e7aa67 b25407e
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b25407e7f4
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720517761 1720517761
ci_job_id 566208697 566208697
ci_pipeline_id 38676052 38676052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062648
Total [baseline] (8.554 s) : 0, 8554148
Agent [candidate] (1.062 s) : 0, 1062130
Total [candidate] (8.533 s) : 0, 8533252
section iast
Agent [baseline] (1.169 s) : 0, 1168635
Total [baseline] (8.986 s) : 0, 8985689
Agent [candidate] (1.169 s) : 0, 1169371
Total [candidate] (8.968 s) : 0, 8968249
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184556
Total [baseline] (8.929 s) : 0, 8929495
Agent [candidate] (1.169 s) : 0, 1169176
Total [candidate] (8.928 s) : 0, 8928220
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184124
Total [baseline] (9.028 s) : 0, 9028466
Agent [candidate] (1.166 s) : 0, 1165913
Total [candidate] (8.946 s) : 0, 8946149
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.169 s 105.987 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 121.908 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.184 s 121.476 ms (11.4%)
Total tracing 8.554 s -
Total iast 8.986 s 431.541 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.929 s 375.347 ms (4.4%)
Total iast_TELEMETRY_OFF 9.028 s 474.318 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.169 s 107.241 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 107.046 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.166 s 103.783 ms (9.8%)
Total tracing 8.533 s -
Total iast 8.968 s 434.997 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.928 s 394.968 ms (4.6%)
Total iast_TELEMETRY_OFF 8.946 s 412.897 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.74 ms) : 0, 664740
BytebuddyAgent [candidate] (664.165 ms) : 0, 664165
GlobalTracer [baseline] (305.352 ms) : 0, 305352
GlobalTracer [candidate] (305.128 ms) : 0, 305128
AppSec [baseline] (49.861 ms) : 0, 49861
AppSec [candidate] (49.948 ms) : 0, 49948
Remote Config [baseline] (662.212 µs) : 0, 662
Remote Config [candidate] (674.727 µs) : 0, 675
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.679 ms) : 0, 7679
section iast
BytebuddyAgent [baseline] (778.958 ms) : 0, 778958
BytebuddyAgent [candidate] (779.353 ms) : 0, 779353
GlobalTracer [baseline] (295.822 ms) : 0, 295822
GlobalTracer [candidate] (294.963 ms) : 0, 294963
AppSec [baseline] (47.045 ms) : 0, 47045
AppSec [candidate] (46.998 ms) : 0, 46998
IAST [baseline] (25.665 ms) : 0, 25665
IAST [candidate] (27.028 ms) : 0, 27028
Remote Config [baseline] (595.192 µs) : 0, 595
Remote Config [candidate] (579.321 µs) : 0, 579
Telemetry [baseline] (7.114 ms) : 0, 7114
Telemetry [candidate] (7.002 ms) : 0, 7002
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.108 ms) : 0, 790108
BytebuddyAgent [candidate] (778.204 ms) : 0, 778204
GlobalTracer [baseline] (297.531 ms) : 0, 297531
GlobalTracer [candidate] (295.416 ms) : 0, 295416
AppSec [baseline] (47.615 ms) : 0, 47615
AppSec [candidate] (47.307 ms) : 0, 47307
IAST [baseline] (28.126 ms) : 0, 28126
IAST [candidate] (27.212 ms) : 0, 27212
Remote Config [baseline] (562.901 µs) : 0, 563
Remote Config [candidate] (562.465 µs) : 0, 562
Telemetry [baseline] (6.943 ms) : 0, 6943
Telemetry [candidate] (6.953 ms) : 0, 6953
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.007 ms) : 0, 789007
BytebuddyAgent [candidate] (775.208 ms) : 0, 775208
GlobalTracer [baseline] (299.227 ms) : 0, 299227
GlobalTracer [candidate] (294.344 ms) : 0, 294344
AppSec [baseline] (47.612 ms) : 0, 47612
AppSec [candidate] (47.003 ms) : 0, 47003
IAST [baseline] (27.072 ms) : 0, 27072
IAST [candidate] (27.686 ms) : 0, 27686
Remote Config [baseline] (592.729 µs) : 0, 593
Remote Config [candidate] (612.971 µs) : 0, 613
Telemetry [baseline] (6.935 ms) : 0, 6935
Telemetry [candidate] (7.593 ms) : 0, 7593
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062155
Total [baseline] (10.288 s) : 0, 10287666
Agent [candidate] (1.064 s) : 0, 1063805
Total [candidate] (10.316 s) : 0, 10315693
section appsec
Agent [baseline] (1.184 s) : 0, 1184356
Total [baseline] (10.559 s) : 0, 10559237
Agent [candidate] (1.184 s) : 0, 1184331
Total [candidate] (10.54 s) : 0, 10540497
section iast
Agent [baseline] (1.169 s) : 0, 1168729
Total [baseline] (10.744 s) : 0, 10743814
Agent [candidate] (1.171 s) : 0, 1170810
Total [candidate] (10.678 s) : 0, 10678376
section profiling
Agent [baseline] (1.263 s) : 0, 1263394
Total [baseline] (10.623 s) : 0, 10622848
Agent [candidate] (1.266 s) : 0, 1265605
Total [candidate] (10.678 s) : 0, 10677608
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.184 s 122.202 ms (11.5%)
Agent iast 1.169 s 106.574 ms (10.0%)
Agent profiling 1.263 s 201.24 ms (18.9%)
Total tracing 10.288 s -
Total appsec 10.559 s 271.571 ms (2.6%)
Total iast 10.744 s 456.147 ms (4.4%)
Total profiling 10.623 s 335.182 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.184 s 120.526 ms (11.3%)
Agent iast 1.171 s 107.004 ms (10.1%)
Agent profiling 1.266 s 201.8 ms (19.0%)
Total tracing 10.316 s -
Total appsec 10.54 s 224.804 ms (2.2%)
Total iast 10.678 s 362.683 ms (3.5%)
Total profiling 10.678 s 361.915 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.658 ms) : 0, 664658
BytebuddyAgent [candidate] (665.299 ms) : 0, 665299
GlobalTracer [baseline] (304.63 ms) : 0, 304630
GlobalTracer [candidate] (305.733 ms) : 0, 305733
AppSec [baseline] (49.988 ms) : 0, 49988
AppSec [candidate] (49.923 ms) : 0, 49923
Remote Config [baseline] (668.455 µs) : 0, 668
Remote Config [candidate] (673.759 µs) : 0, 674
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (7.668 ms) : 0, 7668
section appsec
BytebuddyAgent [baseline] (675.994 ms) : 0, 675994
BytebuddyAgent [candidate] (677.333 ms) : 0, 677333
GlobalTracer [baseline] (299.876 ms) : 0, 299876
GlobalTracer [candidate] (299.264 ms) : 0, 299264
AppSec [baseline] (154.03 ms) : 0, 154030
AppSec [candidate] (154.068 ms) : 0, 154068
IAST [baseline] (21.416 ms) : 0, 21416
IAST [candidate] (20.167 ms) : 0, 20167
Remote Config [baseline] (623.928 µs) : 0, 624
Remote Config [candidate] (620.813 µs) : 0, 621
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.277 ms) : 0, 8277
section iast
BytebuddyAgent [baseline] (777.108 ms) : 0, 777108
BytebuddyAgent [candidate] (777.496 ms) : 0, 777496
GlobalTracer [baseline] (295.564 ms) : 0, 295564
GlobalTracer [candidate] (296.819 ms) : 0, 296819
AppSec [baseline] (46.985 ms) : 0, 46985
AppSec [candidate] (47.525 ms) : 0, 47525
IAST [baseline] (28.216 ms) : 0, 28216
IAST [candidate] (27.207 ms) : 0, 27207
Remote Config [baseline] (550.775 µs) : 0, 551
Remote Config [candidate] (574.108 µs) : 0, 574
Telemetry [baseline] (6.85 ms) : 0, 6850
Telemetry [candidate] (7.677 ms) : 0, 7677
section profiling
BytebuddyAgent [baseline] (662.691 ms) : 0, 662691
BytebuddyAgent [candidate] (663.612 ms) : 0, 663612
GlobalTracer [baseline] (388.337 ms) : 0, 388337
GlobalTracer [candidate] (389.161 ms) : 0, 389161
AppSec [baseline] (51.613 ms) : 0, 51613
AppSec [candidate] (51.534 ms) : 0, 51534
Remote Config [baseline] (648.434 µs) : 0, 648
Remote Config [candidate] (646.48 µs) : 0, 646
Telemetry [baseline] (7.309 ms) : 0, 7309
Telemetry [candidate] (7.353 ms) : 0, 7353
ProfilingAgent [baseline] (95.652 ms) : 0, 95652
ProfilingAgent [candidate] (96.076 ms) : 0, 96076
Profiling [baseline] (95.676 ms) : 0, 95676
Profiling [candidate] (96.101 ms) : 0, 96101
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-09T09:06:28 2024-07-09T09:13:14
git_branch master andrea.marziali/graphql-bis
git_commit_date 1720513897 1720515259
git_commit_sha 9e7aa67 b25407e
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b25407e7f4
start_time 2024-07-09T09:06:15 2024-07-09T09:13:01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720516738 1720516738
ci_job_id 566208698 566208698
ci_pipeline_id 38676052 38676052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1376
.   : milestone, 1357,
appsec (1.702 ms) : 1679, 1726
.   : milestone, 1702,
appsec_no_iast (1.701 ms) : 1676, 1725
.   : milestone, 1701,
iast (1.454 ms) : 1432, 1477
.   : milestone, 1454,
profiling (1.487 ms) : 1462, 1511
.   : milestone, 1487,
tracing (1.469 ms) : 1444, 1493
.   : milestone, 1469,
section candidate
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.702 ms) : 1678, 1726
.   : milestone, 1702,
appsec_no_iast (1.723 ms) : 1699, 1746
.   : milestone, 1723,
iast (1.483 ms) : 1460, 1506
.   : milestone, 1483,
profiling (1.48 ms) : 1456, 1504
.   : milestone, 1480,
tracing (1.454 ms) : 1429, 1478
.   : milestone, 1454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.376 ms] -
appsec 1.702 ms [1.679 ms, 1.726 ms] 345.652 µs (25.5%)
appsec_no_iast 1.701 ms [1.676 ms, 1.725 ms] 344.047 µs (25.4%)
iast 1.454 ms [1.432 ms, 1.477 ms] 97.624 µs (7.2%)
profiling 1.487 ms [1.462 ms, 1.511 ms] 130.068 µs (9.6%)
tracing 1.469 ms [1.444 ms, 1.493 ms] 111.899 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.368 ms] -
appsec 1.702 ms [1.678 ms, 1.726 ms] 353.686 µs (26.2%)
appsec_no_iast 1.723 ms [1.699 ms, 1.746 ms] 374.353 µs (27.8%)
iast 1.483 ms [1.46 ms, 1.506 ms] 134.379 µs (10.0%)
profiling 1.48 ms [1.456 ms, 1.504 ms] 131.598 µs (9.8%)
tracing 1.454 ms [1.429 ms, 1.478 ms] 105.027 µs (7.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.043 µs) : 346, 386
.   : milestone, 366,
iast (475.749 µs) : 454, 497
.   : milestone, 476,
iast_FULL (543.388 µs) : 522, 565
.   : milestone, 543,
iast_GLOBAL (506.14 µs) : 484, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (478.053 µs) : 456, 500
.   : milestone, 478,
iast_INACTIVE (444.065 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (471.313 µs) : 450, 492
.   : milestone, 471,
tracing (437.676 µs) : 416, 459
.   : milestone, 438,
section candidate
no_agent (365.151 µs) : 346, 385
.   : milestone, 365,
iast (477.805 µs) : 456, 499
.   : milestone, 478,
iast_FULL (544.029 µs) : 523, 565
.   : milestone, 544,
iast_GLOBAL (510.878 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (475.488 µs) : 455, 496
.   : milestone, 475,
iast_INACTIVE (448.532 µs) : 427, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (465.477 µs) : 445, 486
.   : milestone, 465,
tracing (436.844 µs) : 416, 458
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.043 µs [346.055 µs, 386.031 µs] -
iast 475.749 µs [454.226 µs, 497.273 µs] 109.707 µs (30.0%)
iast_FULL 543.388 µs [522.229 µs, 564.547 µs] 177.345 µs (48.4%)
iast_GLOBAL 506.14 µs [484.265 µs, 528.014 µs] 140.097 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 478.053 µs [456.489 µs, 499.616 µs] 112.01 µs (30.6%)
iast_INACTIVE 444.065 µs [423.292 µs, 464.839 µs] 78.023 µs (21.3%)
iast_TELEMETRY_OFF 471.313 µs [450.262 µs, 492.364 µs] 105.271 µs (28.8%)
tracing 437.676 µs [416.489 µs, 458.862 µs] 71.633 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.151 µs [345.686 µs, 384.616 µs] -
iast 477.805 µs [456.18 µs, 499.431 µs] 112.654 µs (30.9%)
iast_FULL 544.029 µs [523.068 µs, 564.989 µs] 178.877 µs (49.0%)
iast_GLOBAL 510.878 µs [489.625 µs, 532.13 µs] 145.727 µs (39.9%)
iast_HARDCODED_SECRET_DISABLED 475.488 µs [454.502 µs, 496.473 µs] 110.336 µs (30.2%)
iast_INACTIVE 448.532 µs [427.422 µs, 469.642 µs] 83.381 µs (22.8%)
iast_TELEMETRY_OFF 465.477 µs [444.63 µs, 486.324 µs] 100.325 µs (27.5%)
tracing 436.844 µs [416.088 µs, 457.601 µs] 71.693 µs (19.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/graphql-bis
git_commit_date 1720513897 1720515259
git_commit_sha 9e7aa67 b25407e
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b25407e7f4
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720517250 1720517250
ci_job_id 566208699 566208699
ci_pipeline_id 38676052 38676052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.578 s) : 15578000, 15578000
.   : milestone, 15578000,
appsec (15.193 s) : 15193000, 15193000
.   : milestone, 15193000,
iast (18.775 s) : 18775000, 18775000
.   : milestone, 18775000,
iast_GLOBAL (17.829 s) : 17829000, 17829000
.   : milestone, 17829000,
profiling (15.306 s) : 15306000, 15306000
.   : milestone, 15306000,
tracing (14.685 s) : 14685000, 14685000
.   : milestone, 14685000,
section candidate
no_agent (15.663 s) : 15663000, 15663000
.   : milestone, 15663000,
appsec (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
iast (18.733 s) : 18733000, 18733000
.   : milestone, 18733000,
iast_GLOBAL (17.889 s) : 17889000, 17889000
.   : milestone, 17889000,
profiling (15.898 s) : 15898000, 15898000
.   : milestone, 15898000,
tracing (14.839 s) : 14839000, 14839000
.   : milestone, 14839000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.578 s [15.578 s, 15.578 s] -
appsec 15.193 s [15.193 s, 15.193 s] -385.0 ms (-2.5%)
iast 18.775 s [18.775 s, 18.775 s] 3.197 s (20.5%)
iast_GLOBAL 17.829 s [17.829 s, 17.829 s] 2.251 s (14.4%)
profiling 15.306 s [15.306 s, 15.306 s] -272.0 ms (-1.7%)
tracing 14.685 s [14.685 s, 14.685 s] -893.0 ms (-5.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.663 s [15.663 s, 15.663 s] -
appsec 15.093 s [15.093 s, 15.093 s] -570.0 ms (-3.6%)
iast 18.733 s [18.733 s, 18.733 s] 3.07 s (19.6%)
iast_GLOBAL 17.889 s [17.889 s, 17.889 s] 2.226 s (14.2%)
profiling 15.898 s [15.898 s, 15.898 s] 235.0 ms (1.5%)
tracing 14.839 s [14.839 s, 14.839 s] -824.0 ms (-5.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b25407e7f4, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1443, 1466
.   : milestone, 1455,
appsec (2.223 ms) : 2188, 2259
.   : milestone, 2223,
iast (1.967 ms) : 1925, 2008
.   : milestone, 1967,
iast_GLOBAL (2.008 ms) : 1966, 2051
.   : milestone, 2008,
profiling (1.849 ms) : 1814, 1885
.   : milestone, 1849,
tracing (1.833 ms) : 1801, 1866
.   : milestone, 1833,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.227 ms) : 2192, 2262
.   : milestone, 2227,
iast (1.976 ms) : 1933, 2018
.   : milestone, 1976,
iast_GLOBAL (2.013 ms) : 1971, 2054
.   : milestone, 2013,
profiling (1.865 ms) : 1831, 1899
.   : milestone, 1865,
tracing (1.832 ms) : 1800, 1865
.   : milestone, 1832,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.443 ms, 1.466 ms] -
appsec 2.223 ms [2.188 ms, 2.259 ms] 768.805 µs (52.9%)
iast 1.967 ms [1.925 ms, 2.008 ms] 512.177 µs (35.2%)
iast_GLOBAL 2.008 ms [1.966 ms, 2.051 ms] 553.641 µs (38.1%)
profiling 1.849 ms [1.814 ms, 1.885 ms] 394.795 µs (27.1%)
tracing 1.833 ms [1.801 ms, 1.866 ms] 378.618 µs (26.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.227 ms [2.192 ms, 2.262 ms] 769.588 µs (52.8%)
iast 1.976 ms [1.933 ms, 2.018 ms] 518.389 µs (35.6%)
iast_GLOBAL 2.013 ms [1.971 ms, 2.054 ms] 555.636 µs (38.1%)
profiling 1.865 ms [1.831 ms, 1.899 ms] 407.679 µs (28.0%)
tracing 1.832 ms [1.8 ms, 1.865 ms] 375.001 µs (25.7%)

@PerfectSlayer PerfectSlayer added type: bug inst: others All other instrumentations labels Jul 9, 2024
@PerfectSlayer PerfectSlayer added inst: graphql GraphQL instrumentation and removed inst: others All other instrumentations labels Jul 9, 2024
@amarziali amarziali enabled auto-merge (squash) July 9, 2024 09:54
@amarziali amarziali merged commit 5ab86d2 into master Jul 9, 2024
82 checks passed
@amarziali amarziali deleted the andrea.marziali/graphql-bis branch July 9, 2024 09:55
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 9, 2024
@nayeem-kamal nayeem-kamal changed the title GraphQl: Fix advices for 22+ Fix advices for GraphQl 22+ Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@vandonr vandonr vandonr approved these changes

Assignees
No one assigned
Labels
inst: graphql GraphQL instrumentation type: bug
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amarziali @PerfectSlayer @vandonr