Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fast codec module as only one will ever exist #7302

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Remove fast codec module as only one will ever exist #7302

merged 2 commits into from
Jul 11, 2024
+110 −145

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Jul 10, 2024 •
edited by jira bot
Loading

What Does This Do

Refactors the CodecModule implementation to make it easier to review PR

Motivation

Additional Notes

Jira ticket: APPSEC-53838

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm iast Application Security Management (IAST) labels Jul 10, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner July 10, 2024 11:12
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-codec-module
git_commit_date 1720619307 1720619444
git_commit_sha 120b584 b91c2cb
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~b91c2cb8ac
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720622161 1720622161
ci_job_id 568159472 568159472
ci_pipeline_id 38830813 38830813
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061893
Total [baseline] (10.313 s) : 0, 10313043
Agent [candidate] (1.062 s) : 0, 1062335
Total [candidate] (10.371 s) : 0, 10370932
section appsec
Agent [baseline] (1.184 s) : 0, 1183966
Total [baseline] (10.573 s) : 0, 10573221
Agent [candidate] (1.18 s) : 0, 1179964
Total [candidate] (10.571 s) : 0, 10571494
section iast
Agent [baseline] (1.17 s) : 0, 1169511
Total [baseline] (10.705 s) : 0, 10704791
Agent [candidate] (1.179 s) : 0, 1178614
Total [candidate] (10.789 s) : 0, 10788827
section profiling
Agent [baseline] (1.262 s) : 0, 1262480
Total [baseline] (10.594 s) : 0, 10593817
Agent [candidate] (1.271 s) : 0, 1270911
Total [candidate] (10.658 s) : 0, 10657604
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.184 s 122.073 ms (11.5%)
Agent iast 1.17 s 107.617 ms (10.1%)
Agent profiling 1.262 s 200.587 ms (18.9%)
Total tracing 10.313 s -
Total appsec 10.573 s 260.179 ms (2.5%)
Total iast 10.705 s 391.749 ms (3.8%)
Total profiling 10.594 s 280.775 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.18 s 117.628 ms (11.1%)
Agent iast 1.179 s 116.279 ms (10.9%)
Agent profiling 1.271 s 208.576 ms (19.6%)
Total tracing 10.371 s -
Total appsec 10.571 s 200.562 ms (1.9%)
Total iast 10.789 s 417.896 ms (4.0%)
Total profiling 10.658 s 286.673 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.556 ms) : 0, 664556
BytebuddyAgent [candidate] (664.625 ms) : 0, 664625
GlobalTracer [baseline] (304.74 ms) : 0, 304740
GlobalTracer [candidate] (304.766 ms) : 0, 304766
AppSec [baseline] (49.771 ms) : 0, 49771
AppSec [candidate] (50.081 ms) : 0, 50081
Remote Config [baseline] (664.371 µs) : 0, 664
Remote Config [candidate] (669.453 µs) : 0, 669
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.632 ms) : 0, 7632
section appsec
BytebuddyAgent [baseline] (675.075 ms) : 0, 675075
BytebuddyAgent [candidate] (675.192 ms) : 0, 675192
GlobalTracer [baseline] (299.842 ms) : 0, 299842
GlobalTracer [candidate] (298.284 ms) : 0, 298284
AppSec [baseline] (154.587 ms) : 0, 154587
AppSec [candidate] (154.038 ms) : 0, 154038
IAST [baseline] (20.583 ms) : 0, 20583
IAST [candidate] (20.914 ms) : 0, 20914
Remote Config [baseline] (628.22 µs) : 0, 628
Remote Config [candidate] (618.274 µs) : 0, 618
Telemetry [baseline] (8.953 ms) : 0, 8953
Telemetry [candidate] (6.743 ms) : 0, 6743
section iast
BytebuddyAgent [baseline] (778.223 ms) : 0, 778223
BytebuddyAgent [candidate] (784.267 ms) : 0, 784267
GlobalTracer [baseline] (295.097 ms) : 0, 295097
GlobalTracer [candidate] (297.631 ms) : 0, 297631
AppSec [baseline] (47.223 ms) : 0, 47223
AppSec [candidate] (47.413 ms) : 0, 47413
IAST [baseline] (27.073 ms) : 0, 27073
IAST [candidate] (28.144 ms) : 0, 28144
Remote Config [baseline] (583.814 µs) : 0, 584
Remote Config [candidate] (586.936 µs) : 0, 587
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (6.951 ms) : 0, 6951
section profiling
BytebuddyAgent [baseline] (661.5 ms) : 0, 661500
BytebuddyAgent [candidate] (666.333 ms) : 0, 666333
GlobalTracer [baseline] (388.133 ms) : 0, 388133
GlobalTracer [candidate] (390.948 ms) : 0, 390948
AppSec [baseline] (51.507 ms) : 0, 51507
AppSec [candidate] (51.894 ms) : 0, 51894
Remote Config [baseline] (640.208 µs) : 0, 640
Remote Config [candidate] (645.192 µs) : 0, 645
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.394 ms) : 0, 7394
ProfilingAgent [baseline] (96.265 ms) : 0, 96265
ProfilingAgent [candidate] (96.168 ms) : 0, 96168
Profiling [baseline] (96.291 ms) : 0, 96291
Profiling [candidate] (96.193 ms) : 0, 96193
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061770
Total [baseline] (8.507 s) : 0, 8507269
Agent [candidate] (1.063 s) : 0, 1062885
Total [candidate] (8.536 s) : 0, 8535714
section iast
Agent [baseline] (1.175 s) : 0, 1174852
Total [baseline] (8.96 s) : 0, 8959896
Agent [candidate] (1.17 s) : 0, 1169981
Total [candidate] (8.96 s) : 0, 8959680
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175724
Total [baseline] (8.938 s) : 0, 8938061
Agent [candidate] (1.169 s) : 0, 1169331
Total [candidate] (8.968 s) : 0, 8968142
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1166396
Total [baseline] (8.948 s) : 0, 8947880
Agent [candidate] (1.168 s) : 0, 1167810
Total [candidate] (8.945 s) : 0, 8945375
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.175 s 113.083 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 113.954 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.166 s 104.627 ms (9.9%)
Total tracing 8.507 s -
Total iast 8.96 s 452.627 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.938 s 430.792 ms (5.1%)
Total iast_TELEMETRY_OFF 8.948 s 440.611 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.17 s 107.096 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 106.446 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.168 s 104.925 ms (9.9%)
Total tracing 8.536 s -
Total iast 8.96 s 423.966 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.968 s 432.428 ms (5.1%)
Total iast_TELEMETRY_OFF 8.945 s 409.661 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.46 ms) : 0, 664460
BytebuddyAgent [candidate] (664.852 ms) : 0, 664852
GlobalTracer [baseline] (304.315 ms) : 0, 304315
GlobalTracer [candidate] (305.103 ms) : 0, 305103
AppSec [baseline] (50.109 ms) : 0, 50109
AppSec [candidate] (49.953 ms) : 0, 49953
Remote Config [baseline] (674.077 µs) : 0, 674
Remote Config [candidate] (675.76 µs) : 0, 676
Telemetry [baseline] (7.678 ms) : 0, 7678
Telemetry [candidate] (7.737 ms) : 0, 7737
section iast
BytebuddyAgent [baseline] (780.745 ms) : 0, 780745
BytebuddyAgent [candidate] (778.682 ms) : 0, 778682
GlobalTracer [baseline] (297.534 ms) : 0, 297534
GlobalTracer [candidate] (295.186 ms) : 0, 295186
AppSec [baseline] (48.455 ms) : 0, 48455
AppSec [candidate] (47.344 ms) : 0, 47344
IAST [baseline] (26.313 ms) : 0, 26313
IAST [candidate] (27.774 ms) : 0, 27774
Remote Config [baseline] (590.958 µs) : 0, 591
Remote Config [candidate] (590.646 µs) : 0, 591
Telemetry [baseline] (7.704 ms) : 0, 7704
Telemetry [candidate] (6.933 ms) : 0, 6933
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.421 ms) : 0, 783421
BytebuddyAgent [candidate] (778.45 ms) : 0, 778450
GlobalTracer [baseline] (295.821 ms) : 0, 295821
GlobalTracer [candidate] (295.686 ms) : 0, 295686
AppSec [baseline] (47.527 ms) : 0, 47527
AppSec [candidate] (47.423 ms) : 0, 47423
IAST [baseline] (27.832 ms) : 0, 27832
IAST [candidate] (26.613 ms) : 0, 26613
Remote Config [baseline] (573.217 µs) : 0, 573
Remote Config [candidate] (583.782 µs) : 0, 584
Telemetry [baseline] (6.917 ms) : 0, 6917
Telemetry [candidate] (7.019 ms) : 0, 7019
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.088 ms) : 0, 776088
BytebuddyAgent [candidate] (776.251 ms) : 0, 776251
GlobalTracer [baseline] (294.855 ms) : 0, 294855
GlobalTracer [candidate] (295.9 ms) : 0, 295900
AppSec [baseline] (47.051 ms) : 0, 47051
AppSec [candidate] (47.064 ms) : 0, 47064
IAST [baseline] (27.489 ms) : 0, 27489
IAST [candidate] (27.692 ms) : 0, 27692
Remote Config [baseline] (605.533 µs) : 0, 606
Remote Config [candidate] (577.593 µs) : 0, 578
Telemetry [baseline] (6.775 ms) : 0, 6775
Telemetry [candidate] (6.781 ms) : 0, 6781
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-10T14:04:41 2024-07-10T14:11:26
git_branch master malvarez/iast-refactor-codec-module
git_commit_date 1720619307 1720619444
git_commit_sha 120b584 b91c2cb
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~b91c2cb8ac
start_time 2024-07-10T14:04:28 2024-07-10T14:11:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720621029 1720621029
ci_job_id 568159473 568159473
ci_pipeline_id 38830813 38830813
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1363
.   : milestone, 1344,
appsec (1.72 ms) : 1697, 1743
.   : milestone, 1720,
appsec_no_iast (1.696 ms) : 1672, 1721
.   : milestone, 1696,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.465 ms) : 1440, 1489
.   : milestone, 1465,
tracing (1.448 ms) : 1424, 1473
.   : milestone, 1448,
section candidate
no_agent (1.346 ms) : 1325, 1366
.   : milestone, 1346,
appsec (1.708 ms) : 1684, 1731
.   : milestone, 1708,
appsec_no_iast (1.715 ms) : 1692, 1739
.   : milestone, 1715,
iast (1.482 ms) : 1459, 1504
.   : milestone, 1482,
profiling (1.481 ms) : 1457, 1505
.   : milestone, 1481,
tracing (1.444 ms) : 1419, 1468
.   : milestone, 1444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.324 ms, 1.363 ms] -
appsec 1.72 ms [1.697 ms, 1.743 ms] 376.123 µs (28.0%)
appsec_no_iast 1.696 ms [1.672 ms, 1.721 ms] 352.762 µs (26.3%)
iast 1.482 ms [1.459 ms, 1.505 ms] 138.504 µs (10.3%)
profiling 1.465 ms [1.44 ms, 1.489 ms] 121.166 µs (9.0%)
tracing 1.448 ms [1.424 ms, 1.473 ms] 104.702 µs (7.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.325 ms, 1.366 ms] -
appsec 1.708 ms [1.684 ms, 1.731 ms] 361.984 µs (26.9%)
appsec_no_iast 1.715 ms [1.692 ms, 1.739 ms] 369.764 µs (27.5%)
iast 1.482 ms [1.459 ms, 1.504 ms] 135.938 µs (10.1%)
profiling 1.481 ms [1.457 ms, 1.505 ms] 135.361 µs (10.1%)
tracing 1.444 ms [1.419 ms, 1.468 ms] 98.059 µs (7.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.746 µs) : 342, 384
.   : milestone, 363,
iast (473.926 µs) : 453, 495
.   : milestone, 474,
iast_FULL (546.392 µs) : 525, 568
.   : milestone, 546,
iast_GLOBAL (497.557 µs) : 476, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (472.101 µs) : 451, 493
.   : milestone, 472,
iast_INACTIVE (449.127 µs) : 428, 471
.   : milestone, 449,
iast_TELEMETRY_OFF (463.198 µs) : 442, 484
.   : milestone, 463,
tracing (438.027 µs) : 417, 459
.   : milestone, 438,
section candidate
no_agent (363.837 µs) : 344, 384
.   : milestone, 364,
iast (480.474 µs) : 459, 502
.   : milestone, 480,
iast_FULL (544.992 µs) : 524, 566
.   : milestone, 545,
iast_GLOBAL (502.584 µs) : 481, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (469.814 µs) : 449, 491
.   : milestone, 470,
iast_INACTIVE (450.183 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (472.515 µs) : 451, 494
.   : milestone, 473,
tracing (437.417 µs) : 417, 458
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.746 µs [341.649 µs, 383.842 µs] -
iast 473.926 µs [453.133 µs, 494.718 µs] 111.18 µs (30.6%)
iast_FULL 546.392 µs [525.277 µs, 567.507 µs] 183.646 µs (50.6%)
iast_GLOBAL 497.557 µs [476.471 µs, 518.643 µs] 134.811 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 472.101 µs [451.347 µs, 492.854 µs] 109.355 µs (30.1%)
iast_INACTIVE 449.127 µs [427.521 µs, 470.733 µs] 86.381 µs (23.8%)
iast_TELEMETRY_OFF 463.198 µs [442.36 µs, 484.036 µs] 100.452 µs (27.7%)
tracing 438.027 µs [417.342 µs, 458.712 µs] 75.281 µs (20.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.837 µs [343.762 µs, 383.912 µs] -
iast 480.474 µs [458.958 µs, 501.99 µs] 116.637 µs (32.1%)
iast_FULL 544.992 µs [523.802 µs, 566.182 µs] 181.155 µs (49.8%)
iast_GLOBAL 502.584 µs [481.036 µs, 524.131 µs] 138.747 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 469.814 µs [449.097 µs, 490.532 µs] 105.977 µs (29.1%)
iast_INACTIVE 450.183 µs [428.592 µs, 471.774 µs] 86.346 µs (23.7%)
iast_TELEMETRY_OFF 472.515 µs [450.864 µs, 494.167 µs] 108.678 µs (29.9%)
tracing 437.417 µs [416.732 µs, 458.101 µs] 73.58 µs (20.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-refactor-codec-module
git_commit_date 1720619307 1720619444
git_commit_sha 120b584 b91c2cb
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~b91c2cb8ac
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720621652 1720621652
ci_job_id 568159474 568159474
ci_pipeline_id 38830813 38830813
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.228 ms) : 2192, 2263
.   : milestone, 2228,
iast (1.972 ms) : 1930, 2013
.   : milestone, 1972,
iast_GLOBAL (2.008 ms) : 1966, 2050
.   : milestone, 2008,
profiling (1.863 ms) : 1829, 1897
.   : milestone, 1863,
tracing (1.836 ms) : 1804, 1869
.   : milestone, 1836,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.222 ms) : 2188, 2257
.   : milestone, 2222,
iast (1.972 ms) : 1930, 2014
.   : milestone, 1972,
iast_GLOBAL (2.02 ms) : 1978, 2062
.   : milestone, 2020,
profiling (1.863 ms) : 1828, 1898
.   : milestone, 1863,
tracing (1.837 ms) : 1805, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.228 ms [2.192 ms, 2.263 ms] 771.886 µs (53.0%)
iast 1.972 ms [1.93 ms, 2.013 ms] 515.828 µs (35.4%)
iast_GLOBAL 2.008 ms [1.966 ms, 2.05 ms] 552.053 µs (37.9%)
profiling 1.863 ms [1.829 ms, 1.897 ms] 407.273 µs (28.0%)
tracing 1.836 ms [1.804 ms, 1.869 ms] 380.641 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.222 ms [2.188 ms, 2.257 ms] 764.972 µs (52.5%)
iast 1.972 ms [1.93 ms, 2.014 ms] 514.555 µs (35.3%)
iast_GLOBAL 2.02 ms [1.978 ms, 2.062 ms] 562.848 µs (38.6%)
profiling 1.863 ms [1.828 ms, 1.898 ms] 405.632 µs (27.8%)
tracing 1.837 ms [1.805 ms, 1.87 ms] 379.717 µs (26.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.22 s) : 15220000, 15220000
.   : milestone, 15220000,
appsec (14.768 s) : 14768000, 14768000
.   : milestone, 14768000,
iast (18.65 s) : 18650000, 18650000
.   : milestone, 18650000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
.   : milestone, 18035000,
profiling (15.402 s) : 15402000, 15402000
.   : milestone, 15402000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
section candidate
no_agent (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
appsec (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
iast (18.898 s) : 18898000, 18898000
.   : milestone, 18898000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
.   : milestone, 17743000,
profiling (15.435 s) : 15435000, 15435000
.   : milestone, 15435000,
tracing (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.22 s [15.22 s, 15.22 s] -
appsec 14.768 s [14.768 s, 14.768 s] -452.0 ms (-3.0%)
iast 18.65 s [18.65 s, 18.65 s] 3.43 s (22.5%)
iast_GLOBAL 18.035 s [18.035 s, 18.035 s] 2.815 s (18.5%)
profiling 15.402 s [15.402 s, 15.402 s] 182.0 ms (1.2%)
tracing 15.037 s [15.037 s, 15.037 s] -183.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.997 s [14.997 s, 14.997 s] -
appsec 14.999 s [14.999 s, 14.999 s] 2.0 ms (0.0%)
iast 18.898 s [18.898 s, 18.898 s] 3.901 s (26.0%)
iast_GLOBAL 17.743 s [17.743 s, 17.743 s] 2.746 s (18.3%)
profiling 15.435 s [15.435 s, 15.435 s] 438.0 ms (2.9%)
tracing 14.918 s [14.918 s, 14.918 s] -79.0 ms (-0.5%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit e25c56d into master Jul 11, 2024
82 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-refactor-codec-module branch July 11, 2024 07:37
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuel-alvarez-alvarez @jandro996