Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support field-injection of record classes #7308

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Support field-injection of record classes #7308

merged 1 commit into from
Jul 11, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jul 11, 2024

No description provided.

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jul 11, 2024
@mcculls mcculls requested a review from a team as a code owner July 11, 2024 11:02
amarziali
amarziali approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-field-injection-of-record-types
git_commit_date 1720688910 1720695462
git_commit_sha 8b00e3e 0bb84bc
release_version 1.38.0-SNAPSHOT~8b00e3e102 1.38.0-SNAPSHOT~0bb84bc7c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720698071 1720698071
ci_job_id 569320454 569320454
ci_pipeline_id 38924693 38924693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073624
Total [baseline] (8.517 s) : 0, 8517158
Agent [candidate] (1.069 s) : 0, 1068914
Total [candidate] (8.536 s) : 0, 8535632
section iast
Agent [baseline] (1.168 s) : 0, 1167833
Total [baseline] (8.96 s) : 0, 8959659
Agent [candidate] (1.171 s) : 0, 1170727
Total [candidate] (8.969 s) : 0, 8969124
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170647
Total [baseline] (8.936 s) : 0, 8935688
Agent [candidate] (1.171 s) : 0, 1171209
Total [candidate] (8.922 s) : 0, 8922226
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176772
Total [baseline] (8.961 s) : 0, 8960840
Agent [candidate] (1.167 s) : 0, 1166508
Total [candidate] (8.925 s) : 0, 8925034
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.168 s 94.209 ms (8.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 97.023 ms (9.0%)
Agent iast_TELEMETRY_OFF 1.177 s 103.148 ms (9.6%)
Total tracing 8.517 s -
Total iast 8.96 s 442.501 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.936 s 418.531 ms (4.9%)
Total iast_TELEMETRY_OFF 8.961 s 443.683 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.171 s 101.813 ms (9.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 102.295 ms (9.6%)
Agent iast_TELEMETRY_OFF 1.167 s 97.595 ms (9.1%)
Total tracing 8.536 s -
Total iast 8.969 s 433.492 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.922 s 386.594 ms (4.5%)
Total iast_TELEMETRY_OFF 8.925 s 389.402 ms (4.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.229 ms) : 0, 673229
BytebuddyAgent [candidate] (668.802 ms) : 0, 668802
GlobalTracer [baseline] (306.863 ms) : 0, 306863
GlobalTracer [candidate] (306.808 ms) : 0, 306808
AppSec [baseline] (50.278 ms) : 0, 50278
AppSec [candidate] (50.226 ms) : 0, 50226
Remote Config [baseline] (678.289 µs) : 0, 678
Remote Config [candidate] (688.788 µs) : 0, 689
Telemetry [baseline] (7.709 ms) : 0, 7709
Telemetry [candidate] (7.705 ms) : 0, 7705
section iast
BytebuddyAgent [baseline] (778.192 ms) : 0, 778192
BytebuddyAgent [candidate] (779.115 ms) : 0, 779115
GlobalTracer [baseline] (294.673 ms) : 0, 294673
GlobalTracer [candidate] (295.448 ms) : 0, 295448
AppSec [baseline] (47.989 ms) : 0, 47989
AppSec [candidate] (49.555 ms) : 0, 49555
IAST [baseline] (25.143 ms) : 0, 25143
IAST [candidate] (25.481 ms) : 0, 25481
Remote Config [baseline] (588.772 µs) : 0, 589
Remote Config [candidate] (582.257 µs) : 0, 582
Telemetry [baseline] (7.79 ms) : 0, 7790
Telemetry [candidate] (7.053 ms) : 0, 7053
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.715 ms) : 0, 778715
BytebuddyAgent [candidate] (779.006 ms) : 0, 779006
GlobalTracer [baseline] (295.14 ms) : 0, 295140
GlobalTracer [candidate] (295.427 ms) : 0, 295427
AppSec [baseline] (47.022 ms) : 0, 47022
AppSec [candidate] (47.075 ms) : 0, 47075
IAST [baseline] (28.75 ms) : 0, 28750
IAST [candidate] (28.687 ms) : 0, 28687
Remote Config [baseline] (571.144 µs) : 0, 571
Remote Config [candidate] (555.903 µs) : 0, 556
Telemetry [baseline] (6.939 ms) : 0, 6939
Telemetry [candidate] (6.9 ms) : 0, 6900
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (783.157 ms) : 0, 783157
BytebuddyAgent [candidate] (775.221 ms) : 0, 775221
GlobalTracer [baseline] (296.814 ms) : 0, 296814
GlobalTracer [candidate] (295.281 ms) : 0, 295281
AppSec [baseline] (47.375 ms) : 0, 47375
AppSec [candidate] (46.998 ms) : 0, 46998
IAST [baseline] (27.614 ms) : 0, 27614
IAST [candidate] (28.206 ms) : 0, 28206
Remote Config [baseline] (579.558 µs) : 0, 580
Remote Config [candidate] (556.191 µs) : 0, 556
Telemetry [baseline] (7.613 ms) : 0, 7613
Telemetry [candidate] (6.746 ms) : 0, 6746
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071215
Total [baseline] (10.385 s) : 0, 10385478
Agent [candidate] (1.063 s) : 0, 1062932
Total [candidate] (10.343 s) : 0, 10343141
section appsec
Agent [baseline] (1.185 s) : 0, 1185038
Total [baseline] (10.545 s) : 0, 10544814
Agent [candidate] (1.186 s) : 0, 1185996
Total [candidate] (10.536 s) : 0, 10535513
section iast
Agent [baseline] (1.179 s) : 0, 1179223
Total [baseline] (10.755 s) : 0, 10755088
Agent [candidate] (1.188 s) : 0, 1188241
Total [candidate] (10.787 s) : 0, 10786859
section profiling
Agent [baseline] (1.264 s) : 0, 1263840
Total [baseline] (10.613 s) : 0, 10612644
Agent [candidate] (1.279 s) : 0, 1279401
Total [candidate] (10.585 s) : 0, 10584560
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.185 s 113.823 ms (10.6%)
Agent iast 1.179 s 108.008 ms (10.1%)
Agent profiling 1.264 s 192.625 ms (18.0%)
Total tracing 10.385 s -
Total appsec 10.545 s 159.336 ms (1.5%)
Total iast 10.755 s 369.61 ms (3.6%)
Total profiling 10.613 s 227.166 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.186 s 123.065 ms (11.6%)
Agent iast 1.188 s 125.309 ms (11.8%)
Agent profiling 1.279 s 216.47 ms (20.4%)
Total tracing 10.343 s -
Total appsec 10.536 s 192.373 ms (1.9%)
Total iast 10.787 s 443.718 ms (4.3%)
Total profiling 10.585 s 241.419 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.407 ms) : 0, 670407
BytebuddyAgent [candidate] (665.593 ms) : 0, 665593
GlobalTracer [baseline] (307.283 ms) : 0, 307283
GlobalTracer [candidate] (304.632 ms) : 0, 304632
AppSec [baseline] (50.349 ms) : 0, 50349
AppSec [candidate] (49.761 ms) : 0, 49761
Remote Config [baseline] (680.683 µs) : 0, 681
Remote Config [candidate] (668.112 µs) : 0, 668
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.705 ms) : 0, 7705
section appsec
BytebuddyAgent [baseline] (677.769 ms) : 0, 677769
BytebuddyAgent [candidate] (677.991 ms) : 0, 677991
GlobalTracer [baseline] (299.447 ms) : 0, 299447
GlobalTracer [candidate] (299.794 ms) : 0, 299794
AppSec [baseline] (154.005 ms) : 0, 154005
AppSec [candidate] (154.078 ms) : 0, 154078
IAST [baseline] (19.083 ms) : 0, 19083
IAST [candidate] (20.842 ms) : 0, 20842
Remote Config [baseline] (624.008 µs) : 0, 624
Remote Config [candidate] (626.275 µs) : 0, 626
Telemetry [baseline] (8.883 ms) : 0, 8883
Telemetry [candidate] (8.323 ms) : 0, 8323
section iast
BytebuddyAgent [baseline] (784.708 ms) : 0, 784708
BytebuddyAgent [candidate] (791.324 ms) : 0, 791324
GlobalTracer [baseline] (297.413 ms) : 0, 297413
GlobalTracer [candidate] (299.973 ms) : 0, 299973
AppSec [baseline] (47.415 ms) : 0, 47415
AppSec [candidate] (47.919 ms) : 0, 47919
IAST [baseline] (27.697 ms) : 0, 27697
IAST [candidate] (26.786 ms) : 0, 26786
Remote Config [baseline] (575.089 µs) : 0, 575
Remote Config [candidate] (586.924 µs) : 0, 587
Telemetry [baseline] (7.787 ms) : 0, 7787
Telemetry [candidate] (7.918 ms) : 0, 7918
section profiling
BytebuddyAgent [baseline] (661.929 ms) : 0, 661929
BytebuddyAgent [candidate] (671.268 ms) : 0, 671268
GlobalTracer [baseline] (389.408 ms) : 0, 389408
GlobalTracer [candidate] (392.682 ms) : 0, 392682
AppSec [baseline] (51.647 ms) : 0, 51647
AppSec [candidate] (52.367 ms) : 0, 52367
Remote Config [baseline] (647.082 µs) : 0, 647
Remote Config [candidate] (656.467 µs) : 0, 656
Telemetry [baseline] (7.312 ms) : 0, 7312
Telemetry [candidate] (7.454 ms) : 0, 7454
ProfilingAgent [baseline] (95.783 ms) : 0, 95783
ProfilingAgent [candidate] (97.144 ms) : 0, 97144
Profiling [baseline] (95.808 ms) : 0, 95808
Profiling [candidate] (97.169 ms) : 0, 97169
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-11T11:11:57 2024-07-11T11:18:45
git_branch master mcculls/support-field-injection-of-record-types
git_commit_date 1720688910 1720695462
git_commit_sha 8b00e3e 0bb84bc
release_version 1.38.0-SNAPSHOT~8b00e3e102 1.38.0-SNAPSHOT~0bb84bc7c1
start_time 2024-07-11T11:11:44 2024-07-11T11:18:31
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720697068 1720697068
ci_job_id 569320455 569320455
ci_pipeline_id 38924693 38924693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1319, 1358
.   : milestone, 1338,
appsec (1.724 ms) : 1701, 1747
.   : milestone, 1724,
appsec_no_iast (1.698 ms) : 1674, 1723
.   : milestone, 1698,
iast (1.49 ms) : 1467, 1514
.   : milestone, 1490,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.45 ms) : 1426, 1475
.   : milestone, 1450,
section candidate
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.711 ms) : 1688, 1735
.   : milestone, 1711,
appsec_no_iast (1.7 ms) : 1675, 1725
.   : milestone, 1700,
iast (1.477 ms) : 1454, 1500
.   : milestone, 1477,
profiling (1.483 ms) : 1458, 1507
.   : milestone, 1483,
tracing (1.46 ms) : 1435, 1485
.   : milestone, 1460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.358 ms] -
appsec 1.724 ms [1.701 ms, 1.747 ms] 385.565 µs (28.8%)
appsec_no_iast 1.698 ms [1.674 ms, 1.723 ms] 359.945 µs (26.9%)
iast 1.49 ms [1.467 ms, 1.514 ms] 151.935 µs (11.4%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 147.044 µs (11.0%)
tracing 1.45 ms [1.426 ms, 1.475 ms] 111.862 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.711 ms [1.688 ms, 1.735 ms] 366.408 µs (27.2%)
appsec_no_iast 1.7 ms [1.675 ms, 1.725 ms] 355.107 µs (26.4%)
iast 1.477 ms [1.454 ms, 1.5 ms] 132.379 µs (9.8%)
profiling 1.483 ms [1.458 ms, 1.507 ms] 137.98 µs (10.3%)
tracing 1.46 ms [1.435 ms, 1.485 ms] 115.155 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.279 µs) : 347, 386
.   : milestone, 366,
iast (475.629 µs) : 455, 497
.   : milestone, 476,
iast_FULL (550.852 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (508.694 µs) : 487, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (480.963 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (449.815 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (467.043 µs) : 446, 488
.   : milestone, 467,
tracing (434.604 µs) : 414, 455
.   : milestone, 435,
section candidate
no_agent (363.94 µs) : 344, 384
.   : milestone, 364,
iast (478.105 µs) : 457, 499
.   : milestone, 478,
iast_FULL (545.522 µs) : 525, 566
.   : milestone, 546,
iast_GLOBAL (509.152 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (484.53 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (449.258 µs) : 429, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (469.558 µs) : 448, 491
.   : milestone, 470,
tracing (438.247 µs) : 418, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.279 µs [346.583 µs, 385.975 µs] -
iast 475.629 µs [454.568 µs, 496.69 µs] 109.35 µs (29.9%)
iast_FULL 550.852 µs [529.917 µs, 571.788 µs] 184.573 µs (50.4%)
iast_GLOBAL 508.694 µs [487.29 µs, 530.098 µs] 142.415 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 480.963 µs [460.104 µs, 501.823 µs] 114.684 µs (31.3%)
iast_INACTIVE 449.815 µs [428.81 µs, 470.82 µs] 83.536 µs (22.8%)
iast_TELEMETRY_OFF 467.043 µs [446.469 µs, 487.617 µs] 100.764 µs (27.5%)
tracing 434.604 µs [414.279 µs, 454.929 µs] 68.325 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.94 µs [344.332 µs, 383.549 µs] -
iast 478.105 µs [457.117 µs, 499.093 µs] 114.165 µs (31.4%)
iast_FULL 545.522 µs [524.662 µs, 566.381 µs] 181.581 µs (49.9%)
iast_GLOBAL 509.152 µs [487.301 µs, 531.004 µs] 145.212 µs (39.9%)
iast_HARDCODED_SECRET_DISABLED 484.53 µs [463.461 µs, 505.599 µs] 120.59 µs (33.1%)
iast_INACTIVE 449.258 µs [428.634 µs, 469.883 µs] 85.318 µs (23.4%)
iast_TELEMETRY_OFF 469.558 µs [448.297 µs, 490.818 µs] 105.617 µs (29.0%)
tracing 438.247 µs [417.975 µs, 458.519 µs] 74.307 µs (20.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-field-injection-of-record-types
git_commit_date 1720688910 1720695462
git_commit_sha 8b00e3e 0bb84bc
release_version 1.38.0-SNAPSHOT~8b00e3e102 1.38.0-SNAPSHOT~0bb84bc7c1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720697604 1720697604
ci_job_id 569320456 569320456
ci_pipeline_id 38924693 38924693
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.73 s) : 15730000, 15730000
.   : milestone, 15730000,
appsec (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
iast (18.751 s) : 18751000, 18751000
.   : milestone, 18751000,
iast_GLOBAL (17.75 s) : 17750000, 17750000
.   : milestone, 17750000,
profiling (15.314 s) : 15314000, 15314000
.   : milestone, 15314000,
tracing (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
section candidate
no_agent (15.483 s) : 15483000, 15483000
.   : milestone, 15483000,
appsec (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
iast (18.5 s) : 18500000, 18500000
.   : milestone, 18500000,
iast_GLOBAL (17.692 s) : 17692000, 17692000
.   : milestone, 17692000,
profiling (14.785 s) : 14785000, 14785000
.   : milestone, 14785000,
tracing (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.73 s [15.73 s, 15.73 s] -
appsec 15.133 s [15.133 s, 15.133 s] -597.0 ms (-3.8%)
iast 18.751 s [18.751 s, 18.751 s] 3.021 s (19.2%)
iast_GLOBAL 17.75 s [17.75 s, 17.75 s] 2.02 s (12.8%)
profiling 15.314 s [15.314 s, 15.314 s] -416.0 ms (-2.6%)
tracing 14.995 s [14.995 s, 14.995 s] -735.0 ms (-4.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.483 s [15.483 s, 15.483 s] -
appsec 14.851 s [14.851 s, 14.851 s] -632.0 ms (-4.1%)
iast 18.5 s [18.5 s, 18.5 s] 3.017 s (19.5%)
iast_GLOBAL 17.692 s [17.692 s, 17.692 s] 2.209 s (14.3%)
profiling 14.785 s [14.785 s, 14.785 s] -698.0 ms (-4.5%)
tracing 15.036 s [15.036 s, 15.036 s] -447.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~0bb84bc7c1, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1485
.   : milestone, 1473,
appsec (2.236 ms) : 2202, 2271
.   : milestone, 2236,
iast (1.965 ms) : 1924, 2007
.   : milestone, 1965,
iast_GLOBAL (2.015 ms) : 1972, 2059
.   : milestone, 2015,
profiling (1.863 ms) : 1830, 1897
.   : milestone, 1863,
tracing (1.849 ms) : 1817, 1882
.   : milestone, 1849,
section candidate
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.214 ms) : 2180, 2249
.   : milestone, 2214,
iast (1.97 ms) : 1928, 2012
.   : milestone, 1970,
iast_GLOBAL (2.008 ms) : 1966, 2050
.   : milestone, 2008,
profiling (1.865 ms) : 1830, 1899
.   : milestone, 1865,
tracing (1.837 ms) : 1805, 1869
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.485 ms] -
appsec 2.236 ms [2.202 ms, 2.271 ms] 763.559 µs (51.8%)
iast 1.965 ms [1.924 ms, 2.007 ms] 492.49 µs (33.4%)
iast_GLOBAL 2.015 ms [1.972 ms, 2.059 ms] 542.176 µs (36.8%)
profiling 1.863 ms [1.83 ms, 1.897 ms] 390.326 µs (26.5%)
tracing 1.849 ms [1.817 ms, 1.882 ms] 376.493 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.214 ms [2.18 ms, 2.249 ms] 754.999 µs (51.7%)
iast 1.97 ms [1.928 ms, 2.012 ms] 510.827 µs (35.0%)
iast_GLOBAL 2.008 ms [1.966 ms, 2.05 ms] 548.292 µs (37.6%)
profiling 1.865 ms [1.83 ms, 1.899 ms] 405.141 µs (27.8%)
tracing 1.837 ms [1.805 ms, 1.869 ms] 377.581 µs (25.9%)

PerfectSlayer
PerfectSlayer reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question: what's preventing us to migrate all ASM version to 9?

@mcculls
Copy link
Contributor Author

mcculls commented Jul 11, 2024 •
edited
Loading

Use of the ASM9 API version only unlocks use of PermittedSubclasses which isn't required by field-injection.

Previously we've kept the API version at the level that we use/need - we could bump everything to the latest API level and it shouldn't make much difference, but for this specific PR I wanted to just do a small increment.

But you could create a PR to introduce a new shared constant representing the embedded API version (currently 9) and use that everywhere...

@mcculls mcculls merged commit 95a52cc into master Jul 11, 2024
84 checks passed
@mcculls mcculls deleted the mcculls/support-field-injection-of-record-types branch July 11, 2024 12:21
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 11, 2024
@PerfectSlayer
Copy link
Contributor

PerfectSlayer commented Jul 11, 2024 •
edited
Loading

But you could create a PR to introduce a new shared constant representing the embedded API version (currently 9) and use that everywhere...

That was one of my thoughts as we end up using different values across the code base.

Thanks for the details! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@amarziali amarziali amarziali approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcculls @PerfectSlayer @amarziali