Add instrumentation for Tomcat webapp classloading #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-kolya
force-pushed
the
mar-kolya/tomcat-classloadin-instrumentation
branch
from
99fa027
to
bc00349
Compare
|
I don't understand the purpose of this... please add some comments in the code and update the PR description. |
mar-kolya
force-pushed
the
mar-kolya/tomcat-classloadin-instrumentation
branch
from
bc00349
to
aa031cc
Compare
|
Added a comment into the code as well |
tylerbenson
approved these changes
Feb 28, 2019
|
Well, kind of, yes. The goal is still the same: make app classloader load these classes off bootstrap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really the same thing we already do for OSGi and jboss.
The problem is that tomcat (and other app servers) have classloaders that do not delegate to parent.
This causes problems,
for example in case of tomcat things like
GlobalTracerwere loaded twice: ones by bootstrap and once by app loader. This resulted in having to separateGlobalTracersin place where it should have been just one.