Add config allowing classes to be excluded from transformation #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following system property or corresponding environment variable: ``` dd.trace.classes.exclude=some.packagename.*,some.classname.MyClass$NestedClass ```
labbati
approved these changes
Apr 23, 2019
| addDecorator(decorator); | ||
| } | ||
|
|
||
| registerClassLoader(ClassLoader.getSystemClassLoader()); |
There was a problem hiding this comment.
Is this line related to this PR or a left over?
There was a problem hiding this comment.
This was a very minor change intended to improve comprehension of log statement order. I'll try to reduce unrelated changes in PRs going forward.
| @@ -42,6 +38,7 @@ public void handle(final Context ctx) { | |||
| DECORATE.afterStart(ratpackSpan); | |||
| DECORATE.onConnection(ratpackSpan, request); | |||
| DECORATE.onRequest(ratpackSpan, request); | |||
| ctx.getExecution().add(ratpackSpan); | |||
There was a problem hiding this comment.
I don't think this LOC is related to this PR right?
There was a problem hiding this comment.
No, I slipped in a few other misc changes.
| public FluxAndMonoInstrumentation() { | ||
| super("reactor-core"); | ||
| } | ||
|
|
||
| @Override | ||
| public String[] helperClassNames() { | ||
| return new String[] { | ||
| PACKAGE + ".ReactorCoreAdviceUtils", PACKAGE + ".ReactorCoreAdviceUtils$TracingSubscriber" | ||
| packageName + ".ReactorCoreAdviceUtils", |
There was a problem hiding this comment.
I don't think these LOCs are related to this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following system property or corresponding environment variable: