Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dd.trace.db.client.split-by-instance Config #881

Merged
merged 1 commit into from Jun 14, 2019

Conversation

tylerbenson
Copy link
Contributor

@tylerbenson tylerbenson commented Jun 13, 2019

When enabled, sets the db client's span's service.name to the instance name (if available).

To enable:

  • System Property: -Ddd.trace.db.client.split-by-instance=true
  • Environment Variable: DD_TRACE_DB_CLIENT_SPLIT_BY_INSTANCE=true

Additional integration testing to follow in separate PR.

@tylerbenson tylerbenson requested a review from a team as a code owner June 13, 2019 21:31
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions

Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@tylerbenson tylerbenson merged commit e8246f6 into master Jun 14, 2019
@tylerbenson tylerbenson deleted the tyler/instance-name branch June 14, 2019 15:40
@tylerbenson tylerbenson added this to the 0.30.0 milestone Jun 14, 2019
@tylerbenson tylerbenson added the comp: core Tracer core label Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants