Calculate depth per-handler class in netty channel pipeline instrumentation #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous implementation of the netty's channel pipeline assumed that the only way to add
ChannelHandler
was throughChannelPipeline#add*
methods called from some other service.In reality it might happen (and this is what happens with reactor 0.8.* when it registers the
HttpServerCodec
that theaddLast
method is called from a concrete channel handler extending aChannelInitializer
. In this case new handler can be added while the parent channel handler is added, where the theinitChannel
method can be used to add additional handlers.This PR adds the possibility to handle such cases, while preventing recursions that our pre-existing safety nets (that caused the new version of reactor to not work) where there to prevent