Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate depth per-handler class in netty channel pipeline instrumentation #900

Merged
merged 4 commits into from Jun 26, 2019

Conversation

labbati
Copy link
Member

@labbati labbati commented Jun 24, 2019

Our previous implementation of the netty's channel pipeline assumed that the only way to add ChannelHandler was through ChannelPipeline#add* methods called from some other service.

In reality it might happen (and this is what happens with reactor 0.8.* when it registers the HttpServerCodec that the addLast method is called from a concrete channel handler extending a ChannelInitializer. In this case new handler can be added while the parent channel handler is added, where the the initChannel method can be used to add additional handlers.

This PR adds the possibility to handle such cases, while preventing recursions that our pre-existing safety nets (that caused the new version of reactor to not work) where there to prevent

@labbati labbati force-pushed the labbati/reactor-08 branch 2 times, most recently from da9d1ae to 17c5edc Compare June 24, 2019 11:15
@labbati labbati marked this pull request as ready for review June 24, 2019 22:31
@labbati labbati requested a review from a team as a code owner June 24, 2019 22:31
@labbati labbati merged commit d5227cd into master Jun 26, 2019
@tylerbenson tylerbenson added this to the 0.31.0 milestone Jul 10, 2019
@tylerbenson tylerbenson deleted the labbati/reactor-08 branch July 10, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants