Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument records(TopicPartition) in kafka consumer #911

Merged
merged 9 commits into from Jul 12, 2019
Merged

Instrument records(TopicPartition) in kafka consumer #911

merged 9 commits into from Jul 12, 2019

Conversation

mar-kolya
Copy link
Contributor

@mar-kolya mar-kolya commented Jul 10, 2019 •
edited

No description provided.

@mar-kolya mar-kolya requested a review from a team as a code owner July 10, 2019 17:48
@mar-kolya mar-kolya mentioned this pull request Jul 10, 2019
Closed
tylerbenson
tylerbenson suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work because we modify the return type. Needs to be a separate advice.

@mar-kolya mar-kolya changed the title Kafka instrumentation: make return type more general in instrumentati… Instrument records(TopicPartition) in kafka consumer Jul 11, 2019
@mar-kolya
Copy link
Contributor Author

@tylerbenson Could you please have another lookl

@mar-kolya mar-kolya requested a review from a team July 11, 2019 15:21
tylerbenson
tylerbenson approved these changes Jul 12, 2019
View reviewed changes
...afka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/TracingList.java Outdated

@Override
public ListIterator<ConsumerRecord> listIterator() {
// TODO: should this be instrumented as well?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is enough in that API that scares me to suggest we don't instrument it. I think maybe change the comment to explain this.

@mar-kolya mar-kolya merged commit 65c6b1f into master Jul 12, 2019
@mar-kolya mar-kolya deleted the mar-kolya/kafka-trace-records branch July 12, 2019 22:43
@tylerbenson tylerbenson added this to the 0.31.0 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mar-kolya @tylerbenson