Add resource name to the @Trace annotation #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
approved these changes
Jul 19, 2019
| if (resourceName != null | ||
| && !resourceName.isEmpty() | ||
| && spanBuilder instanceof DDTracer.DDSpanBuilder) { | ||
| spanBuilder = ((DDTracer.DDSpanBuilder) spanBuilder).withResourceName(resourceName); |
There was a problem hiding this comment.
Integrations should only reference classes in dd-trace-api or OpenTracing, not dd-trace-ot. The better way to set the resource name is via setting a tag:
spanBuilder = spanBuilder.withTag(DDTags.RESOURCE_NAME, resourceName);There was a problem hiding this comment.
(If you make this change, you wouldn't need to add the builder as a helper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add
resourceNameto the@Traceannotation to be used alone or in tandem withoperationName.Most of the actual code changes are added tests.