Add instrumentation and tests for Grizzly 2.x Http Server #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/grizzly
branch
2 times, most recently
from
f81f263
to
4b095a6
Compare
tylerbenson
force-pushed
the
tyler/grizzly
branch
from
4b095a6
to
f5b7326
Compare
randomanderson
requested changes
Aug 14, 2019
|
|
||
| @Override | ||
| protected String[] instrumentationNames() { | ||
| return new String[] {"jersey"}; |
|
|
||
| @Override | ||
| protected String component() { | ||
| return "jersey"; |
| } | ||
|
|
||
| @Path("/") | ||
| static class ServiceResource { |
There was a problem hiding this comment.
I think it's slightly confusing to have the same private class name in a class and superclass. Maybe ServiceResource -> AsyncServiceResource?
randomanderson
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.