Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql2 does not properly return fields #1240

Closed
bizob2828 opened this issue Feb 12, 2021 · 0 comments · Fixed by #1241
Closed

mysql2 does not properly return fields #1240

bizob2828 opened this issue Feb 12, 2021 · 0 comments · Fixed by #1241
Labels
bug Something isn't working community integrations
Milestone

Comments

@bizob2828
Copy link
Contributor

Describe the bug
I'm trying to run the agent with mysql2 and I get errors when i do

connection.query('select * from foo;', (err, result, fields) => {
});

Looking at the instrumentation it is being a bit naive and only returning err and results.

Environment

  • Operation system: N/A
  • Node version: N/A
  • Tracer version: v0.30.0
  • Agent version: N/A
@bizob2828 bizob2828 added the bug Something isn't working label Feb 12, 2021
bizob2828 added a commit to bizob2828/dd-trace-js that referenced this issue Feb 12, 2021
rochdev pushed a commit that referenced this issue Feb 12, 2021
* Fixes #1240 properly spread callback args

* remove .only and simplify loggin error
@rochdev rochdev added this to the 0.31.0 milestone Feb 12, 2021
rochdev pushed a commit that referenced this issue Feb 16, 2021
* Fixes #1240 properly spread callback args

* remove .only and simplify loggin error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community integrations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants