Fixes #1240 properly spread callback args #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if the checklist above is necessary for my change so I will defer to the maintainers of this agent |
rochdev
requested changes
Feb 12, 2021
rochdev
approved these changes
Feb 12, 2021
|
@rochdev curious on your release cadence. when would this bug fix get shipped? |
We're planning a release next Tuesday. |
|
@rochdev also thank you for such a fast review/merge 🙏🏻 |
rochdev
pushed a commit
that referenced
this pull request
Feb 16, 2021
|
Released in 0.31.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This properly spreads the callback args to fix #1240
Motivation
I want mysql2 support and use fields in my code
Plugin Checklist
Additional Notes
I updated a test, but can't get tests to run locally.