Fix TypeScript type definitions for logger config #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR DataDog#999 added startup logging. In doing so it added support for additional logging methods.
rochdev
approved these changes
Aug 24, 2020
|
The tracer logger is supposed to fallback to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #999 added startup logging. In doing so it added support for additional logging methods.
Motivation
While integrating dd-trace into my project I saw some nice debugging messages in the console. When I provided my own logger, these messages disappeared. After digging through the code I figured out that these new startup logging messages are being sent to logger methods I wasn't providing because they are undocumented, and the TypeScript types do not recognize them.
This patch makes it so those new methods are a known part of the logger object shape.
Plugin Checklist