startup logging - #999
Merged
Merged
Conversation
bengl
force-pushed
the
bengl/startuplogging
branch
3 times, most recently
from
June 29, 2020 19:32
65f60fe to
c8add2a
Compare
bengl
force-pushed
the
bengl/startuplogging
branch
from
June 29, 2020 19:54
c8add2a to
dd91773
Compare
bengl
force-pushed
the
bengl/startuplogging
branch
from
June 29, 2020 21:17
dd91773 to
a14a2db
Compare
rochdev
requested changes
Jun 29, 2020
devsnek
reviewed
Jun 30, 2020
Comment on lines
+4
to
+7
| debug: (...args) => console.log(...args), /* eslint-disable-line no-console */ | ||
| info: (...args) => console.error(...args), /* eslint-disable-line no-console */ | ||
| warn: (...args) => console.error(...args), /* eslint-disable-line no-console */ | ||
| error: (...args) => console.error(...args) /* eslint-disable-line no-console */ |
Contributor
There was a problem hiding this comment.
we could use more specific console methods:
Suggested change
| debug: (...args) => console.log(...args), /* eslint-disable-line no-console */ | |
| info: (...args) => console.error(...args), /* eslint-disable-line no-console */ | |
| warn: (...args) => console.error(...args), /* eslint-disable-line no-console */ | |
| error: (...args) => console.error(...args) /* eslint-disable-line no-console */ | |
| debug: console.debug, /* eslint-disable-line no-console */ | |
| info: console.info, /* eslint-disable-line no-console */ | |
| warn: console.warn, /* eslint-disable-line no-console */ | |
| error: console.error /* eslint-disable-line no-console */ |
Collaborator
Author
There was a problem hiding this comment.
I tried, but this breaks the tests, which stub console. Roch's suggesting of stubbing higher up at the logger would solve this though.
bengl
force-pushed
the
bengl/startuplogging
branch
from
July 1, 2020 17:43
b284c29 to
7744a39
Compare
rochdev
approved these changes
Jul 2, 2020
dandean
added a commit
to dandean/dd-trace-js
that referenced
this pull request
Aug 21, 2020
PR DataDog#999 added startup logging. In doing so it added support for additional logging methods.
6 tasks
rochdev
pushed a commit
that referenced
this pull request
Aug 24, 2020
* Fix TypeScript type definitions for logger config PR #999 added startup logging. In doing so it added support for additional logging methods. * Update markdown docs for logger * fix typescript unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds standardized startup logging as soon as we have enough information to do so.
Motivation
Help support get as much information as they can from app startup logs.