-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IPv6 URLs for agent address #2691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 3.53 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
- Coverage 89.65% 89.59% -0.06%
==========================================
Files 302 302
Lines 10505 10516 +11
Branches 33 33
==========================================
+ Hits 9418 9422 +4
- Misses 1087 1094 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
approved these changes
Jan 13, 2023
astuyve
pushed a commit
that referenced
this pull request
Jan 23, 2023
astuyve
pushed a commit
that referenced
this pull request
Jan 23, 2023
astuyve
pushed a commit
that referenced
this pull request
Jan 23, 2023
astuyve
pushed a commit
that referenced
this pull request
Jan 23, 2023
crysmags
pushed a commit
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2449
What does this PR do?
Makes IPv6 URLs for agent address work. This basically copy/pastes the
urlToOptions
helper from the http client instrumentation which itself is somewhat a copy ofurl.urlToHttpOptions
which is not yet supported across all our supported versions so I can't use that.Motivation
IPv6 agent URLs were not working correctly.