Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPv6 URLs for agent address #2691

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Support IPv6 URLs for agent address #2691

merged 1 commit into from
Jan 14, 2023

Conversation

Qard
Copy link
Collaborator

@Qard Qard commented Jan 13, 2023

Fixes #2449

What does this PR do?

Makes IPv6 URLs for agent address work. This basically copy/pastes the urlToOptions helper from the http client instrumentation which itself is somewhat a copy of url.urlToHttpOptions which is not yet supported across all our supported versions so I can't use that.

Motivation

IPv6 agent URLs were not working correctly.

@Qard Qard added bug Something isn't working semver-patch labels Jan 13, 2023
@Qard Qard requested a review from a team as a code owner January 13, 2023 19:53
@github-actions
Copy link

Overall package size

Self size: 3.53 MB
Deduped: 56.38 MB
No deduping: 62.99 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.1.1 10.9 MB 17.75 MB
@datadog/native-iast-taint-tracking 1.0.0 12.74 MB 12.75 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 1.1.2 2.06 MB 2.08 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #2691 (dd3ccc6) into master (5341b84) will decrease coverage by 0.05%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
- Coverage   89.65%   89.59%   -0.06%     
==========================================
  Files         302      302              
  Lines       10505    10516      +11     
  Branches       33       33              
==========================================
+ Hits         9418     9422       +4     
- Misses       1087     1094       +7     
Impacted Files Coverage Δ
packages/dd-trace/src/exporters/common/request.js 88.60% <30.00%> (-8.54%) ⬇️
packages/dd-trace/src/priority_sampler.js 100.00% <0.00%> (ø)
packages/dd-trace/src/format.js 99.00% <0.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2023

Benchmarks

Comparing candidate commit dd3ccc6 in PR branch support-ipv6-agent-url with baseline commit 5341b84 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 322 cases.

@Qard Qard merged commit 3b17c6b into master Jan 14, 2023
@Qard Qard deleted the support-ipv6-agent-url branch January 14, 2023 00:02
astuyve pushed a commit that referenced this pull request Jan 23, 2023
astuyve pushed a commit that referenced this pull request Jan 23, 2023
astuyve pushed a commit that referenced this pull request Jan 23, 2023
astuyve pushed a commit that referenced this pull request Jan 23, 2023
crysmags pushed a commit that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DD_AGENT_HOST is not used properly when ipv6 address
2 participants