-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] PHP-FPM + profiling + preload = segfault #1880
Comments
Please let me know if you need any further information 👍 |
Hey @B-Galati, thanks for reaching out. Could you provide us with the backtrace? $ gdb php-fpm coredump-php-fpm.3091
...
(gdb) bt And another question: does PHP-FPM segfault right away or does this happen at any later point in time, maybe even after serving some requests? /Florian |
This fixes a crash with toggling the tracing within fibers. Additionally add another safety NULL-check to ensure #1880 cannot happen. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@realFlowControl Hi and thanks! Here it is
|
This fixes a crash with toggling the tracing within fibers. Additionally add another safety NULL-check to ensure #1880 cannot happen. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This fixes a crash with toggling the tracing within fibers. Additionally add another safety NULL-check to ensure #1880 cannot happen. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
* Make active_stack infaillible: there always exists a stack This fixes a crash with toggling the tracing within fibers. Additionally add another safety NULL-check to ensure #1880 cannot happen. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Replace a couple DDTRACE_G(disable) checks by !DDTRACE_G(active_stack) Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This has been fixed by #1883. |
Thank you!! |
@B-Galati It also has been released with 0.84.0 now :-) |
That's awesome, thanks! I'm going to test that whenever I can with a feedback. |
@bwoebi Hello! I just tested with 0.84.0 but it still does not work. I can run Here is the GDB debug info:
Please let me know if you need more information. |
Hello @B-Galati, this is still with PHP 8.1.14? Thanks in advance |
Hello again @B-Galati, another thing: can you try with Kind regards |
@realFlowControl Still with 8.1.14 yes.
I am going to try to disable |
@realFlowControl Disabling |
This is never supposed to fail, but better check for it than avoiding it. Fixes an issue reported in #1880. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This is never supposed to fail, but better check for it than avoiding it. Fixes an issue reported in #1880. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Thanks! You guys are awesome 👍 What a reactivity! |
Hi! Do you have an ETA for the next release? |
Hey @B-Galati, |
Hey @B-Galati, sorry that releasing took a while, but 0.85.0 is out now, with all the fixes. I'll close that issue now, but feel free to re-open if there are still issues. |
Thank you!! 🎉🙏 |
Hello @bwoebi, that's still KO but I cannot get any backtrace now 🤔 How could I help? Here is what I got but I don't think it's gonna help much:
|
Hello @B-Galati, we had another issue (#1919) which sounds like it might have the same root cause as your problem. The fix for this is in #1975, has been merged already and will be released in In short: When running |
Thanks for the heads-up! Will try and let you know then. Thanks again 🙏 |
Hey @realFlowControl, That's still KO sadly 😢 No backtrace, no error message. Looks to work fine when commenting out the preload config |
Hey there 👋
Is this correct? Can you attach (or post in a Slack DM) your PHP-FPM logs? |
@realFlowControl hey thanks! Some updates:
And disabling I have no particular logs with PHP-FPM sadly 😅 |
I have a similar crash that only happens on 0.86.0 (works fine on 0.85.0) for both PHP8.1.17 and PHP8.2.4 docker images (based on php:fpm-bullseye images from dockerhub) in kubernetes. I only get the issue if profiling is enabled. No difference if I:
if I run with
Which doesn't seem useful. Downgrading to 0.85.0 seems to resolve the issue for us. So this may not be identical issue to the OP, but this is the closest in behaviour that I can determine. |
Hey @grigi, I see you don't get a core dump, which would be super useful for us. Our troubleshooting guide could help you setup everything so that you get a core dump and could provide us with a backtrace to this segmentation fault. Let me know if you need additional help obtaining a core dump. |
I have not been able to replicate the issue outside of our production kubernetes cluster. Unfortunarely I don't think I'll be able to get you a core dump anytime soon. |
crosslinking related sigsegv/segfault issue that was fixed on March 30th with 0.86.1 #1993 |
Hello!
Bug description
I am currently using Datadog tracer and it's fine. Trying to enable Datadog profiler extension is causing PHP-FPM to produce segfault. PHP CLI is doing well ✔️
I found 2 things that fixes the issue:
In some ways it looks like to these 2 issues:
Output of
gdb
:PHP version
Tracer version
Installed extensions
Expand
OS info
Diagnostics and configuration
Expand
Upgrading info
I am upgrading from 0.75.0 but it's the same problem with 0.75.0. Installing the profiler extension is what triggers the issue.
The text was updated successfully, but these errors were encountered: