Load API files relative to the ComposerBootstrap.php instead of the ddtrace autoloader #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/fix-composer-autoload-preload
branch
from
7716fec
to
189b952
Compare
…dtrace autoloader The current code assumes a src/ directory exists next to the ddtrace bridge, which is not the case in actually installed environments. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/fix-composer-autoload-preload
branch
from
189b952
to
544238e
Compare
bridge/autoload.php
Outdated
| @@ -41,10 +41,12 @@ | |||
| return; | |||
| } | |||
|
|
|||
| $base_dir = __DIR__ . '/../src/api/'; | |||
| // All API files are in the same directory as the ComposerBootstrap file | |||
| $bootstrapClass = new ReflectionClass('DDTrace\ComposerBootstrap'); | |||
There was a problem hiding this comment.
This will throw if the class isn't found. This is guarded by the above if, but I'd be happier if they used a variable or a constant or something so it's harder to get accidentally get them out-of-sync.
There was a problem hiding this comment.
Added a variable :-)
morrisonlevi
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an issue with preloading.
The current code assumes a src/ directory exists next to the ddtrace bridge, which is not the case in actually installed environments.
Readiness checklist
Reviewer checklist