Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for memcached on PHP 8 #1558

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add support for memcached on PHP 8 #1558

merged 1 commit into from
Apr 5, 2022

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 4, 2022

Fixes #1535.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.72.0 milestone Apr 4, 2022
@bwoebi
Add support for memcached on PHP 8
4fcb076 
Fixes #1535.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
labbati
labbati reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but we should just run again the failing tests once 8.0 and 8.1 buster images get pushed.

labbati
labbati previously approved these changes Apr 5, 2022
View reviewed changes
labbati
labbati approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwoebi bwoebi merged commit 5995fe1 into master Apr 5, 2022
@bwoebi bwoebi deleted the bob/add-memcached-php8 branch April 5, 2022 12:43
@labbati labbati mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.72.0
Development

Successfully merging this pull request may close these issues.

[BUG] Memcached Tracing Not Working with PHP 8.0.16 and 0.70.0 and 0.70.1
2 participants
@bwoebi @labbati