Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Memcached Tracing Not Working with PHP 8.0.16 and 0.70.0 and 0.70.1 #1535

Closed
gman-wa opened this issue Mar 4, 2022 · 8 comments · Fixed by #1558
Closed

[BUG] Memcached Tracing Not Working with PHP 8.0.16 and 0.70.0 and 0.70.1 #1535

gman-wa opened this issue Mar 4, 2022 · 8 comments · Fixed by #1558
Labels
🐛 bug Something isn't working cat:integration

Comments

@gman-wa
Copy link

gman-wa commented Mar 4, 2022

Bug description

Using the memcached module with PHP 8.0.16 with dd-trace-php and memcache tracing does not appear in DD APM.

As soon as 8.0.16 comes online, tracing stops.

Reverting to 7.4.28 and memcached tracing comes back.

mod_Memcache built from:

https://github.com/php-memcached-dev/php-memcached

PHP version

PHP 7.4.28 and PHP 8.0.16

Tracer version

0.70.0 and 0.70.1

Installed extensions

core mod_so mod_watchdog http_core mod_log_config mod_logio mod_version mod_unixd mod_access_compat mod_alias mod_auth_basic mod_authn_core mod_authn_file mod_authz_core mod_authz_host mod_authz_user mod_autoindex mod_deflate mod_dir mod_env mod_filter mod_headers mod_mime prefork mod_negotiation mod_php7 mod_remoteip mod_reqtimeout mod_rewrite mod_setenvif mod_speling mod_status

OS info

(PHP 7.4) Linux ab8a10850926 4.14.262-200.489.amzn2.x86_64 #1 SMP Fri Feb 4 20:34:30 UTC 2022 x86_64

Diagnostics and configuration

Output of phpinfo() (ddtrace >= 0.47.0)

PHP 7.4 DD PHP Trace Config

{"date":"2022-03-02T05:53:21Z","os_name":"Linux 7da1241b144d 4.14.262-200.489.amzn2.x86_64 #1 SMP Fri Feb 4 20:34:30 UTC 2022 x86_64","os_version":"4.14.262-200.489.amzn2.x86_64","version":"0.70.0","lang":"php","lang_version":"7.4.21","env":"qa-r2d2","enabled":true,"service":"php","enabled_cli":false,"agent_url":"http://172.17.0.1:8126","debug":false,"analytics_enabled":false,"sample_rate":1,"sampling_rules":[],"tags":[],"service_mapping":[],"distributed_tracing_enabled":true,"priority_sampling_enabled":true,"dd_version":null,"architecture":"x86_64","sapi":"apache2handler","datadog.trace.request_init_hook":"/opt/datadog-php/dd-trace-sources/bridge/dd_wrap_autoloader.php","open_basedir_configured":false,"uri_fragment_regex":null,"uri_mapping_incoming":null,"uri_mapping_outgoing":null,"auto_flush_enabled":false,"generate_root_span":true,"http_client_split_by_domain":true,"measure_compile_time":true,"report_hostname_on_root_span":false,"traced_internal_functions":null,"auto_prepend_file_configured":false,"integrations_disabled":"default","enabled_from_env":true,"opcache.file_cache":null}

PHP 8.0 DD PHP Trace Config

{"date":"2022-03-01T23:13:46Z","os_name":"Linux bbf65d0242c2 4.14.262-200.489.amzn2.x86_64 #1 SMP Fri Feb 4 20:34:30 UTC 2022 x86_64","os_version":"4.14.262-200.489.amzn2.x86_64","version":"0.70.0","lang":"php","lang_version":"8.0.8","env":"qa-r2d2","enabled":true,"service":"php","enabled_cli":false,"agent_url":"http://172.17.0.1:8126","debug":false,"analytics_enabled":false,"sample_rate":1,"sampling_rules":[],"tags":[],"service_mapping":[],"distributed_tracing_enabled":true,"priority_sampling_enabled":true,"dd_version":null,"architecture":"x86_64","sapi":"apache2handler","datadog.trace.request_init_hook":"/opt/datadog-php/dd-trace-sources/bridge/dd_wrap_autoloader.php","open_basedir_configured":false,"uri_fragment_regex":null,"uri_mapping_incoming":null,"uri_mapping_outgoing":null,"auto_flush_enabled":false,"generate_root_span":true,"http_client_split_by_domain":true,"measure_compile_time":true,"report_hostname_on_root_span":false,"traced_internal_functions":null,"auto_prepend_file_configured":false,"integrations_disabled":"default","enabled_from_env":true,"opcache.file_cache":null}

Upgrading info

PHP 7.4.28 and dd-trace-php works for tracing memcache, PHP 8.0.16 and dd-trace-php does not work for tracing memcache

@gman-wa gman-wa added the 🐛 bug Something isn't working label Mar 4, 2022
@gman-wa
Copy link
Author

gman-wa commented Mar 4, 2022

We also have this crossposted at https://help.datadoghq.com/hc/en-us/requests/701426

@bwoebi
Copy link
Collaborator

bwoebi commented Mar 7, 2022

memcache is currently not supported for PHP 8 in dd-trace-php.

We'll look at adding support for it in the near future.
One thing having us hold back from supporting it, is that there (still) is no proper release of memcached supporting the PHP 8 and PHP 8.1 versions. I've just poked some people for creating a release there...

@gman-wa
Copy link
Author

gman-wa commented Mar 7, 2022

Looks like they may be getting close?

php-memcached-dev/php-memcached#495

@bwoebi
Copy link
Collaborator

bwoebi commented Mar 7, 2022

Yep :-) We'll look at integrating it within the next couple weeks.

@gman-wa
Copy link
Author

gman-wa commented Mar 25, 2022

@gman-wa
Copy link
Author

gman-wa commented Apr 4, 2022

@bwoebi - is there a targeted release for this integration?

@bwoebi
Copy link
Collaborator

bwoebi commented Apr 4, 2022

I'm working on it right now. There's no officially committed target yet, but we're looking at having it ready for the next minor version.

bwoebi added a commit that referenced this issue Apr 4, 2022
Fixes #1535.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this issue Apr 5, 2022
Fixes #1535.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi added a commit that referenced this issue Apr 5, 2022
Fixes #1535.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@gman-wa
Copy link
Author

gman-wa commented Apr 5, 2022

Thanks @bwoebi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working cat:integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants