Fix: Remove dependency on guzzlehttp/psr7 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
changed the title
localheinz
commented
Jul 13, 2018
| interface Transport | ||
| { | ||
| /** | ||
| * @param Span[][] $traces | ||
| * @return ResponseInterface |
There was a problem hiding this comment.
The return value of any of the available implementations in this repository is never used, so it is probably not necessary to return anything from this method at all.
|
|
||
| final class Noop implements Transport | ||
| { | ||
| public function send(array $traces) | ||
| { | ||
| return new Response(); |
composer.json
Outdated
| "opentracing/opentracing": "1.0.0-beta5", | ||
| "psr/http-message": "^1.0", |
There was a problem hiding this comment.
Added this dependency because it is used in
dd-trace-php/src/DDTrace/Encoder.php
Lines 5 to 13 in 8826319
| @@ -21,8 +21,9 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^5.6 || ^7.0", | |||
| "guzzlehttp/psr7": "^1.4.0", | |||
| "ext-curl": "*", | |||
There was a problem hiding this comment.
Since we are using curl, this should probably be a dependency.
|
Thank you, @chuck! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
guzzlehttp/psr7and replaces it withpsr/http-message