Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove dependency on guzzlehttp/psr7 #38

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix: Remove dependency on guzzlehttp/psr7 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@
],
"require": {
"php": "^5.6 || ^7.0",
"guzzlehttp/psr7": "^1.4.0",
"ext-curl": "*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using curl, this should probably be a dependency.

"opentracing/opentracing": "1.0.0-beta5",
"psr/http-message": "^1.0",
"psr/log": "^1.0.0",
"symfony/polyfill-php70": "^1.8.0"
},
Expand Down
3 changes: 0 additions & 3 deletions src/DDTrace/Transport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@

namespace DDTrace;

use Psr\Http\Message\ResponseInterface;

interface Transport
{
/**
* @param Span[][] $traces
* @return ResponseInterface
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value of any of the available implementations in this repository is never used, so it is probably not necessary to return anything from this method at all.

*/
public function send(array $traces);

Expand Down
2 changes: 0 additions & 2 deletions src/DDTrace/Transport/Noop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
namespace DDTrace\Transport;

use DDTrace\Transport;
use GuzzleHttp\Psr7\Response;

final class Noop implements Transport
{
public function send(array $traces)
{
return new Response();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

}

public function setHeader($key, $value)
Expand Down