Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream issue localstack/localstack#5395 closed #4677

Closed
github-actions bot opened this issue Nov 30, 2022 · 3 comments · Fixed by #5399
Closed

Upstream issue localstack/localstack#5395 closed #4677

github-actions bot opened this issue Nov 30, 2022 · 3 comments · Fixed by #5399

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022 •
edited
Loading

Upstream issue localstack/localstack#5395 referenced in the file:

has been closed.

The code referencing this issue could potentially be updated.
@Yun-Kim
Copy link
Contributor

Yun-Kim commented Jan 25, 2023

@hghotra It looks like this upstream issue has been closed. Can you confirm if we can update localstack as you mentioned once this issue was resolved? Thanks!

@github-actions github-actions bot added the stale label Feb 25, 2023
@emmettbutler
Copy link
Collaborator

I spent some time today trying to get these tests to work after uncommenting them and upgrading to the latest version of localstack. As far as I can tell, the tests need some adjustments aside from just uncommenting them, and I'm not sure exactly what those adjustments are because the error message from localstack is a bit cryptic:

FAILED tests/contrib/botocore/test.py::BotocoreTest::test_sns_send_message_trace_injection_with_no_message_attributes - botocore.errorfactory.InvalidParameterException: An error occurred (InvalidParameter) when calling the Subscribe operation: Invalid parameter: SQS endpoint ARN

@github-actions github-actions bot removed the stale label Mar 23, 2023
@emmettbutler
Copy link
Collaborator

I've opened #5399 where I'm working on fixing this

@emmettbutler emmettbutler mentioned this issue Mar 23, 2023
Merged
15 tasks
emmettbutler added a commit that referenced this issue Mar 28, 2023
@emmettbutler @majorgreys
ci(boto): update the version of localstack used in tests (#5399)
e6adaaf 
This change fixes #4677 by implementing tests that exercise SNS
MessageAttribute from publish_batch calls.

Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
IlyaMichlin pushed a commit to IlyaMichlin/dd-trace-py that referenced this issue Mar 30, 2023
@emmettbutler @majorgreys @IlyaMichlin
ci(boto): update the version of localstack used in tests (DataDog#5399)
f09e3ef 
This change fixes DataDog#4677 by implementing tests that exercise SNS
MessageAttribute from publish_batch calls.

Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(boto): update the version of localstack used in tests DataDog/dd-trace-py
2 participants
@emmettbutler @Yun-Kim