Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): fix telemetry URL for EU [backport 2.9] #10055

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

vitor-de-araujo
Copy link
Contributor

@vitor-de-araujo vitor-de-araujo commented Aug 2, 2024

Backport 513f7e5 from #10021 to 2.9.

This PR fixes incorrect URL for telemetry intake in EU that was causing missing telemetry data and SSL error log messages.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Backport 513f7e5 from #10021 to 2.9.

This PR fixes incorrect URL for telemetry intake in EU that was causing
missing telemetry data and SSL error log messages.
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 2, 2024

Datadog Report

Branch report: backport-10021-to-2.9
Commit report: 78cfe57
Test service: dd-trace-py

✅ 0 Failed, 492 Passed, 12 Skipped, 2m 12.14s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 10.22%. Comparing base (fc6ee13) to head (f02c60b).
Report is 2 commits behind head on 2.9.

Files Patch % Lines
ddtrace/internal/telemetry/writer.py 0.00% 1 Missing ⚠️
tests/telemetry/test_writer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.9   #10055      +/-   ##
==========================================
- Coverage   19.06%   10.22%   -8.84%     
==========================================
  Files        1259     1258       -1     
  Lines      120828   120848      +20     
==========================================
- Hits        23032    12356   -10676     
- Misses      97796   108492   +10696     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 2, 2024

Benchmarks

Benchmark execution time: 2024-08-02 11:37:21

Comparing candidate commit f02c60b in PR branch backport-10021-to-2.9 with baseline commit 4d73860 in branch 2.9.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 175 metrics, 9 unstable metrics.

@romainkomorndatadog romainkomorndatadog changed the title fix(internal): fix telemetry URL for EU (#10021) fix(internal): fix telemetry URL for EU [backport 2.9] Aug 2, 2024
@brettlangdon brettlangdon enabled auto-merge (squash) August 2, 2024 12:54
@brettlangdon brettlangdon merged commit 51ed3d5 into 2.9 Aug 2, 2024
76 of 82 checks passed
@brettlangdon brettlangdon deleted the backport-10021-to-2.9 branch August 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants