Store span ids in profiling events #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
force-pushed
the
threads-to-trace-id
branch
from
372760e
to
f97f8ef
Compare
brettlangdon
reviewed
Sep 3, 2019
brettlangdon
reviewed
Sep 3, 2019
tests/test_tracer.py
Outdated
|
|
||
| span2 = self.span2 | ||
| del self.span2 | ||
| assert self.tracer.thread_to_span[th.ident] == span2 |
There was a problem hiding this comment.
If we call span2.finish(), th.ident should be removed from self.tracer.thread_to_span correct?
There was a problem hiding this comment.
Not necessarily; it'll be removed as soon there's no ref to span2 and once the GC has run.
jd
force-pushed
the
threads-to-trace-id
branch
from
f97f8ef
to
28d5e72
Compare
majorgreys
reviewed
Apr 30, 2020
ddtrace/_linker.py
Outdated
Comment on lines
36
to
43
| for span in set(spans): | ||
| if not span.finished: | ||
| try: | ||
| spans.remove(span._parent) | ||
| except KeyError: | ||
| pass | ||
|
|
||
| return {span for span in spans if not span.finished} |
There was a problem hiding this comment.
Reuse the other function and use set difference.
Suggested change
| for span in set(spans): | |
| if not span.finished: | |
| try: | |
| spans.remove(span._parent) | |
| except KeyError: | |
| pass | |
| return {span for span in spans if not span.finished} | |
| active_spans = self.get_active_spans_from_thread_id(thread_id) | |
| return active_spans - {span._parent for span in active_spans} |
jd
changed the title
jd
force-pushed
the
threads-to-trace-id
branch
2 times, most recently
from
782d4ee
to
0deb7ca
Compare
|
Could we move the hooks changes to a separate PR? Not super necessary, just a tad cleaner 😄 |
|
The hooks changed have being pulled out in #1428 |
jd
force-pushed
the
threads-to-trace-id
branch
2 times, most recently
from
6b19054
to
9144b60
Compare
This allows to register a function to be called when a new span is being started by a Tracer.
Kyle-Verhoog
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(tracer): add a on_start_span hook
This allows to register a function to be called when a new span is being
started by a Tracer.
chore(black): blackify ddtrace/settings
feat(profiling/stack): collect span ids for running thread and stack frames