Make hooks settings generic #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2020
This move the hooks class away of settings so it can be used by non-settings code without import statement looking weird. It also hides the module as being private.
The only user of this API seems to always send a span and nothing breaks while removing this check.
That makes sure we are able to deregister a hook for a particular event.
Kyle-Verhoog
previously approved these changes
May 12, 2020
Kyle-Verhoog
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: move hooks module out of settings
This move the hooks class away of settings so it can be used by non-settings
code without import statement looking weird.
It also hides the module as being private.
refactor(hooks): make
emita public methodrefactor(hooks): leverage attr to simplify code
refactor(hooks): remove span argument
The only user of this API seems to always send a span and nothing breaks while
removing this check.
chore: add _hooks to black
feat(hooks): make deregister take a
hookargumentThat makes sure we are able to deregister a hook for a particular event.