fix(core): always store span_type as str on span #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
approved these changes
Sep 2, 2020
majorgreys
pushed a commit
that referenced
this pull request
Sep 10, 2020
Formerly if the span_type field was assigned to a Span object as a SpanType then it would fail to encode since the encoding does not handle the enum. This patch fixes this by making span_type a property and storing the enum value on the span. * add tests for varying span properties * add setter for span_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly if the span_type field was assigned to a Span object as a
SpanTypethen it would fail to encode since the encoding does not handle the enum. This patch fixes this by makingspan_typea property and storing the enum value on the span.thanks to @thehesiod for discovering this one!