Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(django): add database_service_name config option #1640

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

Kyle-Verhoog
Copy link
Member

This allows the configuration of the service name directly in addition to providing a prefix.

@Kyle-Verhoog Kyle-Verhoog added this to the 0.42.0 milestone Sep 3, 2020
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner September 3, 2020 02:32
jenny-zhong
jenny-zhong previously approved these changes Sep 3, 2020
Copy link

@jenny-zhong jenny-zhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just needs a comment in docs for the precedence order of service name over the prefix.

@Kyle-Verhoog Kyle-Verhoog merged commit c0ad3a7 into master Sep 4, 2020
@Kyle-Verhoog Kyle-Verhoog deleted the kyle-verhoog/service-django branch September 4, 2020 16:50
majorgreys pushed a commit that referenced this pull request Sep 10, 2020
This allows the configuration of the service name directly in addition to providing a prefix.

* feat(django): add database_service_name config option

* specify precedence in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants