Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): pin importlib_metadata<5.0.0 (backport #4257) #4289

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 6, 2022

This is an automatic backport of pull request #4257 done by Mergify.
Cherry-pick of c2b416e has failed:

On branch mergify/bp/0.61/pr-4257
Your branch is up to date with 'origin/0.61'.

You are currently cherry-picking commit c2b416e7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   riotfile.py
	modified:   tox.ini

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .circleci/config.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

CI jobs `profile-windows-*`, `kombu` and `celery` are failing due to the release of `importlib_metadata==5.0.0` which removed deprecated shims, resulting in the following exception:

```
AttributeError: 'EntryPoints' object has no attribute 'get'
```

We fix this by pinning the dependency for kombu and celery. In the case of the Windows tests, we address it by upgrading the Windows image to a version that includes Python 3.10 rather than Python 3.7 which removes the need to install the dependency when installing tox.

- [Example log of failing job](https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/21679/workflows/2a7606b5-9ca8-4212-9b02-053665de0198/jobs/1477147)
- python/importlib_metadata#409

(cherry picked from commit c2b416e)

# Conflicts:
#	.circleci/config.yml
@mergify mergify bot requested a review from a team as a code owner October 6, 2022 00:52
@mergify mergify bot added the conflicts label Oct 6, 2022
@mergify mergify bot removed the conflicts label Oct 6, 2022
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 6, 2022
@Kyle-Verhoog Kyle-Verhoog merged commit 2a8b12b into 0.61 Oct 24, 2022
@Kyle-Verhoog Kyle-Verhoog deleted the mergify/bp/0.61/pr-4257 branch October 24, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants