[opentracer] Add elasticsearch test #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
reviewed
Sep 5, 2018
tests/contrib/elasticsearch/test.py
Outdated
| @@ -145,6 +145,45 @@ def test_elasticsearch(self): | |||
| es.indices.delete(index=self.ES_INDEX, ignore=[400, 404]) | |||
| es.indices.delete(index=self.ES_INDEX, ignore=[400, 404]) | |||
|
|
|||
| def test_elasticsearch_ot(self): | |||
| """Shortened OpenTracing version of test_elasticsearch.""" | |||
| from tests.opentracer.utils import init_tracer | |||
There was a problem hiding this comment.
Imports at the top of the module. Also can you manually check it with flake8?
There was a problem hiding this comment.
flake8 doesn't seem to complain, but I'll move it to the top.
palazzem
approved these changes
Sep 7, 2018
Kyle-Verhoog
added a commit
that referenced
this pull request
Sep 7, 2018
* [opentracer] add elasticsearch test * [opentracer] move un-inline import
Kyle-Verhoog
added a commit
that referenced
this pull request
Sep 10, 2018
* [opentracer] add elasticsearch test * [opentracer] move un-inline import
brettlangdon
added a commit
that referenced
this pull request
Jul 24, 2023
This fix introduces a few changes to improve overall CircleCI job runtime. **Before:** - Runtime: 28+ minutes - Credits: 33k **After:** - Runtime: ~22 minutes (-20%) - Credits: ~15k (-55%) ### Fix mysql test pattern The `mysql` CircleCI job was using the pattern "mysql", which would also match the `mysqldb` jobs. This change updates the test pattern for all mysql jobs to include an ending `$`. <details> <summary>Before</summary> ``` ❯ riot list mysql No. Hash Name Interpreter Environment Packages #554 1a1c1fa mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #555 8ba1245 mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #556 1e72d9c mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #557 16025dc mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #558 1cdb1c5 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #559 1230ff8 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.29' #560 729b5a8 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #561 1133f63 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #562 129b0f2 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #563 12db871 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #564 270f95a mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #565 9182ae0 mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #566 137147e mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.28' #567 f26af3b mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #568 2eb00ea mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.31' #569 10d623a mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #1450 9be82d5 mysqldb Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=1.4.6' #1451 17a3e91 mysqldb Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=1.4.6' #1452 1c338bf mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1453 162a527 mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1454 19ef42f mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1455 145f708 mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1456 73a2d0b mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1457 11b2766 mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1458 1fcb3db mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1459 1c5e6ed mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1460 137f08a mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1461 149f779 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1462 14a543a mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1463 1eea232 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1464 14a543a mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1465 1eea232 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1466 10bc6fe mysqldb Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1467 bf00ea5 mysqldb Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1468 186525e mysqldb Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1469 8e13da5 mysqldb Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' ``` </details> <details> <summary>After</summary> ``` ❯ riot list "mysql$" No. Hash Name Interpreter Environment Packages #554 1a1c1fa mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #555 8ba1245 mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #556 1e72d9c mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #557 16025dc mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #558 1cdb1c5 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #559 1230ff8 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.29' #560 729b5a8 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #561 1133f63 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #562 129b0f2 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #563 12db871 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #564 270f95a mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #565 9182ae0 mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #566 137147e mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.28' #567 f26af3b mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #568 2eb00ea mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.31' #569 10d623a mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' ``` </details> ### Improve wait job runtime The `wait` job was not running with `-s` and was trying to install the dev package this meant it was taking 3+ minutes to run the `wait` job. We updated the job to ensure it does not install the dev package. Now it runs in <30 seconds. ### Properly restore workspace from build_base_venvs Through debugging we noticed that we were building the base venv/installing dev package in scenarios when we should not have. This is because we were storing the workspace/venvs from `build_base_venvs` incorrectly causing us to reinstall the dev package once per-job * per-node * per-python version. The fix was to checkout the code first and then restore the files from the workspace. The only lead I have as to why/when this started happening is when we added `.riot/requirements/` if the git checkout was overwriting the exiting `.riot/` directory added from the workspace? ### Adjusted parallelism Now that runtime of jobs is improved we can safe some credits by reducing parallelism. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Title is accurate. - [ ] No unnecessary changes are introduced. - [ ] Description motivates each change. - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Testing strategy adequately addresses listed risk(s). - [ ] Change is maintainable (easy to change, telemetry, documentation). - [ ] Release note makes sense to a user of the library. - [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
romainkomorndatadog
pushed a commit
that referenced
this pull request
Aug 8, 2023
This fix introduces a few changes to improve overall CircleCI job runtime. **Before:** - Runtime: 28+ minutes - Credits: 33k **After:** - Runtime: ~22 minutes (-20%) - Credits: ~15k (-55%) ### Fix mysql test pattern The `mysql` CircleCI job was using the pattern "mysql", which would also match the `mysqldb` jobs. This change updates the test pattern for all mysql jobs to include an ending `$`. <details> <summary>Before</summary> ``` ❯ riot list mysql No. Hash Name Interpreter Environment Packages #554 1a1c1fa mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #555 8ba1245 mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #556 1e72d9c mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #557 16025dc mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #558 1cdb1c5 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #559 1230ff8 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.29' #560 729b5a8 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #561 1133f63 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #562 129b0f2 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #563 12db871 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #564 270f95a mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #565 9182ae0 mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #566 137147e mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.28' #567 f26af3b mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #568 2eb00ea mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.31' #569 10d623a mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #1450 9be82d5 mysqldb Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=1.4.6' #1451 17a3e91 mysqldb Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=1.4.6' #1452 1c338bf mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1453 162a527 mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1454 19ef42f mysqldb Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1455 145f708 mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1456 73a2d0b mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1457 11b2766 mysqldb Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1458 1fcb3db mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1459 1c5e6ed mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1460 137f08a mysqldb Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1461 149f779 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.0' #1462 14a543a mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1463 1eea232 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1464 14a543a mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1465 1eea232 mysqldb Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1466 10bc6fe mysqldb Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1467 bf00ea5 mysqldb Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' #1468 186525e mysqldb Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient~=2.1' #1469 8e13da5 mysqldb Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysqlclient' ``` </details> <details> <summary>After</summary> ``` ❯ riot list "mysql$" No. Hash Name Interpreter Environment Packages #554 1a1c1fa mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #555 8ba1245 mysql Interpreter(_hint='2.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #556 1e72d9c mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #557 16025dc mysql Interpreter(_hint='3.5') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.23' #558 1cdb1c5 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #559 1230ff8 mysql Interpreter(_hint='3.6') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.29' #560 729b5a8 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #561 1133f63 mysql Interpreter(_hint='3.7') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #562 129b0f2 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #563 12db871 mysql Interpreter(_hint='3.8') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #564 270f95a mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python==8.0.5' #565 9182ae0 mysql Interpreter(_hint='3.9') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #566 137147e mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.28' #567 f26af3b mysql Interpreter(_hint='3.10') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' #568 2eb00ea mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python~=8.0.31' #569 10d623a mysql Interpreter(_hint='3.11') DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'mysql-connector-python' ``` </details> ### Improve wait job runtime The `wait` job was not running with `-s` and was trying to install the dev package this meant it was taking 3+ minutes to run the `wait` job. We updated the job to ensure it does not install the dev package. Now it runs in <30 seconds. ### Properly restore workspace from build_base_venvs Through debugging we noticed that we were building the base venv/installing dev package in scenarios when we should not have. This is because we were storing the workspace/venvs from `build_base_venvs` incorrectly causing us to reinstall the dev package once per-job * per-node * per-python version. The fix was to checkout the code first and then restore the files from the workspace. The only lead I have as to why/when this started happening is when we added `.riot/requirements/` if the git checkout was overwriting the exiting `.riot/` directory added from the workspace? ### Adjusted parallelism Now that runtime of jobs is improved we can safe some credits by reducing parallelism. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Title is accurate. - [ ] No unnecessary changes are introduced. - [ ] Description motivates each change. - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Testing strategy adequately addresses listed risk(s). - [ ] Change is maintainable (easy to change, telemetry, documentation). - [ ] Release note makes sense to a user of the library. - [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add elasticsearch OpenTracing test