Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(profiling): skip failing tests #8241

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jan 31, 2024

This pull request adds skips to a few tests that have been consistently failing for unknown reason on main. They should be reenabled once the root cause is determined.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested review from a team as code owners January 31, 2024 13:39
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 31, 2024
@emmettbutler emmettbutler enabled auto-merge (squash) January 31, 2024 13:44
@emmettbutler emmettbutler mentioned this pull request Jan 31, 2024
18 tasks
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A prudent move, thank you!

@emmettbutler emmettbutler merged commit 54cea47 into main Jan 31, 2024
137 of 138 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/profile-skips branch January 31, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants