Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only attempt to compress artifact from parametric tests if it was created #8766

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Mar 26, 2024

This change attempts to fix main-branch CI failures like this one by omitting Github Actions workflow steps when they're inapplicable to the current run.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 26, 2024
@emmettbutler emmettbutler requested review from a team as code owners March 26, 2024 14:08
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/compress-conditional
Commit report: 29ea65b
Test service: dd-trace-py

✅ 0 Failed, 146065 Passed, 26592 Skipped, 9h 57m 17.69s Total duration (1h 54m 10.66s time saved)

@emmettbutler emmettbutler enabled auto-merge (squash) March 26, 2024 14:58
@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmarks

Benchmark execution time: 2024-03-26 15:11:01

Comparing candidate commit 29ea65b in PR branch emmett.butler/compress-conditional with baseline commit 08f7e88 in branch main.

Found 4 performance improvements and 4 performance regressions! Performance is the same for 193 metrics, 9 unstable metrics.

scenario:httppropagationextract-all_styles_all_headers

  • 🟥 max_rss_usage [+588.500KB; +809.465KB] or [+2.774%; +3.816%]

scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

  • 🟩 max_rss_usage [-788.978KB; -714.254KB] or [-3.602%; -3.261%]

scenario:httppropagationextract-invalid_priority_header

  • 🟩 max_rss_usage [-755.942KB; -603.930KB] or [-3.469%; -2.772%]

scenario:httppropagationextract-large_valid_headers_all

  • 🟥 max_rss_usage [+545.612KB; +750.363KB] or [+2.579%; +3.547%]

scenario:httppropagationextract-medium_valid_headers_all

  • 🟥 max_rss_usage [+433.267KB; +708.698KB] or [+2.048%; +3.350%]

scenario:httppropagationextract-none_propagation_style

  • 🟩 max_rss_usage [-781.997KB; -717.958KB] or [-3.580%; -3.287%]

scenario:httppropagationextract-valid_headers_all

  • 🟩 max_rss_usage [-586.679KB; -513.916KB] or [-2.688%; -2.354%]

scenario:httppropagationextract-wsgi_valid_headers_all

  • 🟥 max_rss_usage [+488.560KB; +728.771KB] or [+2.313%; +3.450%]

@emmettbutler emmettbutler merged commit bf4915e into main Mar 26, 2024
37 of 38 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/compress-conditional branch March 26, 2024 15:55
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport-8766-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf4915efcbd2c79ae149dc7f2af5f74d32dea3bf
# Push it to GitHub
git push --set-upstream origin backport-8766-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport-8766-to-2.5.

Copy link
Contributor

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport-8766-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf4915efcbd2c79ae149dc7f2af5f74d32dea3bf
# Push it to GitHub
git push --set-upstream origin backport-8766-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport-8766-to-2.6.

Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport-8766-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf4915efcbd2c79ae149dc7f2af5f74d32dea3bf
# Push it to GitHub
git push --set-upstream origin backport-8766-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport-8766-to-2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants