-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): use importlib metadata to infer flask version as the old method is deprecated #8809
chore(tracer): use importlib metadata to infer flask version as the old method is deprecated #8809
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 144386 Passed, 28030 Skipped, 9h 27m 7.09s Total duration (2h 40m 1.74s time saved) |
…f github.com:DataDog/dd-trace-py into christophe-papazian/flask_version_remove_deprecation
BenchmarksBenchmark execution time: 2024-04-02 10:31:07 Comparing candidate commit 35d0e8e in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 198 metrics, 9 unstable metrics. scenario:httppropagationextract-b3_headers
scenario:httppropagationextract-invalid_priority_header
scenario:httppropagationextract-none_propagation_style
|
Change the method we use to infer Flask version, as the current method is deprecated (remove associate warnings from Flask framework).
This PR will ensure the Flask support in the tracer won't break with next Flask 3.1 release.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist