-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): fix traceback max size for exceptions #9112
fix(tracing): fix traceback max size for exceptions #9112
Conversation
1906b70
to
ba889b5
Compare
ba889b5
to
cc10ef4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9112 +/- ##
===========================================
- Coverage 75.92% 9.96% -65.96%
===========================================
Files 1296 1267 -29
Lines 123157 121468 -1689
===========================================
- Hits 93507 12106 -81401
- Misses 29650 109362 +79712 ☔ View full report in Codecov by Sentry. |
DataDog#7558 made the traceback size configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case.
cc10ef4
to
f39a5a4
Compare
@erikayasuda @Kyle-Verhoog Gentle ping—could I please get a review on this when you have a moment? This is impacting our ability to properly track errors in our application via APM. |
@erikayasuda Did you have any comments on the release note? I noticed that you left |
@erikayasuda This PR should be good to go. It looks like just the I don't have merge permissions in this repo, so please feel free to take over and merge when you have a chance to do so. Thank you! |
Hi @quiqueg , sorry for the slow cycles here. I just updated the branch, and enabled auto-merge, so that should merge today assuming the tests all go well. Thanks for the patience! |
@erikayasuda Looks like the |
#7558 made the traceback size configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit 1b954de)
#7558 made the traceback size configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit 1b954de)
#7558 made the traceback size configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <153395705+erikayasuda@users.noreply.github.com> (cherry picked from commit 1b954de)
…9389) Backport 1b954de from #9112 to 2.7. #7558 made the traceback size configurable via `DD_TRACE_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Matt Alexander <1710128+quiqueg@users.noreply.github.com>
…9390) Backport 1b954de from #9112 to 2.8. #7558 made the traceback size configurable via `DD_TRACE_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Matt Alexander <1710128+quiqueg@users.noreply.github.com>
…9391) Backport 1b954de from #9112 to 2.9. #7558 made the traceback size configurable via `DD_TRACE_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Matt Alexander <1710128+quiqueg@users.noreply.github.com>
#7558 made the traceback size configurable via
DD_TRACE_SPAN_TRACEBACK_MAX_SIZE
, but tracebacks for exceptions were still hardcoded with a limit of 30.The fix is modeled after
Span#set_traceback
's existing logic, and tests were modeled after bothtest_traceback_with_error
andtest_custom_traceback_size
. Not much new logic, just an edge case.Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist